Re: fingering-engraver.cc: don't set Fingering.pitch (issue 347930043 by d...@gnu.org)

2018-08-02 Thread dak
Reviewers: lemzwerg, Message: On 2018/08/03 03:24:40, lemzwerg wrote: LGTM. I suggest that you do such trivial clean-ups directly in the git repository, not wasting your time with setting up an issue. If Han-Wen did not see fit to remove the line but instead went to the trouble of adding a

Re: What's up with grob property "skyline-quantizing" ?

2018-08-02 Thread David Kastrup
madMuze writes: > David Kastrup wrote >> Should we stick with that and just drop the name of the property >> altogether? It does not seem like it has been missed all that much... > > I prefer being able to set the option. For me, the default is much too > rough. If it is a matter of computation

Re: What's up with grob property "skyline-quantizing" ?

2018-08-02 Thread madMuze
David Kastrup wrote > Should we stick with that and just drop the name of the property > altogether? It does not seem like it has been missed all that much... I prefer being able to set the option. For me, the default is much too rough. If it is a matter of computation speed, a user-settable prop

fingering-engraver.cc: don't set Fingering.pitch (issue 347930043 by d...@gnu.org)

2018-08-02 Thread lemzwerg
LGTM. I suggest that you do such trivial clean-ups directly in the git repository, not wasting your time with setting up an issue. https://codereview.appspot.com/347930043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/m

Re: What's up with grob property "skyline-quantizing" ?

2018-08-02 Thread Torsten Hämmerle
David Kastrup wrote > Should we stick with that and just drop the name of the property > altogether? It does not seem like it has been missed all that much... Hi David, For long slurs or (in particular steep ones or ones with strong curvature), it might be desirable to have a better skyline qua

What's up with grob property "skyline-quantizing" ?

2018-08-02 Thread David Kastrup
This property is being used in lily/slur.cc in MAKE_SCHEME_CALLBACK (Slur, vertical_skylines, 1); SCM Slur::vertical_skylines (SCM smob) { Grob *me = unsmob (smob); vector boxes; if (!me) return Skyline_pair (boxes, X_AXIS).smobbed_copy (); Bezier curve = Slur::get_curve (me); vs