Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

2018-07-14 Thread nine . fierce . ballads
https://codereview.appspot.com/357760043/diff/20001/stepmake/stepmake/texinfo-rules.make File stepmake/stepmake/texinfo-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/stepmake/stepmake/texinfo-rules.make#newcode70 stepmake/stepmake/texinfo-rules.make:70: ifeq ($(WEB_VER

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

2018-07-14 Thread dak
On 2018/07/14 08:22:49, trueroad wrote: Unfortunately, we cannnot specify an output filename for LaTeX. I thought -jobname works for that. It also affects all temporary files, however. https://codereview.appspot.com/357760043/ ___ lilypond-devel

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

2018-07-14 Thread nine . fierce . ballads
https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make File make/lilypond-book-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33 make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf On 2018/07/14 08

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

2018-07-14 Thread trueroad
Thank you for your reviewing. https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make File make/lilypond-book-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33 make/lilypond-book-rules.make:33: mv $@ $(outdi

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

2018-07-14 Thread dak
https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make File make/lilypond-book-rules.make (right): https://codereview.appspot.com/357760043/diff/20001/make/lilypond-book-rules.make#newcode33 make/lilypond-book-rules.make:33: mv $@ $(outdir)/$*.tmp.pdf This appears to

Re: Issue 5381: Change intermediate PDF filename (issue 357760043 by truer...@gmail.com)

2018-07-14 Thread trueroad
Thank you for your reviewing. On 2018/07/14 06:49:26, lemzwerg wrote: LGTM, thanks! Two minor suggestions: s/intermediate/tmp/, since this is shorter. Please wrap the extremely long lines in the makefiles for improved readability. Done. https://codereview.appspot.com/357760043/

Re: GUB

2018-07-14 Thread David Kastrup
Masamichi Hosoda writes: > I found a possibility that the wrong PDF is output > if the build directory is not clean. >>> >>> I've created the patch. >>> https://sourceforge.net/p/testlilyissues/issues/5380/ >>> https://codereview.appspot.com/355750043 >> >> Thanks a lot! > > If I underst