Re: Doc: document grob metadata in SVG output in Notation Reference (issue 357720044 by paulwmor...@gmail.com)

2018-06-22 Thread paulwmorris
On 2018/06/22 07:18:20, lilypond-pkx wrote: https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely#newcode2780 Documentation/notatio

Re: Add and use a Transform data type (issue 344970043 by d...@gnu.org)

2018-06-22 Thread Hans Åberg
> On 22 Jun 2018, at 14:27, David Kastrup wrote: > > What would that be good for concerning this issue? Only you know that: you did not like the explicit constructor for some reason, but didn't detail. ___ lilypond-devel mailing list lilypond-dev

Re: Add and use a Transform data type (issue 344970043 by d...@gnu.org)

2018-06-22 Thread David Kastrup
Hans Åberg writes: >> On 22 Jun 2018, at 11:09, David Kastrup wrote: >> >> Hans Åberg writes: >> You could also do it as a constructor, if you prefer its syntax and don't mind implementing yet another one: explicit Transform(const Transform *t) ... >>> >>> One can also

Re: Add and use a Transform data type (issue 344970043 by d...@gnu.org)

2018-06-22 Thread Hans Åberg
> On 22 Jun 2018, at 11:09, David Kastrup wrote: > > Hans Åberg writes: > >>> You could also do it as a constructor, if you prefer its syntax and >>> don't mind implementing yet another one: >>> >>> explicit Transform(const Transform *t) ... >> >> One can also use a tag type argument in th

Re: Add and use a Transform data type (issue 344970043 by d...@gnu.org)

2018-06-22 Thread David Kastrup
Hans Åberg writes: >> On 21 Jun 2018, at 00:30, nine.fierce.ball...@gmail.com wrote: > >> Maybe a function would help: >> >>Transform make_transform(const Transform *t) >> { >>return t ? Transform (*t) : Transform (); >> } >> >> You could also do it as a constructor, if

Re: Add and use a Transform data type (issue 344970043 by d...@gnu.org)

2018-06-22 Thread Hans Åberg
> On 21 Jun 2018, at 00:30, nine.fierce.ball...@gmail.com wrote: > Maybe a function would help: > >Transform make_transform(const Transform *t) > { >return t ? Transform (*t) : Transform (); > } > > You could also do it as a constructor, if you prefer its syntax and > d

Re: Doc: document grob metadata in SVG output in Notation Reference (issue 357720044 by paulwmor...@gmail.com)

2018-06-22 Thread pkxgnugitcl
https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/357720044/diff/1/Documentation/notation/input.itely#newcode2780 Documentation/notation/input.itely:2780: @node SVG Output I think yo