Re: Place barres on fret diagrams if they can be inferred (issue 294570043 by carl.d.soren...@gmail.com)

Reviewers: thomasmorley651, Message: Harm, Thanks for the great comments. If the user doesn't want the barre to be displayed, they can avoid it by setting fret-diagram-details.barre-type = #'none Thanks, Carl https://codereview.appspot.com/294570043/diff/1/scm/translation-functions.scm Fil

Place barres on fret diagrams if they can be inferred (issue 294570043 by carl.d.soren...@gmail.com)

Hi Carl, nice work. A general thought: As far as I understand the code will work automatically. Though, I foresee some users wanting to switch it off (ofcourse not the majority, but there is always somebody with different wishes). Any chance to create an option for it? Some inline remarks below

Re: issue 5319: Make skylines reflect grob rotation (issue 342060043 by torsten.haemme...@web.de)

On 2018/05/03 17:42:22, lemzwerg wrote: LGTM https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc File lily/key-signature-interface.cc (right): https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc#newcode114 lily/key-signature-interfac

Re: issue 5319: Make skylines reflect grob rotation (issue 342060043 by torsten.haemme...@web.de)

LGTM https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc File lily/key-signature-interface.cc (right): https://codereview.appspot.com/342060043/diff/1/lily/key-signature-interface.cc#newcode114 lily/key-signature-interface.cc:114: padding += (intersection (ht_right,

Re: issue 5319: Make skylines reflect grob rotation (issue 342060043 by torsten.haemme...@web.de)

I am top posting Torsten, Can you make a new patch based on current master as this one no longer applies so I cannot test it even without the *.cc file - I think it is because of a recent push to master for changes.tely this morning. James On Thu, 03 May 2018 05:51:11 -0700, torsten.haemm

PATCHES - Countdown for May 3rd

Hello, Here is the current patch countdown list. The next countdown will be on May 6th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: No patches to push at this time. Countdown: 5317 Crash when running mu

issue 5319: Make skylines reflect grob rotation (issue 342060043 by torsten.haemme...@web.de)

Reviewers: , Message: Please review... Inadvertently, file ../lily/key-signature-interface.cc slipped into the patch (from issue 5312 currently in staging). So ignore is (or shall I upload a new, cleansed patch for reviewing?) Thanks, Torsten Description: issue 5319: Make skylines reflect gro

Re: Context regression tests (issue 348760043 by nine.fierce.ball...@gmail.com)

On 2018/05/03 02:48:10, Dan Eble wrote: I would appreciate a close review of these tests by at least one of the long-time contributors or pro users. Contexts are a central part of LilyPond and if I've misjudged how any of these cases should work, I don't want it to slip by. Thanks. If