Re: Issue 5284: improve ASSIGN_EVENT_ONCE (issue 338540043 by nine.fierce.ball...@gmail.com)

2018-03-07 Thread nine . fierce . ballads
On 2018/03/07 23:54:41, Dan Eble wrote: Rephrase warning Notice that because the flow of the message is quite different now, I chose not to bother stripping "-event" from the event name anymore. https://codereview.appspot.com/338540043/ ___ lilypon

Re: Issue 5284: improve ASSIGN_EVENT_ONCE (issue 338540043 by nine.fierce.ball...@gmail.com)

2018-03-07 Thread Carl . D . Sorensen
I haven't tested the functionality, but I noticed that the warning messages were not consistent with the LilyPond guidelines on localization. https://codereview.appspot.com/338540043/diff/20001/lily/stream-event.cc File lily/stream-event.cc (right): https://codereview.appspot.com/338540043/diff

Re: broadcasting override-events (was [Re: Edition Engraver bug?])

2018-03-07 Thread Jan-Peter Voigt
Am 07.03.2018 um 15:30 schrieb David Kastrup: Jan-Peter Voigt writes: Am 07.03.2018 um 11:25 schrieb David Kastrup: Check the source code in lily/property-iterator.cc to see what to generate here for the various events (Push/Pop correspond to override/revert). Thank you David! This allows m

Re: broadcasting override-events (was [Re: Edition Engraver bug?])

2018-03-07 Thread David Kastrup
Jan-Peter Voigt writes: > Am 07.03.2018 um 11:25 schrieb David Kastrup: >> Check the source code in lily/property-iterator.cc to see what to >> generate here for the various events (Push/Pop correspond to >> override/revert). > > Thank you David! This allows me to refactor the code. Actually, Pu

Re: broadcasting override-events (was [Re: Edition Engraver bug?])

2018-03-07 Thread Jan-Peter Voigt
Am 07.03.2018 um 11:25 schrieb David Kastrup: Check the source code in lily/property-iterator.cc to see what to generate here for the various events (Push/Pop correspond to override/revert). Thank you David! This allows me to refactor the code. Jan-Peter __

Re: broadcasting override-events (was [Re: Edition Engraver bug?])

2018-03-07 Thread David Kastrup
Jan-Peter Voigt writes: > Hi David and all, > > I [am] stuck with successfully sending override-events from an > engraver. I created an example where I broadcast 3 events, one of them > being an override, but the override is not applied while the other 2 > events are processed as expected. All e

broadcasting override-events (was [Re: Edition Engraver bug?])

2018-03-07 Thread Jan-Peter Voigt
Hi David and all, I stuck with successfully sending override-events from an engraver. I created an example where I broadcast 3 events, one of them being an override, but the override is not applied while the other 2 events are processed as expected. All events are sent using the same procedure

PATCHES - Countdown for March 7th

2018-03-07 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on March 10th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5282 Web: update wording on Bug reports page - Simon Albrecht https:/