Re: add a generic markFormatter function (issue 337400043 by lilyp...@maltemeyn.de)

2018-01-04 Thread lemzwerg
https://codereview.appspot.com/337400043/diff/20001/scm/translation-functions.scm File scm/translation-functions.scm (right): https://codereview.appspot.com/337400043/diff/20001/scm/translation-functions.scm#newcode86 scm/translation-functions.scm:86: (define-public (format-mark-generic alphabet

Re: issue 3208: MMRs for > 1 m. only count m. (issue 333340043 by lilyp...@maltemeyn.de)

2018-01-04 Thread benko . pal
On 2018/01/03 20:37:33, Malte Meyn wrote: I think you’re right. (I found the German translation at our university library.) For single measure rests she writes (section II.6) • semibrevis rest for any time signature • exception: brevis rest for 4/2, 8/4 and longer → LilyPond does this but ad

PATCHES - Countdown for January 4th

2018-01-04 Thread James Lowe
Hello Here is the current patch countdown list. The next countdown will be on January 7th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5248 parser.yy: reverse_music_list should heed PostEvents - David Kas

Re: add dynamic n for “niente” to feta (issue 339090043 by lilyp...@maltemeyn.de)

2018-01-04 Thread lemzwerg
LGTM! https://codereview.appspot.com/339090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: add dynamic n for “niente” to feta (issue 339090043 by lilyp...@maltemeyn.de)

2018-01-04 Thread lemzwerg
> Yes, the encoding vector should contain exactly 256 elements. This isn’t the case in other vectors too, I’ll fix that with the next patch set. My answer was a little white lie – actually, the encoding vector can be of any size, AFAIK, but only up the first 256 elements are taken. However, i

Re: add dynamic n for “niente” to feta (issue 339090043 by lilyp...@maltemeyn.de)

2018-01-04 Thread lilypond
On 2018/01/01 17:36:41, lemzwerg wrote: https://codereview.appspot.com/339090043/diff/80001/ps/encodingdefs.ps#newcode721 ps/encodingdefs.ps:721: /.notdef /.notdef /.notdef /.notdef /.notdef Yes, the encoding vector should contain exactly 256 elements. This isn’t the case in other vectors too,

Re: parser.yy: reverse_music_list should heed PostEvents (issue 335270043 by d...@gnu.org)

2018-01-04 Thread dak
Reviewers: Malte Meyn, https://codereview.appspot.com/335270043/diff/1/input/regression/post-events-from-scheme.ly File input/regression/post-events-from-scheme.ly (right): https://codereview.appspot.com/335270043/diff/1/input/regression/post-events-from-scheme.ly#newcode11 input/regression/pos

parser.yy: reverse_music_list should heed PostEvents (issue 335270043 by d...@gnu.org)

2018-01-04 Thread lilypond
LGTM https://codereview.appspot.com/335270043/diff/1/input/regression/post-events-from-scheme.ly File input/regression/post-events-from-scheme.ly (right): https://codereview.appspot.com/335270043/diff/1/input/regression/post-events-from-scheme.ly#newcode11 input/regression/post-events-from-sche