Re: Allow quoted strings as Scheme arguments to markup commands (issue 331820043 by d...@gnu.org)

2017-10-06 Thread thomasmorley65
On 2017/10/06 22:00:07, dak wrote: https://codereview.appspot.com/331820043/diff/20001/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/331820043/diff/20001/python/convertrules.py#newcode3963 python/convertrules.py:3963: str = re.sub (r'(\\(?:justify

Re: Allow quoted strings as Scheme arguments to markup commands (issue 331820043 by d...@gnu.org)

2017-10-06 Thread lilypond
On 2017/10/06 22:00:07, dak wrote: > What > about wordwrap-string, eps-file, with-url, lookup, verbatim-file, > wordwrap-string-internal, and the accordion commands discant, freeBass, stdBass, > stdBassIV, stdBassV, and stdBassVI? Some of them certainly are good candidates, as long as their

Re: Allow quoted strings as Scheme arguments to markup commands (issue 331820043 by d...@gnu.org)

2017-10-06 Thread dak
https://codereview.appspot.com/331820043/diff/20001/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/331820043/diff/20001/python/convertrules.py#newcode3963 python/convertrules.py:3963: str = re.sub (r'(\\(?:justify-string|musicglyph|harp-pedal|simple|po

Re: Allow quoted strings as Scheme arguments to markup commands (issue 331820043 by d...@gnu.org)

2017-10-06 Thread lilypond
https://codereview.appspot.com/331820043/diff/20001/python/convertrules.py File python/convertrules.py (right): https://codereview.appspot.com/331820043/diff/20001/python/convertrules.py#newcode3963 python/convertrules.py:3963: str = re.sub (r'(\\(?:justify-string|musicglyph|harp-pedal|simple|po

Re: Merge_rests_engraver: fix vertical rest positions (issue 334740043 by lilyp...@maltemeyn.de)

2017-10-06 Thread lilypond
On 2017/10/06 09:39:11, dak wrote: I mean exactly what I say: set direction to CENTER (if this would otherwise cause problems, temporarily) and call the original callback in order to determine staff-position. I didn’t manage to use these callbacks correctly but maybe my solution without the

Re: Installing URW++ fonts, issue 4998: why not add wget lines to lilydev-setup.sh?

2017-10-06 Thread Karlin High
On Thu, Oct 5, 2017 at 7:01 AM, Federico Bruni wrote: > Anyway, if we decide that the setup script in LilyDev should include your > proposal, I'll be happy to see a pull request https://github.com/fedelibre/LilyDev/pull/8 If you decide against including this, I will be OK with that. Perhaps 5 or

Re: make test fails → texi2html (?) error

2017-10-06 Thread Malte Meyn
Am 06.10.2017 um 17:20 schrieb Federico Bruni: Il giorno ven 6 ott 2017 alle 16:27, Malte Meyn ha scritto: What’s this? I found the same message in the list archive (https://lists.gnu.org/archive/html/lilypond-devel/2015-03/msg00084.html) but I couldn’t find any other hints what to do now. I

Re: make test fails → texi2html (?) error

2017-10-06 Thread Jean-Charles Malahieude
Le 06/10/2017 à 16:27, Malte Meyn a écrit : Hi list, I tried to compile the regression tests (make test) but this failed with the following message in input/regression/collated-files.texilog.log: Undefined subroutine &main::get_index called at /home/malte/lilypond/Documentation/lilypond-texi

Re: make test fails → texi2html (?) error

2017-10-06 Thread Federico Bruni
Il giorno ven 6 ott 2017 alle 16:27, Malte Meyn ha scritto: What’s this? I found the same message in the list archive (https://lists.gnu.org/archive/html/lilypond-devel/2015-03/msg00084.html) but I couldn’t find any other hints what to do now. If that helps, my texi2html version is 5.0. That

make test fails → texi2html (?) error

2017-10-06 Thread Malte Meyn
Hi list, I tried to compile the regression tests (make test) but this failed with the following message in input/regression/collated-files.texilog.log: Undefined subroutine &main::get_index called at /home/malte/lilypond/Documentation/lilypond-texi2html.init line 2408. What’s this? I found

Re: Merge_rests_engraver: fix vertical rest positions (issue 334740043 by lilyp...@maltemeyn.de)

2017-10-06 Thread dak
On 2017/10/06 08:42:55, Malte Meyn wrote: On 2017/10/06 08:19:46, dak wrote: > Stupid question: is there no way to (re-)use the default callbacks which know > about all those little details? Set `direction` to neutral and call them for > advice? I’m not sure what you mean: Don’t do anythi

Re: Merge_rests_engraver: fix vertical rest positions (issue 334740043 by lilyp...@maltemeyn.de)

2017-10-06 Thread lilypond
On 2017/10/06 08:42:55, Malte Meyn wrote: But there’s this little inconsistency: { \override Rest.staff-position = 0 \override MultiMeasureRest.staff-position = 0 r1 R1 } Hm … I don’t know what I thought when I wrote this. This inconsistency hasn’t to do anything with a situation

Re: Merge_rests_engraver: fix vertical rest positions (issue 334740043 by lilyp...@maltemeyn.de)

2017-10-06 Thread lilypond
On 2017/10/06 08:19:46, dak wrote: Stupid question: is there no way to (re-)use the default callbacks which know about all those little details? Set `direction` to neutral and call them for advice? I’m not sure what you mean: Don’t do anything to Y-offset or staff-position but set directio

Re: Merge_rests_engraver: fix vertical rest positions (issue 334740043 by lilyp...@maltemeyn.de)

2017-10-06 Thread dak
On 2017/10/06 08:12:23, Malte Meyn wrote: Thanks for the suggestions, I’ll apply these fixes, test them, and add a regression test. There’s another issue (already present in the “old” Merge_rests_engraver): Single-bar or non-compressed MMRs in 4/2 time are positioned incorrectly because

Re: Merge_rests_engraver: fix vertical rest positions (issue 334740043 by lilyp...@maltemeyn.de)

2017-10-06 Thread lilypond
Thanks for the suggestions, I’ll apply these fixes, test them, and add a regression test. There’s another issue (already present in the “old” Merge_rests_engraver): Single-bar or non-compressed MMRs in 4/2 time are positioned incorrectly because the engraver assumes they are semibrevis rests. I w