PATCHES - Countdown for April 30th

2017-04-29 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on May 3rd. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push 5125 Don't use SCM_CELL_WORD_1 internal - David Kastrup https://sourcef

Re: Prevent granados.ly image rotation in web.pdf (issue 317560043 by truer...@gmail.com)

2017-04-29 Thread dak
LGTM Now the following does not concern this issue directly but I see two more occurences in input/regression/landscape.ly and input/regression/page-links.ly . I feel ambiguous about either here. I could imagine leaving landscape.ly in "true" landscape while merely using landscape paper size in

Re: Prevent granados.ly image rotation in web.pdf (issue 317560043 by truer...@gmail.com)

2017-04-29 Thread trueroad
Thank you for your opinion. I've removed the comment. https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples/granados.ly File Documentation/ly-examples/granados.ly (right): https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples/granados.ly#newcode12

Re: Prevent granados.ly image rotation in web.pdf (issue 317560043 by truer...@gmail.com)

2017-04-29 Thread dak
https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples/granados.ly File Documentation/ly-examples/granados.ly (right): https://codereview.appspot.com/317560043/diff/20001/Documentation/ly-examples/granados.ly#newcode12 Documentation/ly-examples/granados.ly:12: % If we use

Re: Prevent granados.ly image rotation in web.pdf (issue 317560043 by truer...@gmail.com)

2017-04-29 Thread trueroad
Thank you for your reviewing. Here's new commit message. Issue 5128: Prevent granados.ly image rotation in web.pdf granados.ly used 'landscape symbol for page settings. As a result, granados.pdf which was generated from granados.ly contained `/Rotate 90` that is not supported by

Prevent granados.ly image rotation in web.pdf (issue 317560043 by truer...@gmail.com)

2017-04-29 Thread dak
https://codereview.appspot.com/317560043/diff/1/Documentation/ly-examples/granados.ly File Documentation/ly-examples/granados.ly (right): https://codereview.appspot.com/317560043/diff/1/Documentation/ly-examples/granados.ly#newcode16 Documentation/ly-examples/granados.ly:16: % as landscape lette

Re: Implement extra-offset for system positioning (issue 324810043 by david.nales...@gmail.com)

2017-04-29 Thread dak
On 2017/04/29 00:36:36, david.nalesnik wrote: On 2017/04/28 22:49:25, thomasmorley651 wrote: > So I'd vote for keeping extra-offset as in your last patch-set. > Although I'm aware David K's point is important, I think a user doing manual > positioning, is responsible to deal with possible pr