Re: Fix some programming errors "no interface for property" (issue 321730043 by thomasmorle...@gmail.com)

2017-03-15 Thread lemzwerg
LGTM https://codereview.appspot.com/321730043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix regtest scheme-engraver.ly wrt to guile-2.2 (issue 322720043 by thomasmorle...@gmail.com)

2017-03-15 Thread David Kastrup
thomasmorle...@gmail.com writes: > Reviewers: , > > Message: > Please review. > Instead of simply replacing 1 by (current-error-port) a variable for the > port could have been used probably. > Opinions? current-error-port is a built-in function. Calling it and referencing a variable are not like

Fix regtest scheme-engraver.ly wrt to guile-2.2 (issue 322720043 by thomasmorle...@gmail.com)

2017-03-15 Thread thomasmorley65
Reviewers: , Message: Please review. Instead of simply replacing 1 by (current-error-port) a variable for the port could have been used probably. Opinions? Description: Fix regtest scheme-engraver.ly wrt to guile-2.2 Passing a number to format as the port is deprecated in guile-2.2 Thus using (

Re: [LilyIssues-auto] [testlilyissues:issues] #5097 Fix programming errors associated with texted HorizontalBracket grobs

2017-03-15 Thread David Kastrup
Auto mailings of changes to Lily Issues writes: > Maybe the method in > http://codereview.appspot.com/321730043 > may partly help. > > At least with adding thickness and text to the properties in > horizontal-bracket.cc I got rid of one warning. We shouldn't add properties to grobs/interfaces t

Fix some programming errors "no interface for property" (issue 321730043 by thomasmorle...@gmail.com)

2017-03-15 Thread thomasmorley65
Reviewers: , Message: Please review Description: Fix some programming errors "no interface for property" Adds glissando-skip to the properties in note-column.cc Adds line-thickness to the properties in semi-tie.cc Please review this at https://codereview.appspot.com/321730043/ Affected files

Re: Need some help - build doc fails for me

2017-03-15 Thread Masamichi Hosoda
> Hello, > > I appear no longer to be able to make doc. > > I do not think it is for any particular checkin as I went back to > before 2.19.57 was released and still have problems. > > The 'only' thing I did prior to that was to install > texlive-lang-japanese to see if I could test Hosoda-san's

Re: Need some help - build doc fails for me

2017-03-15 Thread David Kastrup
James writes: > Hello, > > I appear no longer to be able to make doc. > > I do not think it is for any particular checkin as I went back to > before 2.19.57 was released and still have problems. > > The 'only' thing I did prior to that was to install > texlive-lang-japanese to see if I could test

Need some help - build doc fails for me

2017-03-15 Thread James
Hello, I appear no longer to be able to make doc. I do not think it is for any particular checkin as I went back to before 2.19.57 was released and still have problems. The 'only' thing I did prior to that was to install texlive-lang-japanese to see if I could test Hosoda-san's recent checki