LGTM again, thanks!
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc
File lily/open-type-font.cc (right):
https://codereview.appspot.com/300490043/diff/60001/lily/open-type-font.cc#newcode185
lily/open-type-font.cc:185: // FreeType 2.6.2+ has been fixed this
issue.)
/
David Kastrup writes:
> Not with my current patch-in-progress. g++-4.8 seems to do some kind
> of "overloading resolution" by just randomly picking a candidate from
> several it fails to distinguish and then complaining when it does not
> fit. The errors I am getting seem sort of arbitrary rega
Thank you for your reviewing.
https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc
File lily/open-type-font.cc (right):
https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc#newcode160
lily/open-type-font.cc:160: string cff_table = get_otf_table (face,
LGTM, thanks!
https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc
File lily/open-type-font.cc (right):
https://codereview.appspot.com/300490043/diff/20001/lily/open-type-font.cc#newcode160
lily/open-type-font.cc:160: string cff_table = get_otf_table (face, "CFF
");
// For
Am 25.06.2016 um 10:36 schrieb David Kastrup:
David Kastrup writes:
David Kastrup writes:
autogen.sh --noconfigure
configure --prefix=/home/knut/sources/lilybisect/
make -k -j 1 CPU_COUNT=1 all
Logfile attached.
I see a single error. That's ... curious. Have to go to rehearsal now,
wil
Knut Petersen writes:
> Am 25.06.2016 um 10:36 schrieb David Kastrup:
>> Ok, issue 4903 is now in master. What's the news on make -k output
>> now? Does applying the last patch (the one with ENGRAVER_INHERIT in
>> its title) make any difference in the amount of reported errors?
>
> knut@golem:~/
Am 25.06.2016 um 10:36 schrieb David Kastrup:
Ok, issue 4903 is now in master. What's the news on make -k output now? Does applying the last patch (the one with ENGRAVER_INHERIT in its title) make any difference in the amount of reported errors?
knut@golem:~/sources/lily> ../mklily
Building li
David Kastrup writes:
> David Kastrup writes:
>
>> David Kastrup writes:
>>
autogen.sh --noconfigure
configure --prefix=/home/knut/sources/lilybisect/
make -k -j 1 CPU_COUNT=1 all
Logfile attached.
>>>
>>> I see a single error. That's ... curious. Have to go to rehear
David Kastrup writes:
> David Kastrup writes:
>
>>> autogen.sh --noconfigure
>>> configure --prefix=/home/knut/sources/lilybisect/
>>> make -k -j 1 CPU_COUNT=1 all
>>>
>>> Logfile attached.
>>
>> I see a single error. That's ... curious. Have to go to rehearsal now,
>> will investigate later.
