Re: Create \= command for setting spanner-id (issue 268050045 by d...@gnu.org)

2015-10-03 Thread dak
Reviewers: thomasmorley651, https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely#newcode724 Documentation/notation/exp

Create \= command for setting spanner-id (issue 268050045 by d...@gnu.org)

2015-10-03 Thread thomasmorley65
LGTM Some nitpicks: https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): https://codereview.appspot.com/268050045/diff/1/Documentation/notation/expressive.itely#newcode724 Documentation/notation/expressive

Re: Carry multi-measure rests across voices in \partcombine (issue 265410043 by nine.fierce.ball...@gmail.com)

2015-10-03 Thread nine . fierce . ballads
https://codereview.appspot.com/265410043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: multiple TextSpanners per voice

2015-10-03 Thread David Nalesnik
On Sat, Oct 3, 2015 at 12:02 PM, David Nalesnik wrote: > > > So here is a revised version of the TextSpanner code. > > Oh *drat* Attached the wrong file. Apologies... DN \version "2.19" %% Based on the rewrite of Text_spanner_engraver in %% input/regression/scheme-text-spanner.ly #(define (a

Re: multiple TextSpanners per voice

2015-10-03 Thread David Nalesnik
On Fri, Oct 2, 2015 at 5:59 PM, David Nalesnik wrote: > > > On Fri, Oct 2, 2015 at 5:49 PM, David Nalesnik > wrote: > >> >> Horizontal_bracket_engraver achieves correct ordering of nested brackets >> through the side-position-interface array 'side-position-elements. >> Brackets closer to the sta

Re: Issue 4622: create a class (issue 265260043 by nine.fierce.ball...@gmail.com)

2015-10-03 Thread dak
On 2015/10/03 12:42:19, Dan Eble wrote: I've marked the ticket as "needs work" for now. I still have questions. It *would* be nice to be able to say \override Staff.partCombineParameter = #x \partcombine \one \two ... and have the part combiner get its initial settings from the

Re: Issue 4622: create a class (issue 265260043 by nine.fierce.ball...@gmail.com)

2015-10-03 Thread nine . fierce . ballads
I've marked the ticket as "needs work" for now. I still have questions. It *would* be nice to be able to say \override Staff.partCombineParameter = #x \partcombine \one \two ... and have the part combiner get its initial settings from the context. The current implementation runs the comb