Re: How to edit "Author" in a patch ready to push

2015-06-12 Thread David Kastrup
Benkő Pál writes: > 2015-06-12 22:20 GMT+02:00 Thomas Morley : >> Though, the current patch for 4428 shows: >> Author: harm >> >> Is there any way to change it to: >> Author: Thomas Morley >> ? > > my guess is > git commit --amend --reset-author --no-edit Instead of --reset-author, --author=Mo

Re: Define default fonts in fontconfig configuration file (issue 241340043 by truer...@gmail.com)

2015-06-12 Thread lemzwerg
LGTM, thanks! https://codereview.appspot.com/241340043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: How to edit "Author" in a patch ready to push

2015-06-12 Thread Thomas Morley
2015-06-12 22:33 GMT+02:00 Benkő Pál : > 2015-06-12 22:20 GMT+02:00 Thomas Morley : >> Though, the current patch for 4428 shows: >> Author: harm >> >> Is there any way to change it to: >> Author: Thomas Morley >> ? > > my guess is > git commit --amend --reset-author --no-edit > > p Thanks a lot,

Re: How to edit "Author" in a patch ready to push

2015-06-12 Thread Benkő Pál
2015-06-12 22:20 GMT+02:00 Thomas Morley : > Though, the current patch for 4428 shows: > Author: harm > > Is there any way to change it to: > Author: Thomas Morley > ? my guess is git commit --amend --reset-author --no-edit p ___ lilypond-devel maili

How to edit "Author" in a patch ready to push

2015-06-12 Thread Thomas Morley
Hi, I've newly set up LilyDev3 and used it for the first time creating a patch for https://code.google.com/p/lilypond/issues/detail?id=4428 I had some heavy problems, because I wasn't aware that most steps described here: http://lilypond.org/doc/v2.19/Documentation/contributor/commit-access needed

Re: Doc: Update ../ly/Bagpipe.ly (issue 241270043 by pkx1...@gmail.com)

2015-06-12 Thread dak
On 2015/06/12 13:16:07, dak wrote: mailto:pkx1...@gmail.com writes: > Reviewers: dak, > > Message: > Oliver, I wonder if you could take a look at the comments by one of our > developers about the recent patch you supplied to us for Bagpipe.ly and > answer his questions. I've prepared a

Re: Doc: Update ../ly/Bagpipe.ly (issue 241270043 by pkx1...@gmail.com)

2015-06-12 Thread David Kastrup
pkx1...@gmail.com writes: > Reviewers: dak, > > Message: > Oliver, I wonder if you could take a look at the comments by one of our > developers about the recent patch you supplied to us for Bagpipe.ly and > answer his questions. I've prepared a patch based on the difference to version 2.19.0. Th

Re: Aw: Re: Doc: Update ../ly/Bagpipe.ly (issue 241270043 by pkx1...@gmail.com)

2015-06-12 Thread James Lowe
Hello Oliver, On 12/06/15 13:25, Oliver Briede wrote: > Hi James, dak > we have not at all rewinded the version. When we started our work on the > bagpipe.ly, the latest version in your github was 2.19.0. In contrary to all > others working on the file (obviously) we extensively commented all ou

Re: Remove a _lot_ of parser/(*parser*) function arguments (issue 243250043 by d...@gnu.org)

2015-06-12 Thread dak
On 2015/06/12 12:29:46, dak wrote: (define (print-book-with book process-procedure) Uh, bad clipboard content. This was supposed to be: Stop maintaining "parser" variable, update CG example code https://codereview.appspot.com/243250043/ ___ lilypo

Aw: Re: Doc: Update ../ly/Bagpipe.ly (issue 241270043 by pkx1...@gmail.com)

2015-06-12 Thread Oliver Briede
Hi James, dak we have not at all rewinded the version. When we started our work on the bagpipe.ly, the latest version in your github was 2.19.0. In contrary to all others working on the file (obviously) we extensively commented all our changes. I propose you just merge these changes

Re: Doc: Update ../ly/Bagpipe.ly (issue 241270043 by pkx1...@gmail.com)

2015-06-12 Thread nine . fierce . ballads
https://codereview.appspot.com/241270043/diff/1/ly/bagpipe.ly File ly/bagpipe.ly (right): https://codereview.appspot.com/241270043/diff/1/ly/bagpipe.ly#newcode150 ly/bagpipe.ly:150: % @JO: We would skip the previous comment line. It is irritating, because some triple strikes But this is not the

Re: Define default fonts in fontconfig configuration file (issue 241340043 by truer...@gmail.com)

2015-06-12 Thread trueroad
Would you change this issue 4441's labels? I don't have permission to edit issue. git-cl shows like following. ``` Username (google account name): trueroad Password: This has been identified with code.google.com issue 4441. Is this correct? [y/n (y)] WARNING: could not change issue labels; pleas

Re: Define default fonts in fontconfig configuration file (issue 241340043 by truer...@gmail.com)

2015-06-12 Thread trueroad
I've improved and uploaded the patch. Issue 4441 / 5: Reject bitmap fonts in lilypond-fonts.conf LilyPond can not use bitmap fonts. So this commit adds ``reject bitmap fonts'' from fontconfig's ``70-no-bitmaps.conf'' to lilypond-fonts.conf. Issue 4441 / 4: Define default fonts i