On 2015/05/03 06:28:43, dak wrote:
https://codereview.appspot.com/235010043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/235010043/diff/1/ly/music-functions-init.ly#newcode36
ly/music-functions-init.ly:36: ((integer?) ly:music?)
Wh
https://codereview.appspot.com/235010043/diff/1/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/235010043/diff/1/ly/music-functions-init.ly#newcode36
ly/music-functions-init.ly:36: ((integer?) ly:music?)
Why use a number here instead of a pitch?
Looks fine.
https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely#newcode937
Documentation/notation/simultaneous.
> On May 2, 2015, at 5:46 PM, Carl Sorensen wrote:
>
> I think you should submit this code as a patch to scm/stencil.scm. Also,
> the regtests should be fixed to show the new behavior.
>
> Using a scale of -1 is the appropriate thing to do when you want to have
> the *origin* stay in the same l
Hi David,
thanks for this update!
2015-04-27 11:09 GMT+02:00 David Kastrup :
> At any rate, I am starting over _again_ but I think that I am now at the
> stage where my plan of execution is nicely streamlined and "Listeners"
> from both C++ and Scheme level (as well as their creation from the
> b
Hello,
I'll be in San Francisco area for the next three weeks - anyone would
like to meet? It would be great :)
best,
Janek
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
2015-05-02 23:46 GMT+02:00 Carl Sorensen :
> I think you should submit this code as a patch to scm/stencil.scm. Also,
> the regtests should be fixed to show the new behavior.
>
> Using a scale of -1 is the appropriate thing to do when you want to have
> the *origin* stay in the same location. Usi
On 5/2/15 2:45 PM, "Paul Morris" wrote:
>Hello dev list,
>
>Recently while working on Jianpu notation (see user list) I needed a
>function to flip a stencil. LilyPond doesn¹t have one, so I thought it
>would be worth adding the one I wrote (see below).
>
>Any thoughts on this before I submit t
Hello dev list,
Recently while working on Jianpu notation (see user list) I needed a function
to flip a stencil. LilyPond doesn’t have one, so I thought it would be worth
adding the one I wrote (see below).
Any thoughts on this before I submit the code for review?
(The other option would b
Hi all!
Texinfo evolves, and so does texi2any.
What I've tried so far is:
1- build and install a new 5.9.90 texinfo
2- uninstall texi2html
3- ln -s /usr/bin/texi2any ~/ME/bin/texi2html
4- replace any occurrence of "@documentlanguage utf-8" by
"@documentlanguage UTF-8" and add it where needed
https://codereview.appspot.com/228700043/diff/40001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/228700043/diff/40001/ly/music-functions-init.ly#newcode1135
ly/music-functions-init.ly:1135: \context Voice = "one" \with {
#one-context-settings
https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely
File Documentation/notation/simultaneous.itely (right):
https://codereview.appspot.com/233110043/diff/1/Documentation/notation/simultaneous.itely#newcode931
Documentation/notation/simultaneous.itely:931: @n
Hi James
I'm happy with this now. Thanks for being so forbearing and persistent
in the face of all the criticism. So, LGTM!
Trevor
https://codereview.appspot.com/120480043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.o
On 2015/05/02 16:11:20, Dan Eble wrote:
ly_unsmob (s) which compiles iff T is the base smob type
That sounds a little unclear. I mean that T owns the smob tag; it is
not derived.
https://codereview.appspot.com/236850043/
___
lilypond-devel mail
On 2015/05/02 14:28:11, dak wrote:
On 2015/05/02 12:54:18, Dan Eble wrote:
> There might be some cases where ly_is_smob() is called where
only
> ly_is_smob() is required (though this seems unlikely). The
right way
to
> improve performance in those cases is to ask the right question
instead.
Dan Eble writes:
> I’m using LilyDev 3. I just ran configure, and now I get this error
> very shortly after I try to compile:
>
>> gcc: error: @PYTHON_CFLAGS@: No such file or directory
>> make[1]: *** [out/midi.lo] Error 1
./autogen.sh
--
David Kastrup
__
On 2015/04/21 22:06:12, Trevor Daniels wrote:
On 2015/04/20 16:31:52, J_lowe wrote:
>
>
https://codereview.appspot.com/120480043/diff/240001/Documentation/notation/input.itely#newcode2732
> Documentation/notation/input.itely:2732: accent, marcato and
portato.
> On 2014/12/28 23:40:29, Trevor
I’m using LilyDev 3. I just ran configure, and now I get this error very
shortly after I try to compile:
> gcc: error: @PYTHON_CFLAGS@: No such file or directory
> make[1]: *** [out/midi.lo] Error 1
It fails in this way on this commit but not the previous:
> commit 2eb22fd223cd56a2dd90eda1499d
On 2015/05/02 12:54:18, Dan Eble wrote:
On 2015/05/02 08:25:09, dak wrote:
> Nope. dynamic_cast is non-trivial operation that cannot be
optimized away at
> compile time for almost any use. Calling it for every instance of
the rather
> ubiquitous is_smob query (ubiquitous enough that I ma
Reviewers: Keith, Trevor Daniels,
Message:
Please review
Description:
Adds a section documenting the use of the optional argument to the
partcombiner
Please review this at https://codereview.appspot.com/233110043/
Affected files (+29, -0 lines):
M Documentation/notation/simultaneous.itely
- Original Message -
From:
To:
Cc: ;
Sent: Saturday, May 02, 2015 1:54 PM
Subject: Re: Issue 4365: Add ly_is_smob(S) to check if S is a smob of
typeT. (issue 236850043 by nine.fierce.ball...@gmail.com)
On 2015/05/02 08:25:09, dak wrote:
Nope. dynamic_cast is non-trivial operati
On 2015/05/02 08:25:09, dak wrote:
Nope. dynamic_cast is non-trivial operation that cannot be optimized
away at
compile time for almost any use. Calling it for every instance of the
rather
ubiquitous is_smob query (ubiquitous enough that I made it an
operation separate
from unsmob and ch
https://codereview.appspot.com/236850043/diff/1/lily/include/smobs.hh
File lily/include/smobs.hh (right):
https://codereview.appspot.com/236850043/diff/1/lily/include/smobs.hh#newcode235
lily/include/smobs.hh:235: template
Nope. dynamic_cast is non-trivial operation that cannot be optimized
aw
23 matches
Mail list logo
