LGTM.
https://codereview.appspot.com/226700043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Dan Eble faithful.be> writes:
>
> Would it be hard to make \change Voice work as below without relying on
> the extra “NoteSequence” context?
>
> \layout {
> \context {
> \name "Thread"
> \type "Engraver_group"
> }
> \context {
> \Voice
> \accepts "Thread"
> \defaultch
Reviewers: ,
Description:
Part combiner: generate mark events in scheme rather than C++
Please review this at https://codereview.appspot.com/228700043/
Affected files (+93, -66 lines):
M lily/part-combine-iterator.cc
M ly/engraver-init.ly
M ly/music-functions-init.ly
M scm/part-combiner
Otherwise, LGTM
https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely
File Documentation/learning/fundamental.itely (right):
https://codereview.appspot.com/227470043/diff/1/Documentation/learning/fundamental.itely#newcode3193
Documentation/learning/fundamental
author Masamichi Hosoda
Fri, 24 Apr 2015 15:47:05 + (16:47 +0100)
committer James Lowe
Fri, 24 Apr 2015 15:50:24 + (16:50 +0100)
commit f758afb1497e9d95e564844363f23efa5a313321
https://codereview.appspot.com/227200043/
> Patch counted down - please push
>
> https://codereview.appspot.com/227200043/
I don't have git account.
I've attached the patch file to this mail.
Would you push it?
>From e50938881680c6f673d6c66f1f9619d9b3abfc65 Mon Sep 17 00:00:00 2001
From: Masamichi Hosoda
Date: Wed, 15 Apr 2015 21:51:46
