LGTM.
The main difference is the change in handling pure functions.
I can't see any difference here relative to Joe's patch, but it looks
fine.
https://codereview.appspot.com/230860044/diff/20001/scm/define-grob-properties.scm
File scm/define-grob-properties.scm (right):
https://codereview.
On 2015/04/19 18:29:18, Keith wrote:
https://codereview.appspot.com/226430043/diff/40001/lily/part-combine-iterator.cc#oldcode396
lily/part-combine-iterator.cc:396: SCM lst = get_music
()->get_property
("elements");
Later, it would be good to have PartCombineMusic contain a
ContextSpecdMusic
On 2015/04/19 18:29:18, Keith wrote:
Given that \displayLilyMusic does not reverse-engineer \voiceXxx, it
seems it
would take some work to teach it to reverse-engineer
\partcombineUp/Down
In patch set 3, I managed to fake it by continuing to rely on the
'direction property just for \displayLi
Looks good to me.
https://codereview.appspot.com/226430043/diff/20001/input/regression/display-lily-tests.ly
File input/regression/display-lily-tests.ly (right):
https://codereview.appspot.com/226430043/diff/20001/input/regression/display-lily-tests.ly#newcode224
input/regression/display-lily-t
On 2015/04/19 11:55:40, dak wrote:
On 2015/04/19 11:40:31, Dan Eble wrote:
> Call \displayLilyMusic output "NOT A BUG"
Why would that be not a bug?
That was my interpretation of Valentin's feedback in
https://code.google.com/p/lilypond/issues/detail?id=4348#c5 . If you
want something else,
> Comment #7 on issue 4345 by kristofbastiaensen: Patch: Part combiner: allow
> a2 chords
> https://code.google.com/p/lilypond/issues/detail?id=4345
>
> I've put up my code on github: https://github.com/kuribas/part-combiner
>
> I honestly don't understand why they kept the broken part combiner…
On 2015/04/19 11:40:31, Dan Eble wrote:
Call \displayLilyMusic output "NOT A BUG"
Why would that be not a bug?
https://codereview.appspot.com/226430043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/li
