Re: Some more possible tweaks to the appearance of the website

2015-02-19 Thread Paul Morris
Hi Trevor, > On Feb 18, 2015, at 4:35 AM, Trevor Daniels wrote: > >> HOME PAGE >> >> - Simplified by removing two graphical elements — the “squiggle” and the >> “What is LilyPond?” green bar that fades out horizontally — both of which >> are unlike any other visual elements on the site and so

Re: Function to display the rhythmic location of a grob (issue 197690044 by david.nales...@gmail.com)

2015-02-19 Thread david . nalesnik
On 2015/02/18 20:43:51, david.nalesnik wrote: it seems that a drawback of using Scheme is losing the nice error messages that result from doing LY_ASSERT_SMOB. False alarm. https://codereview.appspot.com/197690044/ ___ lilypond-devel mailing li

Web: revise site background (issue 204040043 by paulwmor...@gmail.com)

2015-02-19 Thread paulwmorris
Reviewers: , Message: Please review, thanks! Description: Web: revise site background green fade-out gradient at both top corners site background is off-white column backgrounds are pure-white images for homepage to match background adjust search box color Please review this at https://coderev

Web: rounded corners and related CSS tweaks (issue 206790043 by paulwmor...@gmail.com)

2015-02-19 Thread paulwmorris
Reviewers: , Message: Please review, thanks! Description: Web: rounded corners and related CSS tweaks rounded corners on columns and other boxes adjust spacing in column headers news-item border on top not bottom some minor color adjustments Please review this at https://codereview.appspot.com

Web: be more consistent with use of columns (issue 202080045 by paulwmor...@gmail.com)

2015-02-19 Thread paulwmorris
Reviewers: , Message: Please review, thanks! Description: Web: be more consistent with use of columns use a column on this page: introduction/text-input use columns instead of news-items on this page: introduction/examples only have one h3 heading per column on these pages introduction/ea

Re: Doc: issue 1432 (issue 206770044 by barr...@gmail.com)

2015-02-19 Thread Kevin Barry
On Thu, Feb 19, 2015 at 4:46 PM, wrote: > This is not just replacing tabs with spaces. You also reformat here and > remove empty lines at the end of the file. So the issue description is > somewhat misleading. Any other changes? > Yes, sorry. I wasn't really sure how detailed to be. Where I f

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

2015-02-19 Thread david . nalesnik
And in a few moments a version where I didn't strip the docstring... https://codereview.appspot.com/203090043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Make Grob::name accessible to Scheme (issue 203090043 by david.nales...@gmail.com)

2015-02-19 Thread david . nalesnik
On 2015/02/18 20:46:03, david.nalesnik wrote: On 2015/02/18 19:32:57, david.nalesnik wrote: > Hmmm. Since this is no longer just a wrapper for Grob::name, I suppose I should > rewrite it in Scheme. Not so sure now. Error reporting options in Scheme aren't as good. I take that back. If I

Re: Doc: issue 1432 (issue 206770044 by barr...@gmail.com)

2015-02-19 Thread fedelogy
I would remove trailing spaces also https://codereview.appspot.com/206770044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: issue 1432 (issue 206770044 by barr...@gmail.com)

2015-02-19 Thread dak
https://codereview.appspot.com/206770044/diff/1/ly/drumpitch-init.ly File ly/drumpitch-init.ly (right): https://codereview.appspot.com/206770044/diff/1/ly/drumpitch-init.ly#newcode154 ly/drumpitch-init.ly:154: midiDrumPitches = This is not just replacing tabs with spaces. You also reformat here

Doc: issue 1432 (issue 206770044 by barr...@gmail.com)

2015-02-19 Thread barrykp
Reviewers: , Message: Replaced tabs with (8) spaces in all of the .ly files in /ly. Please review! I have never submitted a patch before. Description: Doc: issue 1432 Replaced tabs with spaces in .ly files in /ly Please review this at https://codereview.appspot.com/206770044/ Affected file

Re: Web: fix column headings that lack gradients (issue 203050043 by paulwmor...@gmail.com)

2015-02-19 Thread pkx166h
author Paul Morris Wed, 11 Feb 2015 17:08:34 + (12:08 -0500) committer James Lowe Thu, 19 Feb 2015 15:30:44 + (15:30 +) commit d41686f992941f8fa8c567b6c1643d5dd4de17fc https://codereview.appspot.com/203050043/ _

PATCHES: Countdown for February 22nd 2015

2015-02-19 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on February 22nd. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=pa

Re: Web: fix column headings that lack gradients (issue 203050043 by paulwmor...@gmail.com)

2015-02-19 Thread pkx166h
Patch counted down - please push (you can give me a git formatted patch as normal of you like) https://codereview.appspot.com/203050043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel