doc fix for lily/stem-engraver.cc (issue 198820043 by david.nales...@gmail.com)

2015-01-18 Thread david . nalesnik
Reviewers: , Message: Please review. Description: doc fix for lily/stem-engraver.cc This engraver also creates Flag and StemStub grobs. Please review this at https://codereview.appspot.com/198820043/ Affected files (+3, -1 lines): M lily/stem-engraver.cc Index: lily/stem-engraver.cc diff

Re: Ossias and key signatures

2015-01-18 Thread Kevin Barry
> > Can someone point to a well engraved example (Bärenreiter, UE, etc.) > of a similar ossia staff that shows clef and key signature? My gut > feeling is that both clef and key signature should be *before* the > barline, not after. Not off the top of my head, but Gould says `When the /ossia/ st

Re: Ossias and key signatures

2015-01-18 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: "Thomas Morley" Cc: "Phil Holmes" ; "lilypond-devel" Sent: Sunday, January 18, 2015 12:17 PM Subject: Re: Ossias and key signatures Thomas Morley writes: I'd agree. We have no really convincing functionality to add ossias and tweak

Re: Ossias and key signatures

2015-01-18 Thread Phil Holmes
- Original Message - From: "Thomas Morley" Phil, I think the output of your code can be fixed by adding some more commands: It does, thanks. Think I'll add the original issue plus some of this to the tracker. -- Phil Holmes ___ lil

Re: Ossias and key signatures

2015-01-18 Thread Werner LEMBERG
> [...] I do need the clef and key signatures in the ossia. Can someone point to a well engraved example (Bärenreiter, UE, etc.) of a similar ossia staff that shows clef and key signature? My gut feeling is that both clef and key signature should be *before* the barline, not after. Werner

Re: Ossias and key signatures

2015-01-18 Thread David Kastrup
Thomas Morley writes: > I'd agree. We have no really convincing functionality to add ossias > and tweaking them. It's far to often maual work. > Btw, I tested the originak code with 2.12.2, 2.14.2, 2.16.2, 2.18.0, 2.19.15. > All versions return similiar output. > > Phil, I think the output of you

Re: Ossias and key signatures

2015-01-18 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: "Phil Holmes" > Cc: > Sent: Sunday, January 18, 2015 11:47 AM > Subject: Re: Ossias and key signatures > > >> "Phil Holmes" writes: >> >>> Image added. >> >> Uh, looks like a bug. Namely behavior I cannot ima

Re: Ossias and key signatures

2015-01-18 Thread Thomas Morley
2015-01-18 12:30 GMT+01:00 David Kastrup : > Phil Holmes writes: > >>> I'm not top posting. >> >> Sending this via the Gmane interface, since my direct emails to the >> mailing list never seem to get through. >> >> I'm doing some music with a lot of Ossia staves as vocal cues, and have >> discover

Re: Ossias and key signatures

2015-01-18 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: "Phil Holmes" Cc: Sent: Sunday, January 18, 2015 11:47 AM Subject: Re: Ossias and key signatures "Phil Holmes" writes: Image added. Uh, looks like a bug. Namely behavior I cannot imagine to be useful for any purpose. I seem to re

Re: Ossias and key signatures

2015-01-18 Thread tisimst
I get the same thing in 2.18.2. -Abraham Sent from my iPhone > On Jan 18, 2015, at 4:48 AM, David Kastrup [via Lilypond] > wrote: > > "Phil Holmes" <[hidden email]> writes: > > > Image added. > > Uh, looks like a bug. Namely behavior I cannot imagine to be useful for > any purpose. I

Re: Ossias and key signatures

2015-01-18 Thread Phil Holmes
- Original Message - From: "tisimst" To: Sent: Sunday, January 18, 2015 11:32 AM Subject: Re: Ossias and key signatures Phil, You probably tested this, but when I add "\remove Key_engraver" and "\remove Clef_engraver" to the ossia staves (as is done sometimes), the extra spacing goe

Re: Ossias and key signatures

2015-01-18 Thread David Kastrup
"Phil Holmes" writes: > Image added. Uh, looks like a bug. Namely behavior I cannot imagine to be useful for any purpose. I seem to remember having fixed something in relation to ossia staves recently, but it was probably unrelated? What's the behavior for some earlier versions like 2.18? Th

Re: Ossias and key signatures

2015-01-18 Thread tisimst
Phil, You probably tested this, but when I add "\remove Key_engraver" and "\remove Clef_engraver" to the ossia staves (as is done sometimes), the extra spacing goes away, but the flats are re-printed by the noteheads (which isn't too surprising, but also not so desirable). Also, you'll want to

Re: Ossias and key signatures

2015-01-18 Thread Phil Holmes
Image added. -- Phil Holmes Sending this via the Gmane interface, since my direct emails to the mailing list never seem to get through. I'm doing some music with a lot of Ossia staves as vocal cues, and have discovered 2 spacing issues that would appear to be caused by the permanent staves re

Re: Ossias and key signatures

2015-01-18 Thread David Kastrup
Phil Holmes writes: >> I'm not top posting. > > Sending this via the Gmane interface, since my direct emails to the > mailing list never seem to get through. > > I'm doing some music with a lot of Ossia staves as vocal cues, and have > discovered 2 spacing issues that would appear to be caused

Ossias and key signatures

2015-01-18 Thread Phil Holmes
> I'm not top posting. Sending this via the Gmane interface, since my direct emails to the mailing list never seem to get through. I'm doing some music with a lot of Ossia staves as vocal cues, and have discovered 2 spacing issues that would appear to be caused by the permanent staves reservin