Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by nine.fierce.ball...@gmail.com)

2015-01-01 Thread benko . pal
On 2015/01/01 23:08:56, Dan Eble wrote: On 2015/01/01 22:57:31, benko.pal wrote: > https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc > File lily/breathing-sign.cc (right): > > https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc#newcode122 > lily/breath

PATCHES: Countdown for January 4th. 2014

2015-01-01 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on January 4th. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch

Re: Doc; CG - add more specific note for Guile (issue 193870043 by pkx1...@gmail.com)

2015-01-01 Thread pkx166h
Reviewers: Trevor Daniels, Message: On 2015/01/02 00:09:19, Trevor Daniels wrote: https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi File Documentation/included/compile.itexi (right): https://codereview.appspot.com/193870043/diff/1/Documentation/included/com

Doc; CG - add more specific note for Guile (issue 193870043 by pkx1...@gmail.com)

2015-01-01 Thread tdanielsmusic
https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi File Documentation/included/compile.itexi (right): https://codereview.appspot.com/193870043/diff/1/Documentation/included/compile.itexi#newcode78 Documentation/included/compile.itexi:78: (1.8.8 - version 2.x is

Re: Ready lilypond-mode for packaging for emacs 24 package system, such that lilypond-mode will work wi… (issue 191260043 by pe...@thoughtspot.net)

2015-01-01 Thread pkx166h
Just for the record this is logged as https://code.google.com/p/lilypond/issues/detail?id=4230 James https://codereview.appspot.com/191260043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-deve

Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by nine.fierce.ball...@gmail.com)

2015-01-01 Thread nine . fierce . ballads
On 2015/01/01 22:57:31, benko.pal wrote: https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc File lily/breathing-sign.cc (right): https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc#newcode122 lily/breathing-sign.cc:122: if (ydim[DOWN] < val && line_pos.b

Re: Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by nine.fierce.ball...@gmail.com)

2015-01-01 Thread benko . pal
https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc File lily/breathing-sign.cc (right): https://codereview.appspot.com/189420043/diff/1/lily/breathing-sign.cc#newcode122 lily/breathing-sign.cc:122: if (ydim[DOWN] < val && line_pos.begin () < it - 1) I'd rather write line_pos.

Issue 4212: fix out-of-bounds index in division_maior() (issue 189420043 by nine.fierce.ball...@gmail.com)

2015-01-01 Thread nine . fierce . ballads
Reviewers: , Description: Issue 4212: fix out-of-bounds index in division_maior() Please review this at https://codereview.appspot.com/189420043/ Affected files (+1, -1 lines): M lily/breathing-sign.cc Index: lily/breathing-sign.cc diff --git a/lily/breathing-sign.cc b/lily/breathing-sign.c

Issue 4186: Remove the single-C time signature style (issue 186630043 by nine.fierce.ball...@gmail.com)

2015-01-01 Thread nine . fierce . ballads
Reviewers: , Description: Issue 4186: Remove the single-C time signature style Remove the single-C time signature style that was added in commit 40b0982cb4f00317c3d50c7f1d4e26fde912f3cd to address Issue 3286. The later commit 145389636e81237d560aba4d04abcb89fa60cd9c allows the user to define ne