Re: Make \time work with \tweak and \footnote (issue 149170044 by d...@gnu.org)

2014-09-30 Thread dak
On 2014/09/30 23:04:00, Dan Eble wrote: On 2014/09/30 09:07:26, dak wrote: > On 2014/09/30 04:54:22, dak wrote: > > On 2014/09/30 03:50:30, Dan Eble wrote: > > > \compoundMeter should create a TimeSignatureEvent too. > > > > [Slaps forehead] Take a deep breath. There are also \overrideTimeSign

Re: Make \time work with \tweak and \footnote (issue 149170044 by d...@gnu.org)

2014-09-30 Thread nine . fierce . ballads
On 2014/09/30 09:07:26, dak wrote: On 2014/09/30 04:54:22, dak wrote: > On 2014/09/30 03:50:30, Dan Eble wrote: > > \compoundMeter should create a TimeSignatureEvent too. > > [Slaps forehead] Take a deep breath. There are also \overrideTimeSignatureSettings and \revertTimeSignatureSettings, and

Re: Add an alternative Drum Style - agostini-drums-style (issue 150860044 by pkx1...@gmail.com)

2014-09-30 Thread pkx166h
New patch uploaded. https://codereview.appspot.com/150860044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-09-30 Thread dak
Other than that LGTM. Sorry for holding this up for so long. https://codereview.appspot.com/108270043/diff/60001/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/108270043/diff/60001/Documentation/notation/ancient.itely#newc

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

2014-09-30 Thread PhilEHolmes
I hope this is close to what is required... https://codereview.appspot.com/108270043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 4142: Make skipTypesetting skip time signatures (issue 148360043 by nine.fierce.ball...@gmail.com)

2014-09-30 Thread dak
https://codereview.appspot.com/148360043/diff/1/lily/time-signature-engraver.cc File lily/time-signature-engraver.cc (right): https://codereview.appspot.com/148360043/diff/1/lily/time-signature-engraver.cc#newcode63 lily/time-signature-engraver.cc:63: reallocated in the same spot */ The comment

Issue 4142: Make skipTypesetting skip time signatures (issue 148360043 by nine.fierce.ball...@gmail.com)

2014-09-30 Thread nine . fierce . ballads
Reviewers: , Message: The problem was discovered while debugging https://codereview.appspot.com/143450043/ . Description: Setting Score.skipTypesetting used to defer creating a time signature rather than skip it entirely. With this change, the temporal placement of time signatures is not affect

Re: Make \time work with \tweak and \footnote (issue 149170044 by d...@gnu.org)

2014-09-30 Thread dak
On 2014/09/30 04:54:22, dak wrote: On 2014/09/30 03:50:30, Dan Eble wrote: > \compoundMeter should create a TimeSignatureEvent too. [Slaps forehead] > I managed to do it by > incorporating \time into the definition of \compoundMeter, but perhaps you have > a better idea. I'll take a lo