Re: Missing make target in origin/master?

2014-09-03 Thread David Kastrup
Villum Sejersen writes: > root@Villums14:/usr/local/src/lilypond/build# git status > On branch master > Your branch is up-to-date with 'origin/master'. > nothing to commit, working directory clean > > But since sept. 2.: > > root@Villums14:/usr/local/src/lilypond/build# make --silent > make[1]: *

Missing make target in origin/master?

2014-09-03 Thread Villum Sejersen
root@Villums14:/usr/local/src/lilypond/build# git status On branch master Your branch is up-to-date with 'origin/master'. nothing to commit, working directory clean But since sept. 2.: root@Villums14:/usr/local/src/lilypond/build# make --silent make[1]: *** No rule to make target '/usr/local/sr

Re: Provide some more smob functionality and use it (issue 135240043 by d...@gnu.org)

2014-09-03 Thread janek . lilypond
Hi David, I'm sorry that i didn't manage to review this, but from a quick look it seems like a very welcome change. I'm really getting an impression that Scheme-C++ interfacing in LilyPond becomes easier to understand thanks to your work. best, Janek https://codereview.appspot.com/135240043/

Re: Replace internal_get_property with get_property where possible (issue 137760043 by janek.lilyp...@gmail.com)

2014-09-03 Thread janek . lilypond
Hi, On 2014/09/02 13:45:45, dak wrote: So I went through a review after all and found a few niggles that seem worth fixing. Probably does not require a full countdown and stuff, but another patchy run might be warranted in order to avoid typos. Thanks for reviewing, and for giving me gree

Re: Use aligned-on-x-parent instead of other callbacks for some grobs (issue 127860043 by janek.lilyp...@gmail.com)

2014-09-03 Thread janek . lilypond
Hi David, i apologize for the delay - i'm loosing grip on my lilypond stuff :( On 2014/08/30 09:45:02, dak wrote: On 2014/08/30 09:35:26, J_lowe wrote: > Oh sorry. I would have thought perhaps Patchy would have 'borked' at some point? Warnings don't stop the compilation and it would be a b

Lexer: don't go through int for fractions (issue 140170043 by d...@gnu.org)

2014-09-03 Thread lemzwerg
LGTM. https://codereview.appspot.com/140170043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 4078: Doc: Use variables rather than instrument definitions (issue 138950043 by tdanielsmu...@googlemail.com)

2014-09-03 Thread David Kastrup
David Kastrup writes: > "Keith OHara" writes: > >> On Sun, 31 Aug 2014 00:14:11 -0700, wrote: >> >>> On 2014/08/31 06:58:47, Keith wrote: >>> >>> https://codereview.appspot.com/138950043/diff/1/Documentation/notation/vocal.itely#newcode2646 \set instrumentCueName = "Flute" This is the