Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread Keith OHara
On Mon, 25 Aug 2014 00:28:14 -0700, wrote: Excuse my ignorance, is this going to need any extra documentation or perhaps a changes.tely entry? https://codereview.appspot.com/133840043/ I read through the documentation and saw no changes except mentioning the alternative names for bn, etc

Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread lilyfan
On 2014/08/25 10:13:52, Trevor Daniels wrote: I think you're mistaken. In the original file the unaltered English notenames were defined twice, and this patch alters just one of them, leaving the other unchanged. So it does just add a variant. Sorry, I did not expand enough! https://code

Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread tdanielsmusic
On 2014/08/25 09:17:54, Jean-Charles wrote: If I'm not mistaken, this patch *changes* every natural pitch in English instead of just adding or including a variant for "natural". Since this will modify what is in place since more than 15 years, it is essential to document it, both in "chang

Re: indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread lilyfan
If I'm not mistaken, this patch *changes* every natural pitch in English instead of just adding or including a variant for "natural". Since this will modify what is in place since more than 15 years, it is essential to document it, both in "changes" and over the documentation. Too bad, I prefer

indclude notnames bn, etc., in English (issue 133840043 by k-ohara5...@oco.net)

2014-08-25 Thread pkx166h
Excuse my ignorance, is this going to need any extra documentation or perhaps a changes.tely entry? https://codereview.appspot.com/133840043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel