Re: astyle 2.02

Janek Warchoł wrote: > If "badly formatted" <=> "different than what fixcc.py would produce", > i would say that LilyPond often gets badly formatted code - as you > wrote, running fixcc now results in 400 lines of changes. There's some formatting that's different from what fixcc.py would produce,

Re: astyle 2.02

2014-06-29 6:10 GMT+02:00 Graham Percival : > The question to ask is where do you want the burden of producing > properly formatted code? > > - a volunteer who runs fixcc.py manually once a year? > (this also produces "code reformatting" commits which disrupt > git blame) > - an automated proce

Re: Issue 2245: always align dynamics and lyrics on "main" notehead (issue 108270044 by janek.lilyp...@gmail.com)

Hi folks, please review. @Han-Wen: in Script_engraver, you wrote (commit 286fcad779) that aligning stuff like Scripts on NoteColumns is "not correct" (lines 256-261). However, to me it seems that using NoteColumns as X-parents for Lyrics, Dynamics etc. is exactly the way to solve issue 2245 (ht

Re: GUB failing

2014-06-30 1:11 GMT+02:00 Phil Holmes : > - Original Message - From: "Janek Warchoł" > >> How should i proceed with other patches that depend on this commit? > > Continue for now. It's likely to be a minor change, assuming we can work > out how to fix it. ok. Thanks for your help, and i

Re: GUB failing

- Original Message - From: "Janek Warchoł" To: "Phil Holmes" Cc: "David Kastrup" ; "LilyPond Development Team" Sent: Monday, June 30, 2014 12:03 AM Subject: Re: GUB failing 2014-06-30 0:48 GMT+02:00 Phil Holmes : - Original Message - From: "Janek Warchoł" I don't have any

Re: GUB failing

2014-06-30 0:48 GMT+02:00 Phil Holmes : > - Original Message - From: "Janek Warchoł" >> I don't have any better idea. Phil, could you try the attached patch >> and see if this helps? I don't have GUB set up, and i probably won't >> have the opportinuty to set it up for myself soon. > > Wi

Re: GUB failing

- Original Message - From: "Janek Warchoł" To: "David Kastrup" Cc: "Phil Holmes" ; "LilyPond Development Team" Sent: Sunday, June 29, 2014 10:06 PM Subject: Re: GUB failing 2014-06-29 22:09 GMT+02:00 David Kastrup : Phil Holmes writes: I'm sorry to say that one of Janek's upda

Re: GUB failing

2014-06-29 22:09 GMT+02:00 David Kastrup : > Phil Holmes writes: > >> I'm sorry to say that one of Janek's updates appears to have stopped GUB >> from compiling. It fails on compiling the mingw component as follows: I'm sorry to hear that :( >> /home/gub/gub/target/mingw/src/ >> lilypond-git.sv

Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com)

- Original Message - From: To: ; ; Cc: ; Sent: Sunday, June 29, 2014 6:55 PM Subject: Re: Adds incipit section to NR (issue 108270043 byphilehol...@googlemail.com) On 2014/06/29 16:51:06, email_philholmes.net wrote: You seem to have missed the point. Snippets are not judged by

Re: GUB failing

Phil Holmes writes: > I'm sorry to say that one of Janek's updates appears to have stopped GUB > from compiling. It fails on compiling the mingw component as follows: > > /home/gub/gub/target/mingw/src/ > lilypond-git.sv.gnu.org--lilypond.git-release-unstable/ > lily/include/paper-column.hh:62:

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/06/29 16:51:06, email_philholmes.net wrote: You seem to have missed the point. Snippets are not judged by the lilypond code, but by the ability of the writer to include them into the documentation. I did not need to do this as a snippet, so I didn't. Not so. Please read Section 5.

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/06/29 16:51:06, email_philholmes.net wrote: - Original Message - From: To: ; Cc: ; Sent: Sunday, June 29, 2014 5:26

GUB failing

I'm sorry to say that one of Janek's updates appears to have stopped GUB from compiling. It fails on compiling the mingw component as follows: /home/gub/gub/target/mingw/src/ lilypond-git.sv.gnu.org--lilypond.git-release-unstable/ lily/include/paper-column.hh:62: error: expected identifier before

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: ; Cc: ; Sent: Sunday, June 29, 2014 5:26 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) On 2014/06/29 15:15:51, email_philholmes.net wrote: From: To:

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

On 2014/06/29 15:15:51, email_philholmes.net wrote: From: To: Cc: ; Sent: Sunday, June 29, 2014 3:44 PM Subject: Re: Adds incipit section to NR (issue 108270043

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

- Original Message - From: To: Cc: ; Sent: Sunday, June 29, 2014 3:44 PM Subject: Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com) https://codereview.appspot.com/108270043/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancien

Re: Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

https://codereview.appspot.com/108270043/diff/1/Documentation/notation/ancient.itely File Documentation/notation/ancient.itely (right): https://codereview.appspot.com/108270043/diff/1/Documentation/notation/ancient.itely#newcode2663 Documentation/notation/ancient.itely:2663: incipit = That's not

Adds incipit section to NR (issue 108270043 by philehol...@googlemail.com)

Reviewers: , Message: Please review. Description: Adds incipit section to NR Please review this at https://codereview.appspot.com/108270043/ Affected files (+126, -4 lines): M Documentation/notation/ancient.itely ___ lilypond-devel mailing list

Re: Changes.tely updated - 2.19.x up to June 2014 (issue 108130043 by pkx1...@gmail.com)

https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tely File Documentation/changes.tely (right): https://codereview.appspot.com/108130043/diff/70001/Documentation/changes.tely#newcode141 Documentation/changes.tely:141: A new markup command @code{\justify-line} has been add

PATCHES: Countdown for July 1st

Hello, Here is the current patch countdown list. The next countdown will be on July 1st. You can always view the most current countdown list here: http://code.google.com/p/lilypond/issues/list?q=Patch%3Apush%2Ccountdown%2Creview%2Cnew%2Cwaiting&colspec=Patch%20Owner%20ID%20Summary&sort=patch __

Re: use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters (issue 108110045 by janek.lilyp...@gmail.com)

pushed as commit f4d8c77fc2ebac49bbdb0d0e9bec636313508846 Author: Janek Warchoł Date: Mon Apr 8 15:58:08 2013 +0200 use X-parents to align MMRNumbers, MMRTexts and PercentRepeatCounters It makes more sense to use X-parents than Y-parents for horizontal alignment. To be able to do