Re: Checks to see if tuplet brackets have bounds (issue 13582046)

2013-09-13 Thread k-ohara5a5a
The first two patches look good. Defensive checks for null pointers are a good thing. We do not want a bracket for the input in the bug-report. We want a message when our .ly input asks for a tuplet bracket that cannot be printed, and we get such a message (just before a crash, without this patch

Re: need help with a c++ procedure

2013-09-13 Thread Frédéric Bron
> I'm trying to make something like an `installed-font?' > scheme procedure, but it looks like I need a c++ procedure > first. Something like `ly_font_config_get_fonts', exactly > like the following except it would return the list of fonts > instead of displaying it. This is from > font-config-sc

Re: Adds a little curve to harmonic note heads (issue 13518047)

2013-09-13 Thread lemzwerg
LGTM. And thanks for your patience! https://codereview.appspot.com/13518047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Disallow metapost versions 1.504 < x < 1.803. (issue 13413046)

2013-09-13 Thread lemzwerg
LGTM https://codereview.appspot.com/13413046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Adds a little curve to harmonic note heads (issue 13518047)

2013-09-13 Thread PhilEHolmes
Reviewers: lemzwerg, Message: Please review Description: Adds a little curve to harmonic note heads Please review this at https://codereview.appspot.com/13518047/ Affected files (+22, -22 lines): M mf/parmesan-noteheads.mf Index: mf/parmesan-noteheads.mf diff --git a/mf/parmesan-noteheads.

Re: Checks to see if tuplet brackets have bounds (issue 13582046)

2013-09-13 Thread Mike Solomon
On 13 sept. 2013, at 11:00, d...@gnu.org wrote: > On 2013/09/13 08:41:42, Trevor Daniels wrote: >> On 2013/09/13 07:09:44, mike7 wrote: > >> > With respect to your point about null pointers and the nature of the > patch, I >> > agree that there needs to be a better way to handle this. To me, >

Re: Checks to see if tuplet brackets have bounds (issue 13582046)

2013-09-13 Thread dak
On 2013/09/13 08:41:42, Trevor Daniels wrote: On 2013/09/13 07:09:44, mike7 wrote: > With respect to your point about null pointers and the nature of the patch, I > agree that there needs to be a better way to handle this. To me, the general > problem seems to be "what do we do when we as

Re: Checks to see if tuplet brackets have bounds (issue 13582046)

2013-09-13 Thread tdanielsmusic
On 2013/09/13 07:09:44, mike7 wrote: With respect to your point about null pointers and the nature of the patch, I agree that there needs to be a better way to handle this. To me, the general problem seems to be "what do we do when we assume a grob will have something (bound, object, etc.

Re: Checks to see if tuplet brackets have bounds (issue 13582046)

2013-09-13 Thread Mike Solomon
On 13 sept. 2013, at 08:41, d...@gnu.org wrote: > > https://codereview.appspot.com/13582046/diff/1/lily/tuplet-bracket.cc > File lily/tuplet-bracket.cc (right): > > https://codereview.appspot.com/13582046/diff/1/lily/tuplet-bracket.cc#newcode99 > lily/tuplet-bracket.cc:99: if (!left || !right)

Re: ERROR: Please install required programs: International New Century Schoolbook fonts

2013-09-13 Thread Lilyfan
> Message du 13/09/13 00:55 > De : "Julien Rioux" > On 12/09/2013 6:09 PM, Federico Bruni wrote: > > 2013/8/3 Federico Bruni > > > > > I'm getting this error if I run ./autogen.sh in git master: > > > > ERROR: Please install required programs: International New Century > > Schoolbook fonts Interna