Re: Adds dimension stencil command to correct with-dimension (issue 12957047)

2013-08-21 Thread k-ohara5a5a
There is also \pad-markup and \pad-to-box Also, the delayed stencils in \with-link and \page-ref could use this method to reserve the size of the place-holder text Also, harp-pedals.scm could use this method instead of the invisible box (which is not quite invisible in PNG output and maybe other

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2013-08-21 Thread k-ohara5a5a
On 2012/12/22 16:11:10, mike7 wrote: On 22 déc. 2012, at 07:43, mailto:k-ohara5...@oco.net wrote: https://codereview.appspot.com/6827072/diff/34001/lily/axis-group-interface.cc#newcode62 > lily/axis-group-interface.cc:62: return SCM_BOOL_T; > Now the whole note-column is marked cross-staff if

function declaration in wrong file?

2013-08-21 Thread Frédéric Bron
The following functions are declared in flower/include/std-vector.hh but defined in flower/std-string.cc: vector string_split (string str, char c); string string_join (vector const &strs, const string &infix); This does not sound logical to me. What about moving the declaration to std-string.hh?

Re: more comments (issue 13051044)

2013-08-21 Thread frederic . bron . 1995
https://codereview.appspot.com/13051044/diff/1/lily/tie-configuration.cc File lily/tie-configuration.cc (right): https://codereview.appspot.com/13051044/diff/1/lily/tie-configuration.cc#newcode128 lily/tie-configuration.cc:128: * I have started to prepare a patch. There are many locations concer

Re: patch to remove unused header tie-column-format.hh

2013-08-21 Thread Frédéric Bron
> git-cl will create the issue for you when you upload your patch. If it > doesn't, please report it as a bug. done, issue 3511. Cheers, Frédéric ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-deve

Re: changes: mention that decimal numbers can be written without # (issue 13007044)

2013-08-21 Thread graham
LGTM https://codereview.appspot.com/13007044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Let add-grace-property and remove-grace-property only work in current context (issue 13088043)

2013-08-21 Thread janek . lilypond
LGTM. https://codereview.appspot.com/13088043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

a script for building multiple independent lilyponds from source

2013-08-21 Thread Janek Warchoł
Hi all, every now and then many of us need to use different versions of LilyPond - this is especially true for developers. In fact, most developers usually want many concurrent LilyPond versions built from the source code. It was my dream for more than a year to automate the process of compiling

pedal spanners: do not cross staves; issue 3501 (issue 13082043)

2013-08-21 Thread janek . lilypond
LGTM. https://codereview.appspot.com/13082043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Only marks truly cross-staff arpeggios as cross-staff (issue 13063045)

2013-08-21 Thread janek . lilypond
LGTM https://codereview.appspot.com/13063045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES - Countdown for August 24th -06:00 GMT

2013-08-21 Thread James
Hello, *Countdown – August 24th – 06:00 GMT* * * * * * * * * 3494 Enhancement Julien Rioux Push Patch: mak

Re: patch to remove unused header tie-column-format.hh

2013-08-21 Thread Julien Rioux
On 21/08/2013 12:32 AM, Frédéric Bron wrote: Please read http://www.lilypond.org/doc/v2.17/Documentation/contributor-big-page.html#summary-for-experienced-developers and start using git-cl. Plain patches posted to -devel tend to get forgotten in mist of syntax changes and font standards debates.

Re: Issue 3489: Let \cue... use quoted-context-type of CueVoice consistently (issue 12971044)

2013-08-21 Thread lemzwerg
LGTM. https://codereview.appspot.com/12971044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel