Re: issue 3441: banjo example should use Staff + TabStaff (issue 10935046)

2013-07-10 Thread graham
LGTM https://codereview.appspot.com/10935046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Avoid infinite recursion in Emacs' LilyPond-mode for percent in filenames (issue 10970043)

2013-07-10 Thread graham
LGTM https://codereview.appspot.com/10970043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: T3154 work - question on init code, ly_book_scheme initialization passing Lexer instance as value for scheme (parser), why is this?

2013-07-10 Thread Ian Hulin
On 10/07/13 23:39, David Kastrup wrote: > Ian Hulin writes: > >> I don't understand why when I set a breakpoint at ly_book_scheme >> I get a parameter passed which should be the value of scheme >> (parser) coming through as a Lexer type. > > I don't understand that sentence at all. > Sorry for

Re: T3154 work - question on init code, ly_book_scheme initialization passing Lexer instance as value for scheme (parser), why is this?

2013-07-10 Thread David Kastrup
Ian Hulin writes: > I don't understand why when I set a breakpoint at ly_book_scheme I get a > parameter passed which should be the value of scheme (parser) coming > through as a Lexer type. I don't understand that sentence at all. > This is part of work for issue 3154. > > But here's a summary

Re: Fix some oversights of \layout in \book (issue 10794044)

2013-07-10 Thread ianhulin44
On 2013/07/10 21:46:00, PhilEHolmes wrote: LGTM and LGTM too. https://codereview.appspot.com/10794044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

T3154 work - question on init code, ly_book_scheme initialization passing Lexer instance as value for scheme (parser), why is this?

2013-07-10 Thread Ian Hulin
I don't understand why when I set a breakpoint at ly_book_scheme I get a parameter passed which should be the value of scheme (parser) coming through as a Lexer type. This is part of work for issue 3154. But here's a summary of what's I've been doing and some gdb ouptut. Once upon a time I though

Re: Fix some oversights of \layout in \book (issue 10794044)

2013-07-10 Thread PhilEHolmes
LGTM https://codereview.appspot.com/10794044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix some oversights of \layout in \book (issue 10794044)

2013-07-10 Thread thomasmorley65
Reviewers: , Message: Please review. Description: Fix some oversights of \layout in \book follow-up for issue 3151 Please review this at https://codereview.appspot.com/10794044/ Affected files: M Documentation/notation/input.itely Index: Documentation/notation/input.itely diff --git a/Doc

Re: whack-a-regression

2013-07-10 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: Sent: Wednesday, July 10, 2013 5:47 PM Subject: Re: whack-a-regression Keith OHara writes: Two lines of Lyrics do not use the code that does outside-staff placement, so it was not my change that caused the problem. It must be the ch

Re: whack-a-regression

2013-07-10 Thread David Kastrup
Keith OHara writes: > Two lines of Lyrics do not use the code that does outside-staff placement, > so it was not my change that caused the problem. It must be the changes > to the implementation of Skylines for issue 3344. Issue 3383 it was. Issue 3344 is a convert-ly rule and irrelevant. --

Re: whack-a-regression

2013-07-10 Thread David Kastrup
Keith OHara writes: > The problem appeared when placing text in relation to other things, so try > << \new Lyrics \lyricmode { a } >\new Lyrics \lyricmode { u } >> > LilyPond on Windows runs forever on that, depending on the text. > > Two lines of Lyrics do not use the code that does outside-

Re: whack-a-regression

2013-07-10 Thread Keith OHara
Janek Warchoł gmail.com> writes: > > Janek Warchoł gmail.com> writes: > > > >> i've decided that instead of complaining about slowed development > >> process, i can do some bug-fixing instead. > 2013/7/2 Keith OHara oco.net>: > > The problem seems to need text that uses skylines being placed o