Re: Restore dots that overflow chords; issue 3179 (issue 8266047)

LGTM, but one patch too much :-) https://codereview.appspot.com/8266047/diff/19001/ly/titling-init.ly File ly/titling-init.ly (left): https://codereview.appspot.com/8266047/diff/19001/ly/titling-init.ly#oldcode144 ly/titling-init.ly:144: Oops! Changes to this file probably don't belong to this

Re: X-aligning on Y-parent - ?? advice needed

hi, 2013/4/5 Janek Warchoł : > 2013/4/5 Neil Puttock : >> On 5 April 2013 17:47, Janek Warchoł wrote: >> >>> Regardless of it being a spanner, i've tried to find where >>> MultiMeasureRestText's (and MultiMeasureRestNumber's) Xparent is set, >>> but without sucsess. I thought that maybe it happe

Re: Add some more documentation for \defaultchild (issue 8474044)

LGTM Trevor https://codereview.appspot.com/8474044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: suggestion: change OctavateEight name to ClefTransposition - opinions?

2013/4/8 pls : > On 08.04.2013, at 10:58, pls wrote: > >> On 08.04.2013, at 09:56, David Kastrup wrote: >>> Actually, it's not just the clef where I am without a clue how to play >>> this, or on what instrument… >> Is this piece supposed to be played on a baritone guitar (tuned a perfect >> fif

PATCHES - Countdown for April 11th - 19:00 GMT

Hello *Countdown – April 11th 2013 – 19:00 GMT* * * * * * * * * 2794 Critical Keith O'hara Push Bookparts have lost t

Re: Gotcher with make test-baseline

Ian Hulin writes: > Hi All, > > I was getting very puzzled by a crash in running make test-baseline, so > I thought I'd share what cause the problem here with the other > developers to save others wasting time. > > I was working on a branch and wanted to change some files in scm/, so > had them o

Re: parser: more specific error messages; issue 3300 (issue 8506043)

On 2013/04/08 17:58:43, Keith wrote: On 2013/04/08 16:05:20, dak wrote: > > Here is the problem I have with this change: for > \new Lyrics { hello, Dolly } > the error message will become quite less helpful. Yep. Version 2.16 printed the same "unexpected STRING". I see no safe short-term w

Re: parser: more specific error messages; issue 3300 (issue 8506043)

Reviewers: dak, Message: On 2013/04/08 16:05:20, dak wrote: Here is the problem I have with this change: for \new Lyrics { hello, Dolly } the error message will become quite less helpful. Yep. Version 2.16 printed the same "unexpected STRING". I see no safe short-term way to give the parser

Removes arpeggios from note columns' element list. (issue 8514043)

lgtm. You should add a test that would reveal if the problem in issue 3289 ever comes back. The logical place is at the end of ‘arpeggio-collision.ly’ https://codereview.appspot.com/8514043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https

Re: Time signature before repeat bars at beginning of line; issue 828 (issue 8508043)

Reviewers: lemzwerg, Message: On 2013/04/08 06:35:48, lemzwerg wrote: LGTM. Do we have a regtest for this? Yes, because several tests already have repeat bars at the start of lines. They look noticeably odd before this patch, so I think they can serve to alert us if this patch ever fails in

parser: more specific error messages; issue 3300 (issue 8506043)

https://codereview.appspot.com/8506043/diff/1/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/8506043/diff/1/lily/parser.yy#newcode2323 lily/parser.yy:2323: | STRING This not fully equivalent, but I think that LYRIC_ELEMENT is not expected to occur here, so it is likel

Add some more documentation for \defaultchild (issue 8474044)

Minor changes to phrasing suggested. I don't think this needs an example; seems pretty clear to me. So LGTM. https://codereview.appspot.com/8474044/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com

Remove remaining uses of \times (3301) (issue 8509043)

https://codereview.appspot.com/8509043/diff/1/Documentation/learning/fundamental.itely File Documentation/learning/fundamental.itely (right): https://codereview.appspot.com/8509043/diff/1/Documentation/learning/fundamental.itely#newcode502 Documentation/learning/fundamental.itely:502: between or

Re: suggestion: change OctavateEight name to ClefTransposition - opinions?

On 08.04.2013, at 10:58, pls wrote: > On 08.04.2013, at 09:56, David Kastrup wrote: > >> Thomas Morley writes: >> >>> 2013/4/7 David Kastrup : >>> A digital camera does not produce even lighting, but for simple demonstrations it is better than nothing. >>> >>> I don't have a digit

Re: suggestion: change OctavateEight name to ClefTransposition - opinions?

On 08.04.2013, at 09:56, David Kastrup wrote: > Thomas Morley writes: > >> 2013/4/7 David Kastrup : >> >>> A digital camera does not produce even lighting, but for simple >>> demonstrations it is better than nothing. >> >> I don't have a digital camera, too. >> Though, my girl friends mobile

Re: Unequal spacing in odd-n tuplet with other simultaneous subdivisions

2013/4/8 James Harkins : > Known issue? I'm seeing a strange problem with unequal spacing in the > third staff's septuplet. > [] I don't remember if this is reported, but i personally have encountered this situation several times. I have some idea how it's happening, and the bad news is that

Re: suggestion: change OctavateEight name to ClefTransposition - opinions?

Thomas Morley writes: > 2013/4/7 David Kastrup : > >> A digital camera does not produce even lighting, but for simple >> demonstrations it is better than nothing. > > I don't have a digital camera, too. > Though, my girl friends mobile phone camera worked. Actually, it's not just the clef where

Gotcher with make test-baseline

Hi All, I was getting very puzzled by a crash in running make test-baseline, so I thought I'd share what cause the problem here with the other developers to save others wasting time. I was working on a branch and wanted to change some files in scm/, so had them open in emacs. I stashed my change