On 2013/03/30 19:38:09, dak wrote:
Address Thomas' comments
The description doesn't explain why
\relative c'' { 1 }
returns a programming error.
Though, this is definitely not a topic of \single, \omit or "Changes" in
general.
LGTM
https://codereview.appspot.com/8187044/
Reviewers: janek, thomasmorley65,
Message:
I'll address the other points presently, or on Tuesday, depending on my
connectivity.
https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/8187044/diff/1/Docum
Some nitpicks.
Otherwise LGTM
https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely
File Documentation/changes.tely (right):
https://codereview.appspot.com/8187044/diff/1/Documentation/changes.tely#newcode73
Documentation/changes.tely:73: Two ways of letting graphical object
On 2013/03/30 18:15:11, MikeSol wrote:
In general, I see a lot of reassigning of parents. What is the goal
with this
(sorry if you've explained this already)?
What do you mean by "reassigning of parents"? I fetch grobs' parents
often, but i don't give grobs new parents.
https://codereview
LGTM
https://codereview.appspot.com/8187044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
In general, I see a lot of reassigning of parents. What is the goal
with this (sorry if you've explained this already)?
https://codereview.appspot.com/7768043/diff/38001/lily/fingering-engraver.cc
File lily/fingering-engraver.cc (right):
https://codereview.appspot.com/7768043/diff/38001/lily/f
Hi folks,
after some work on self-alignment-interface i have reached the point
when a big picture starts to emerge. I'd really appreciate some
feedback, also from people who are not really into Lily internals (i'd
like to know whether user interfaces produced by me are clear).
Rietveld issue is
Hi,
we had a rain day today, so I had a lot of net time. This evening, the
one-week internet pass from the hotel runs out (probably somewhere about
20:00 UTC or later). With some luck, I'll be able to put through the
results of the last Patchy run (under way), but at any rate, I'll be
offline s
"m...@mikesolomon.org" writes:
> Hey all,
>
> I reverted the instrument name patch in staging.
It might be worth trying to figure out the relation between the problems
that this patch was addressing and the breakage of functionality that
occured as a consequence of it.
Maybe the patch goals can
Hey all,
I reverted the instrument name patch in staging.
Cheers,
MS
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Apparently not posted on the issue itself, so replying to the list.
"m...@mikesolomon.org" writes:
> On 30 mars 2013, at 08:27, lilyp...@googlecode.com wrote:
>> commit 6e4e69f2735a764eab2e6f70f83546461da0203b
>> Author: Mike Solomon
>> Date: Fri Mar 29 05:55:13 2013 +0100
>>
>>Uses sp
On 30 mars 2013, at 10:29, k-ohara5...@oco.net wrote:
> Simpler to just reverse the "special X-alignment" commit.
>
> The old code, that followed the comment about a 'kldge' whatever that
> means, was rather elegant. If we are placing something alongside an
> empty set, place it against the ref
On 30 mars 2013, at 08:33, k-ohara5...@oco.net wrote:
> Why not use the flat-line for empty VerticalAxisGroups specifically in
> side-position-interface.cc when placing something against the staff (in
> the clause if (include_staff) {} ) ?
include_staff is false for VerticalAxisGroups without sta
On 30 mars 2013, at 08:27, lilyp...@googlecode.com wrote:
> Updates:
> Labels: -Patch-push
>
> Comment #8 on issue 3256 by d...@gnu.org: Patch: Eliminates side poisition
> calculations for system-start-text grobs.
> http://code.google.com/p/lilypond/issues/detail?id=3256
>
> This patch ha
Simpler to just reverse the "special X-alignment" commit.
The old code, that followed the comment about a 'kldge' whatever that
means, was rather elegant. If we are placing something alongside an
empty set, place it against the reference point for that set. Having a
special case for StanzaNumbe
15 matches
Mail list logo
