Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

2013-02-14 Thread m...@mikesolomon.org
Thank you for the _excellent_ review. This is _exactly_ the type of stuff I need. > https://codereview.appspot.com/7185044/diff/32003/input/regression/tuplet-number-outside-staff-positioning.ly > File input/regression/tuplet-number-outside-staff-positioning.ly > (right): > > https://codereview.

Re: Issue 3174: Implement \accidental markup and \pitched command for transposable accidental markups (issue 7323060)

2013-02-14 Thread thomasmorley65
On 2013/02/14 09:21:07, dak wrote: So the message is "we can do", but we still need to figure out _what_ we can do. Proposals? Well, currently I don't have a good idea. Though, some time ago Arnold posted his approach on -user: http://lists.gnu.org/archive/html/lilypond-user/2012-06/msg00278

Re: Patch meister position still vacant!!!

2013-02-14 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: Sent: Thursday, February 14, 2013 8:43 PM Subject: Re: Patch meister position still vacant!!! "Phil Holmes" writes: - Original Message - From: "David Kastrup" To: Sent: Thursday, February 14, 2013 6:38 PM Subject: Re: Patch

Re: Patch meister position still vacant!!!

2013-02-14 Thread Janek WarchoĊ‚
On Thu, Feb 14, 2013 at 9:43 PM, David Kastrup wrote: > "Phil Holmes" writes: > >> From: "David Kastrup" >>> I have no beef with that, except when the only exemplar of "people like >>> you" seen in the wild happens to be you. >> >> I think there's quite a number of us. > > Why then lay several j

Re: Patch meister position still vacant!!!

2013-02-14 Thread David Kastrup
"Phil Holmes" writes: > - Original Message - > From: "David Kastrup" > To: > Sent: Thursday, February 14, 2013 6:38 PM > Subject: Re: Patch meister position still vacant!!! > > >> James writes: >> >>> In the end it is still better that developers develop and people like >>> me do the

Re: Patch meister position still vacant!!!

2013-02-14 Thread Phil Holmes
- Original Message - From: "David Kastrup" To: Sent: Thursday, February 14, 2013 6:38 PM Subject: Re: Patch meister position still vacant!!! James writes: In the end it is still better that developers develop and people like me do the boring but necessary admin stuff. I have no

Re: let beam thickness depend on line thickness (fix 3173) (issue 7312091)

2013-02-14 Thread dak
https://codereview.appspot.com/7312091/diff/1/scm/define-grob-properties.scm File scm/define-grob-properties.scm (right): https://codereview.appspot.com/7312091/diff/1/scm/define-grob-properties.scm#newcode93 scm/define-grob-properties.scm:93: (beam-thickness ,number-pair? "Beam thickness. It i

Re: Caches the interior skylines of vertical axis groups and systems. (issue 7185044)

2013-02-14 Thread dak
I've not really reviewed everything here, just highlights. Regarding the commenting problems: it is important for the reviewer or maintainer or rereader to get the gist of the story. Much of the LilyPond codebase has been written with a total disregard to people not present during the writing.

Re: Patch meister position still vacant!!!

2013-02-14 Thread David Kastrup
James writes: > In the end it is still better that developers develop and people like > me do the boring but necessary admin stuff. I have no beef with that, except when the only exemplar of "people like you" seen in the wild happens to be you. I've been in the "well, seems nobody is better qua

Re: Patch meister position still vacant!!!

2013-02-14 Thread James
hello, On 14 February 2013 11:33, David Kastrup wrote: > Graham Percival writes: > > > On Tue, Feb 12, 2013 at 09:26:45AM +0100, David Kastrup wrote: > >> James writes: > >> > >> > Anyway, assuming that no one else offers, I'll take a look and make > >> > a start of it on Wednesday. > >> > >>

Add Kievan ligature engraver (issue 7301097)

2013-02-14 Thread aleksandr . andreev
Reviewers: , Message: Please review. Description: Add Kievan ligature engraver Creates support for melismas ("ligatures") in Kievan notation via the use of a ligature engraver. Please review this at https://codereview.appspot.com/7301097/ Affected files: M lily/coherent-ligature-engraver.c

Re: Patch meister position still vacant!!!

2013-02-14 Thread David Kastrup
Graham Percival writes: > On Tue, Feb 12, 2013 at 09:26:45AM +0100, David Kastrup wrote: >> James writes: >> >> > Anyway, assuming that no one else offers, I'll take a look and make >> > a start of it on Wednesday. >> >> I certainly think you a good fit for that position. The problem is >> th

Re: Issue 3174: Implement \accidental markup and \pitched command for transposable accidental markups (issue 7323060)

2013-02-14 Thread Werner LEMBERG
> Here is the deal: I can rename the current \pitched to \withPitch > which is quite in line with \withMusicProperty. > \withPitch/\accidental is a basic mechanism for passing > transposition information from music to markups. > > The questions are > > a) is this mechanism sufficient for pitched

Re: Issue 3174: Implement \accidental markup and \pitched command for transposable accidental markups (issue 7323060)

2013-02-14 Thread dak
Reviewers: Trevor Daniels, thomasmorley65, Message: On 2013/02/13 23:27:55, thomasmorley65 wrote: On 2013/02/13 22:56:30, Trevor Daniels wrote: > I definitely prefer the alternative you suggest in para 3. > You would not then need the warning, which is only necessary due to the > complicated 2