Re: Issue 3061 (issue 7033045)

2013-01-01 Thread Zefram
d...@gnu.org wrote: >All this seems far too complex. Why not use ly:duration-length and just >divide the respective values of ly:moment-main? No need to fiddle with >counting dots and shift factors manually. That's a valid approach, but doesn't win quite as much as you'd think. In the most obvio

Re: make doc: cannot import name TexModule (but dblatex is now arequireddependency)

2013-01-01 Thread Federico Bruni
Il 30/12/2012 09:06, Federico Bruni ha scritto: I can't find any information about dblatex developers. I'll send a bug report to Debian bug tracking system. Ok, problem solved thanks to the Debian maintainer: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=696976 The problem was the python pa

Re: Fix for segfault in Font_metric::mark_smob (optimization; Debian bug #684817)

2013-01-01 Thread David Kastrup
Don Armstrong writes: > On Fri, 28 Dec 2012, David Kastrup wrote: >> Don Armstrong writes: >> > The attached patch fixes a segfault in mark_smob where s gets >> > optimized away and garbage collected before m goes out of scope, >> > leading to a segfault. >> > >> > There may be other cases of th

Re: Issue 3061 (issue 7033045)

2013-01-01 Thread dak
https://codereview.appspot.com/7033045/diff/1/ly/articulate.ly File ly/articulate.ly (right): https://codereview.appspot.com/7033045/diff/1/ly/articulate.ly#newcode455 ly/articulate.ly:455: ((tremtype (ly:music-property (car trem) 'tremolo-type)) All this seems far too complex. Why not use ly:d

Re: Fix for segfault in Font_metric::mark_smob (optimization; Debian bug #684817)

2013-01-01 Thread Don Armstrong
On Fri, 28 Dec 2012, David Kastrup wrote: > Don Armstrong writes: > > The attached patch fixes a segfault in mark_smob where s gets > > optimized away and garbage collected before m goes out of scope, > > leading to a segfault. > > > > There may be other cases of this bug floating around, but I di

Re: typo in time-signature-settings.scm (issue 7030052)

2013-01-01 Thread tdanielsmusic
LGTM https://codereview.appspot.com/7030052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

typo in time-signature-settings.scm (issue 7030052)

2013-01-01 Thread thomasmorley65
Reviewers: , Message: Quite trivial. Nevertheless, please review Description: typo in time-signature-settings.scm Fixing missing space in commented example issue 3074 Please review this at https://codereview.appspot.com/7030052/ Affected files: M scm/time-signature-settings.scm Index: sc

Issue 3061 (issue 7033045)

2013-01-01 Thread pkx166h
Reviewers: zefram_fysh.org, Description: Issue 3061 articulate TremoloEvent Expand TremoloEvent to repeated notes, in the unfolding stage of articulation. Please review this at https://codereview.appspot.com/7033045/ Affected files: M ly/articulate.ly Index: ly/articulate.ly diff --git a/

Re: canonicalise notional octave of tonic (issue 7019045)

2013-01-01 Thread pkx166h
author Zefram Mon, 24 Dec 2012 23:00:35 + (23:00 +) committer James Lowe Tue, 1 Jan 2013 12:02:48 + (12:02 +) commit 60015c1d4aff30a610dced9a565fc1a6cb292be2 https://codereview.appspot.com/7019045/ ___ lilypond-devel mai

Re: articulate grace notes with time stealing (issue 7017045)

2013-01-01 Thread pkx166h
author Zefram Sat, 22 Dec 2012 21:43:42 + (21:43 +) committer James Lowe Tue, 1 Jan 2013 11:46:41 + (11:46 +) commit 98edd1f29c3b5b488ea41313445a3e6220c4a245 https://codereview.appspot.com/7017045/ ___ lilypond-devel mai