Re: markup-commands rest-by-number and rest (issue 6850073)

2012-12-04 Thread benko . pal
LGTM, thanks! https://codereview.appspot.com/6850073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses single algorithm for side-position spacing. (issue 6827072)

2012-12-04 Thread k-ohara5a5a
https://codereview.appspot.com/6827072/diff/19006/lily/side-position-interface.cc File lily/side-position-interface.cc (right): https://codereview.appspot.com/6827072/diff/19006/lily/side-position-interface.cc#newcode259 lily/side-position-interface.cc:259: : "vertical-skylines", Now I see why y

Re: markup-commands rest-by-number and rest (issue 6850073)

2012-12-04 Thread thomasmorley65
On 2012/12/04 19:49:00, benko.pal wrote: LGTM https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly File input/regression/markup-rest-styles.ly (right): https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly#newcode18 in

Re: A bit of rectification for learning/tweaks regarding Scheme values (issue 6868063)

2012-12-04 Thread tdanielsmusic
https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely#newcode952 Documentation/learning/tweaks.itely:952: @tab A constant vector can be

Re: A bit of rectification for learning/tweaks regarding Scheme values (issue 6868063)

2012-12-04 Thread dak
https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely#newcode937 Documentation/learning/tweaks.itely:937: @tab Any positive or negative,

Re: A bit of rectification for learning/tweaks regarding Scheme values (issue 6868063)

2012-12-04 Thread dak
Reviewers: Trevor Daniels, https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely#newcode902 Documentation/learning/tweaks.itely:902: @e

A bit of rectification for learning/tweaks regarding Scheme values (issue 6868063)

2012-12-04 Thread tdanielsmusic
Thanks David. Relatively minor quibbles only. https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely File Documentation/learning/tweaks.itely (right): https://codereview.appspot.com/6868063/diff/1/Documentation/learning/tweaks.itely#newcode902 Documentation/learning/

Re: Doc: cautionary accidentals after a key change (3000) (issue 6872049)

2012-12-04 Thread tdanielsmusic
https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely#newcode3301 Documentation/notation/changing

Re: '-signs in vectors - postulated in LM

2012-12-04 Thread David Kastrup
"Trevor Daniels" writes: > David, you wrote Tuesday, December 04, 2012 9:14 AM > >> I'll go through the section and try proposing something >> "programmatically correct", and then we'll take it from there. > > OK; thanks. http://code.google.com/p/lilypond/issues/detail?id=3005> -- David Kastru

Doc: All level 3 and 4 headings need nodes (2991) (issue 6864044)

2012-12-04 Thread graham
LGTM https://codereview.appspot.com/6864044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: '-signs in vectors - postulated in LM

2012-12-04 Thread Trevor Daniels
David, you wrote Tuesday, December 04, 2012 9:14 AM > I'll go through the section and try proposing something > "programmatically correct", and then we'll take it from there. OK; thanks. Trevor ___ lilypond-devel mailing list lilypond-devel@gnu.org ht

Re: markup-commands rest-by-number and rest (issue 6850073)

2012-12-04 Thread benko . pal
LGTM https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly File input/regression/markup-rest-styles.ly (right): https://codereview.appspot.com/6850073/diff/17001/input/regression/markup-rest-styles.ly#newcode18 input/regression/markup-rest-styles.ly:18: (symbo

Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py fromgoogle

2012-12-04 Thread Graham Percival
On Mon, Dec 03, 2012 at 06:42:24AM +0100, David Kastrup wrote: > For the record: I'd likely not use git pull -r (which basically is a > fetch and rebase on branch origin) in the LilyPond repository since it > is not always the right thing in our master/staging setup, and is > particularly wrong for

Re: '-signs in vectors - postulated in LM

2012-12-04 Thread Trevor Daniels
Thomas Morley wrote Monday, December 03, 2012 9:00 PM Subject: '-signs in vectors - postulated in LM > Due to the discussion started here: > http://lists.gnu.org/archive/html/lilypond-user/2012-12/msg00025.html > I thought about a patch removing all the superfluous '-signs in > vectors from the

Re: '-signs in vectors - postulated in LM

2012-12-04 Thread David Kastrup
"Trevor Daniels" writes: > David Kastrup wrote Re: '-signs in vectors - postulated in LM > > >> I just noticed that the file >> Documentation/learning/tweaks.itely generally talks a lot of nonsense >> about vectors, calling them a "list preceded by '#", which is rather >> misleading since at no t

Add note to manuals.html describing formats of manuals (Issue 2895) (issue 6867054)

2012-12-04 Thread PhilEHolmes
Reviewers: , Message: Please review. Passes make doc. Description: Describes how to access the different formats of the manuals on the stable manuals page. Please review this at https://codereview.appspot.com/6867054/ Affected files: M Documentation/web/manuals.itexi Index: Documentation/

Re: '-signs in vectors - postulated in LM

2012-12-04 Thread Trevor Daniels
David Kastrup wrote Re: '-signs in vectors - postulated in LM > I just noticed that the file > Documentation/learning/tweaks.itely generally talks a lot of nonsense > about vectors, calling them a "list preceded by '#", which is rather > misleading since at no time they are a list, I assume yo