Looks nice.
Maybe make it shorter, if you want.
https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.
https://codereview.appspot.com/6865049/diff/2001/Documentation/notation/ancient.itely
File Documentation/notation/ancient.itely (right):
https://codereview.appspot.com/6865049/diff/2001/Documentation/notation/ancient.itely#newcode2483
Documentation/notation/ancient.itely:2483: @node Kievan note
https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely
File Documentation/notation/changing-defaults.itely (right):
https://codereview.appspot.com/6872049/diff/2001/Documentation/notation/changing-defaults.itely#newcode3324
Documentation/notation/changing
2012/12/3 Aleksandr Andreev :
> I went into my git-cl directory and did a git pull -r
>
> Works fine for me now.
>
> Aleksandr
>
> On Sun, Dec 2, 2012 at 6:08 PM, Thomas Morley
> wrote:
>> 2012/12/2 Phil Holmes :
>>> - Original Message - From: "Graham Percival"
>>>
>>> To: "Phil Holmes"
I went into my git-cl directory and did a git pull -r
Works fine for me now.
Aleksandr
On Sun, Dec 2, 2012 at 6:08 PM, Thomas Morley
wrote:
> 2012/12/2 Phil Holmes :
>> - Original Message - From: "Graham Percival"
>>
>> To: "Phil Holmes"
>> Cc: ; "David Kastrup"
>> Sent: Sunday, Dece
Please review.
https://codereview.appspot.com/6865049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
2012/12/2 Phil Holmes :
> - Original Message - From: "Graham Percival"
>
> To: "Phil Holmes"
> Cc: ; "David Kastrup"
> Sent: Sunday, December 02, 2012 8:55 PM
>
> Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py
> fromgoogle
>
>
>> On Sun, Dec 02, 2012 at 02:47:27PM -
Graham Percival writes:
> On Sun, Dec 02, 2012 at 02:47:27PM -, Phil Holmes wrote:
>> Graham - could you either give me access to git-cl or push this
>> patch, please?
>
> I've given Phil push access to git-cl. David, if you have a
> github account I'll add you too.
Haven't.
--
David Kast
- Original Message -
From: "Graham Percival"
To: "Phil Holmes"
Cc: ; "David Kastrup"
Sent: Sunday, December 02, 2012 8:55 PM
Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py
fromgoogle
On Sun, Dec 02, 2012 at 02:47:27PM -, Phil Holmes wrote:
Graham - could
LGTM
https://codereview.appspot.com/6851102/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On Fri, Nov 30, 2012 at 02:16:21AM +0100, Thomas Morley wrote:
> Trying to minimize my lack of knowledge on this topic I searched the
> CG about It.
>
> CG 10.5.3 Indentation
> mentions possibilities for emacs and vim, but I'm not familiar with them.
> I'm using jEdit or gedit
>
> Following the l
On Sun, Dec 02, 2012 at 02:47:27PM -, Phil Holmes wrote:
> Graham - could you either give me access to git-cl or push this
> patch, please?
I've given Phil push access to git-cl. David, if you have a
github account I'll add you too.
- Graham
___
l
"Phil Holmes" writes:
> - Original Message -
> From: "David Kastrup"
> To: "Phil Holmes"
> Cc: ; "Graham Percival"
> Sent: Sunday, December 02, 2012 3:55 PM
> Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py
> fromgoogle
>
> [snip]
>
>> Then there should be some ot
- Original Message -
From: "David Kastrup"
To: "Phil Holmes"
Cc: ; "Graham Percival"
Sent: Sunday, December 02, 2012 3:55 PM
Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py
fromgoogle
[snip]
Then there should be some other "save"-like operation available. Wha
"Phil Holmes" writes:
> - Original Message -
>>>
>>> The mail message would not apply - possibly because I had to go
>>> Windows text->unicode->Ubuntu box.
>>
>> No. You should _not_ go "through" anything. You should just save the
>> whole message as a file (using Ctrl-S or whatever is
- Original Message -
From: "David Kastrup"
To: "Phil Holmes"
Cc: ; "Graham Percival"
Sent: Sunday, December 02, 2012 3:34 PM
Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py
fromgoogle
"Phil Holmes" writes:
If you save the whole message (rather than doing so
thomasmorle...@googlemail.com writes:
On 2012/11/27 20:03:06, benko.pal wrote:
> Did you had a look on the compiled output of the new reg-tests?
no. could you push to a dev/ branch?
Sorry. I'm still a newbie in devel tasks.
If you have a branch where you checked in your changes, you
"Phil Holmes" writes:
>> If you save the whole message (rather than doing some copy&paste job on
>> the mail client window) that should not be an issue in the first place.
>
> The mail message would not apply - possibly because I had to go
> Windows text->unicode->Ubuntu box.
No. You should _no
- Original Message -
From: "David Kastrup"
To:
Sent: Sunday, December 02, 2012 2:00 PM
Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py
fromgoogle
"Phil Holmes" writes:
- Original Message -
From: "David Kastrup"
To: "Phil Holmes"
Cc:
Sent: Sunday,
2012/12/2 David Kastrup :
> Thomas Morley writes:
>
>> 2012/12/2 David Kastrup :
>>> Thomas Morley writes:
>>>
2012/12/2 David Kastrup :
> David Kastrup writes:
>
>> Do
>>
>> git pull -r
>>
>> first to get your patch up-to-date.
>
> To get your git-cl rep
Thomas Morley writes:
> 2012/12/2 David Kastrup :
>> Thomas Morley writes:
>>
>>> 2012/12/2 David Kastrup :
David Kastrup writes:
> Do
>
> git pull -r
>
> first to get your patch up-to-date.
To get your git-cl repository up-to-date, sorry.
>>>
>>> Tried t
"Phil Holmes" writes:
> - Original Message -
> From: "David Kastrup"
> To: "Phil Holmes"
> Cc:
> Sent: Sunday, December 02, 2012 1:43 PM
> Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py
> from google
>
>
>> "Phil Holmes" writes:
>>
>>> I'd suggest pushing this d
2012/12/2 David Kastrup :
> Thomas Morley writes:
>
>> 2012/12/2 David Kastrup :
>>> David Kastrup writes:
>>>
Do
git pull -r
first to get your patch up-to-date.
>>>
>>> To get your git-cl repository up-to-date, sorry.
>>>
>>> --
>>> David Kastrup
>>>
>>>
>>>
- Original Message -
From: "David Kastrup"
To: "Phil Holmes"
Cc:
Sent: Sunday, December 02, 2012 1:43 PM
Subject: Re: [PATCH] Issue 2995: git-cly: Update to latest upload.py from
google
"Phil Holmes" writes:
I'd suggest pushing this direct to github: do you have the permission
"Phil Holmes" writes:
> I'd suggest pushing this direct to github: do you have the permission
> to do this?
No.
> If you don't, could you attach a patch as an attachment and I'll push
> it?
What is wrong with the mail called [PATCH]? You can just save it and
apply it using git-am.
--
David
Thomas Morley writes:
> 2012/12/2 David Kastrup :
>> David Kastrup writes:
>>
>>> Do
>>>
>>> git pull -r
>>>
>>> first to get your patch up-to-date.
>>
>> To get your git-cl repository up-to-date, sorry.
>>
>> --
>> David Kastrup
>>
>>
>> ___
>> lilypo
2012/12/2 David Kastrup :
> David Kastrup writes:
>
>> Do
>>
>> git pull -r
>>
>> first to get your patch up-to-date.
>
> To get your git-cl repository up-to-date, sorry.
>
> --
> David Kastrup
>
>
> ___
> lilypond-devel mailing list
> lilypond-devel@gnu
I'd suggest pushing this direct to github: do you have the permission to do
this? If you don't, could you attach a patch as an attachment and I'll push
it?
--
Phil Holmes
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.or
David Kastrup writes:
> Do
>
> git pull -r
>
> first to get your patch up-to-date.
To get your git-cl repository up-to-date, sorry.
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilyp
Thomas Morley writes:
> 2012/12/2 Thomas Morley :
>> 2012/12/2 Reinhold Kainhofer :
>>> On 2012-12-02 12:50, Thomas Morley wrote:
Trying to upload a new patch set for issue 2966, I ran into said
git-cl-issue.
Using LilyDev, I tried to apply Reinholds patch (after storing it in
Thomas Morley writes:
> Trying to upload a new patch set for issue 2966, I ran into said git-cl-issue.
> Using LilyDev, I tried to apply Reinholds patch (after storing it in
> git-cl.diff), but the terminal returns:
>
> harm@harm-laptop ~/lilypond-git (dev/local_working)$ git apply git-cl.diff
>
2012/12/2 Thomas Morley :
> 2012/12/2 Reinhold Kainhofer :
>> On 2012-12-02 12:50, Thomas Morley wrote:
>>>
>>> Trying to upload a new patch set for issue 2966, I ran into said
>>> git-cl-issue.
>>> Using LilyDev, I tried to apply Reinholds patch (after storing it in
>>> git-cl.diff), but the termi
2012/12/2 Reinhold Kainhofer :
> On 2012-12-02 12:50, Thomas Morley wrote:
>>
>> Trying to upload a new patch set for issue 2966, I ran into said
>> git-cl-issue.
>> Using LilyDev, I tried to apply Reinholds patch (after storing it in
>> git-cl.diff), but the terminal returns:
>>
>> harm@harm-lapto
On 2012-12-02 12:50, Thomas Morley wrote:
Trying to upload a new patch set for issue 2966, I ran into said git-cl-issue.
Using LilyDev, I tried to apply Reinholds patch (after storing it in
git-cl.diff), but the terminal returns:
harm@harm-laptop ~/lilypond-git (dev/local_working)$ git apply git
2012/12/2 David Kastrup :
> James writes:
>
>> David,
>>
>> On 2 December 2012 08:55, David Kastrup wrote:
>>> James writes:
>>>
>> ...
>>> Well, I have been using it already, and it is clearly an improvement
>>> over the previous situation, so it should be committed to git-cl, and
>>> people sh
Reviewers: dak,
Message:
On 2012/12/02 11:11:54, dak wrote:
https://codereview.appspot.com/6868047/diff/1/scm/document-translation.scm#newcode21
scm/document-translation.scm:21: ;; type predicates ly:engraver? and
ly:performer?.
I think that this approach is not really helping as it is inflexib
Improving the docs certainly is quite worthwhile.
https://codereview.appspot.com/6868047/diff/1/scm/document-translation.scm
File scm/document-translation.scm (right):
https://codereview.appspot.com/6868047/diff/1/scm/document-translation.scm#newcode21
scm/document-translation.scm:21: ;; type p
James writes:
> David,
>
> On 2 December 2012 08:55, David Kastrup wrote:
>> James writes:
>>
> ...
>> Well, I have been using it already, and it is clearly an improvement
>> over the previous situation, so it should be committed to git-cl, and
>> people should be encouraged to update their ver
David,
On 2 December 2012 08:55, David Kastrup wrote:
> James writes:
>
...
> Well, I have been using it already, and it is clearly an improvement
> over the previous situation, so it should be committed to git-cl, and
> people should be encouraged to update their version of git-cl afterwards
>
James writes:
> Hello,
>
> On 1 December 2012 17:24, Reinhold Kainhofer
> wrote:
>> On 2012-12-01 17:12, David Kastrup wrote:> My interpretation is that Google
>> has set codereview.appspot.com so that
>>> any http request will automatically get redirected to https, and git-cl
>>> is unable to
James wrote Sunday, December 02, 2012 8:15 AM
>
> On 1 December 2012 17:24, Reinhold Kainhofer
> wrote:
>> On 2012-12-01 17:12, David Kastrup wrote:> My interpretation is that Google
>> has set codereview.appspot.com so that
>>> any http request will automatically get redirected to https, and g
Hello,
On 1 December 2012 17:24, Reinhold Kainhofer wrote:
> On 2012-12-01 17:12, David Kastrup wrote:> My interpretation is that Google
> has set codereview.appspot.com so that
>> any http request will automatically get redirected to https, and git-cl
>> is unable to deal with that.
>
> Well, gi
42 matches
Mail list logo
