Re: fix representation switching from line-position to staff-space (issue 6778050)

2012-10-27 Thread dak
On 2012/10/27 20:34:35, benko.pal wrote: I want staves with line-positions like (-2 0 2 4) work. Why would somebody specify (-2 0 2 4) with the expectation that the results should be identical to (-3 -1 1 3)? Why would he not specify (-3 -1 1 3) in the first place then? How is something "wor

Re: fix representation switching from line-position to staff-space (issue 6778050)

2012-10-27 Thread benko . pal
Reviewers: Keith, dak, http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc File lily/breathing-sign.cc (left): http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc#oldcode88 lily/breathing-sign.cc:88: int const int_dim = (int) ydim[i]; On 2012/10/27 19:36:21

Re: fix representation switching from line-position to staff-space (issue 6778050)

2012-10-27 Thread dak
http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc File lily/breathing-sign.cc (left): http://codereview.appspot.com/6778050/diff/1001/lily/breathing-sign.cc#oldcode88 lily/breathing-sign.cc:88: int const int_dim = (int) ydim[i]; On 2012/10/27 19:36:21, Keith wrote: If you w

fix representation switching from line-position to staff-space (issue 6778050)

2012-10-27 Thread k-ohara5a5a
The regression tester looks for changed X/Y-extents, but gregorian.ly enlarges the extents of the BreathingSign so it can be used for these bar-line-like-things without letting notes overlap, so the regression tester does not notice these changes. http://codereview.appspot.com/6778050/diff/1001/