Re: adds documentation for the new bar line interface (issue 6742061)

On 2012/10/23 23:22:03, J_lowe wrote: One typo so, as we need to fix this, I also included a minor grammar change. Otherwise LGTM. https://codereview.appspot.com/6742061/diff/10001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

On 2012/10/23 19:45:15, dak wrote: On 2012/10/23 19:05:09, marc wrote: > Hey, that was quick! Thanks for solving this issue - LGTM! Well, there is no regtest and no documentation, so it is not like there is nothing left to do. That's right – we had this discussion before concerning new fea

PATCH: Countdown to 20121025

For 20:00 MDT Thursday October 25 Enhancement: Issue 2920 : Patch: Revert "Archive baselines in LILYPOND_BASELINES directory if specified" - R 6709073 Issue 2917

Re: glossary - add 'high bass clef'

Arnold I think this might be better on dev list than bug so I am ccing dev in case you are not subscribed to that list yet. On 23 October 2012 12:54, ArnoldTheresius wrote: > James wrote >> Hello, >> >> ... >> >> Well I have applied this patch and I am not sure it is appropriate for >> the gloss

Re: adds documentation for the new bar line interface (issue 6742061)

One typo so, as we need to fix this, I also included a minor grammar change. Otherwise LGTM. https://codereview.appspot.com/6742061/diff/10001/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): https://codereview.appspot.com/6742061/diff/10001/Documentati

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

On 2012/10/23 19:05:09, marc wrote: Hey, that was quick! Thanks for solving this issue - LGTM! Well, there is no regtest and no documentation, so it is not like there is nothing left to do. And to be honest, the usual "to check this feature, you have used some code and could equally well turn

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

Hey, that was quick! Thanks for solving this issue - LGTM! http://codereview.appspot.com/6744070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: prevent collision of ligatures and next note (issue 6740046)

hi Janek, Pal, could you add some comments and a more descriptive commit message? I see the code, and it seems to make sense, but i don't understand the "why's". For example, why the parameters should be passed in a different way? in C++ there should be a good reason to pass complex stru

Re: adds documentation for the new bar line interface (issue 6742061)

On 2012/10/23 09:03:32, J_lowe wrote: Mark, Nearly there. Hey, sounds prominsing ;-) Some more general comments - some are Doc Policy, some are my own views on how to organize this section, also can you make sure you use two spaces after a full point (full stop) as this is also the CG

New bar line interface: adds volta bracket regtest; minor changes (issue 6737051)

LGTM, i think. best, Janek http://codereview.appspot.com/6737051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Create \temporary for doing overrides without pop-first set (issue 6687044)

pushed as 5c4b80afe97acbe20199a3aa71a0d63172112f23 David, please close this issue. thanks! Janek http://codereview.appspot.com/6687044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: prevent collision of ligatures and next note (issue 6740046)

(as you may know, i dedicate all my code reviews to Graham the Magnificent :D) Pal, could you add some comments and a more descriptive commit message? I see the code, and it seems to make sense, but i don't understand the "why's". For example, why the parameters should be passed in a different w

Re: Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

Reviewers: lemzwerg, Message: On 2012/10/23 11:19:59, lemzwerg wrote: LGTM. Any convert rules necessary? Well, I abolish list-or-symbol? here on the assumption that nobody used this peculiar and mostly ill-advised predicate. That is somewhat optimistic. Converting list-or-symbol? automatica

Issue 2917: Extend \keepWithTag to allow multiple tags (issue 6744070)

LGTM. Any convert rules necessary? http://codereview.appspot.com/6744070/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Revert "Archive baselines in LILYPOND_BASELINES directory if specified" (issue 6709073)

LGTM. http://codereview.appspot.com/6709073/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: reformatted GNUmakefile pushed to staging

Werner LEMBERG writes: >> out=test \ >> local-test >> /bin/sh: 1: local-test: not found >> make: *** [test] Error 127 > > Thanks, I'll upload a fixed patch with patchy. However, you are going > to remove some stuff from GNUmakefile, right? Then I'll wait. It would make sense to

Re: reformatted GNUmakefile pushed to staging

> out=test \ > local-test > /bin/sh: 1: local-test: not found > make: *** [test] Error 127 Thanks, I'll upload a fixed patch with patchy. However, you are going to remove some stuff from GNUmakefile, right? Then I'll wait. > I am backing this change out of staging again. Thank

Re: reformatted GNUmakefile pushed to staging

Werner LEMBERG writes: >> I have run my own copy of patchy-merge, and it failed because of >> typos in the Makefile, > > Details, please. I already sent the details previous to writing the quoted mail above, but looking at the list archives it would appear that Gmane swallowed them as Spam or TO

Re: reformatted GNUmakefile pushed to staging

David Kastrup writes: > Werner LEMBERG writes: > >> Folks, >> >> >> as discussed some weeks ago, I've now pushed the reformatted >> GNUmakefile to staging. There are only whitespace changes. > > Is there anything wrong with our review system? If you feel there is, > how about at least posting

Re: svg output

2012/10/23 James : > Do all browsers accept output in SVG what about PDF readers? > I think that it should be limited to html. The main problem is IE, because the basic support was added only in version 9: http://en.wikipedia.org/wiki/Scalable_Vector_Graphics#Support_for_SVG_in_web_browsers But t

Re: reformatted GNUmakefile pushed to staging

> I have run my own copy of patchy-merge, and it failed because of > typos in the Makefile, Details, please. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: reformatted GNUmakefile pushed to staging

>> as discussed some weeks ago, I've now pushed the reformatted >> GNUmakefile to staging. There are only whitespace changes. > > Is there anything wrong with our review system? If you feel there > is, how about at least posting the patch for review on the list > before pushing? It *has* been p

Re: reformatted GNUmakefile pushed to staging

James writes: > Hello, > > On 23 October 2012 08:26, David Kastrup wrote: >> Werner LEMBERG writes: >> >>> Folks, >>> >>> >>> as discussed some weeks ago, I've now pushed the reformatted >>> GNUmakefile to staging. There are only whitespace changes. >> >> Is there anything wrong with our revie

Re: reformatted GNUmakefile pushed to staging

Hello, On 23 October 2012 08:26, David Kastrup wrote: > Werner LEMBERG writes: > >> Folks, >> >> >> as discussed some weeks ago, I've now pushed the reformatted >> GNUmakefile to staging. There are only whitespace changes. > > Is there anything wrong with our review system? If you feel there i

Re: svg output

Hello, On 23 October 2012 10:05, Federico Bruni wrote: > 2012/10/23 David Kastrup : >> Texinfo does not support SVG as far as I know. And neither do typical >> info readers like Emacs if I remember correctly. > > This page seems to confirm your statement: > http://www.gnu.org/software/texinfo/ma

Re: svg output

2012/10/23 David Kastrup : > Texinfo does not support SVG as far as I know. And neither do typical > info readers like Emacs if I remember correctly. This page seems to confirm your statement: http://www.gnu.org/software/texinfo/manual/texinfo/html_node/Image-Syntax.html#Image-Syntax But then wh

Re: adds documentation for the new bar line interface (issue 6742061)

Mark, Nearly there. Some more general comments - some are Doc Policy, some are my own views on how to organize this section, also can you make sure you use two spaces after a full point (full stop) as this is also the CG policy (even if it does go against every grain in my typographically-based

Re: svg output

Federico Bruni writes: > 2012/10/23 Joram Berger : >> Ok, I've overlooked that. >> Btw: SVG output is really nice! > > I agree. > Personally, I'd love to see it used in the documentation. I wonder if > it's possible to build the documentation using SVGs instead of PNGs.. > The documentation would

Re: svg output

2012/10/23 Joram Berger : > Ok, I've overlooked that. > Btw: SVG output is really nice! I agree. Personally, I'd love to see it used in the documentation. I wonder if it's possible to build the documentation using SVGs instead of PNGs.. The documentation would be lighter, faster when browsed onlin

Re: [PossibleSpam] Re: [PossibleSpam] Re: 2.16.1

Francisco Vila writes: > 2012/10/23 David Kastrup : >> Well, LilyPond could see a problem in connection with issue 2883. Not >> because of a Spanish version of changes.tely but because of outdated >> syntax in the Spanish version, syntax that just was not present in the >> English version, and t

Re: [PossibleSpam] Re: [PossibleSpam] Re: 2.16.1

2012/10/23 David Kastrup : > Well, LilyPond could see a problem in connection with issue 2883. Not > because of a Spanish version of changes.tely but because of outdated > syntax in the Spanish version, syntax that just was not present in the > English version, and that did not get converted with

Re: reformatted GNUmakefile pushed to staging

Werner LEMBERG writes: > Folks, > > > as discussed some weeks ago, I've now pushed the reformatted > GNUmakefile to staging. There are only whitespace changes. Is there anything wrong with our review system? If you feel there is, how about at least posting the patch for review on the list befo

Re: Doc: NR 5.3 Add \single command (issue 6742057)

On 2012/10/20 17:52:29, J_lowe wrote: Here is the first draft of reworking NR 5.3 while adding the \single command. James, I like the changes very much – the restructuring makes the doc more readable and understandable IMHO. I _expect_ to have lots of edits and go through a few iterations of

Re: svg output

Am 23.10.2012 09:08, Federico Bruni: > 2012/10/23 Joram Berger : >> Even though things are perhaps a little bit different, I would suggest >> to include svg (or the whole backend-options) into formats, if possible. >> Because thats essentially what the user wants: get the output in the >> format sv

Re: svg output

2012/10/23 Joram Berger : > Even though things are perhaps a little bit different, I would suggest > to include svg (or the whole backend-options) into formats, if possible. > Because thats essentially what the user wants: get the output in the > format svg. there's an old issue still open for thi