Re: parser.yy: remove STRING_IDENTIFIER token (issue 6542057)

2012-09-25 Thread dak
Reviewers: lemzwerg, joeneeman, janek, Message: On 2012/09/26 05:35:16, janek wrote: David wrote: > ...and where the semantics indeed require a plain string, > an error is generated explicitly in the action instead > of leaving it to the parser to complain about bad grammar. I'm not sure i un

Re: Replacing the r1 glyph

2012-09-25 Thread Janek Warchoł
Hi Oscar, On Wed, Sep 26, 2012 at 2:30 AM, Oscar Dub wrote: > I'm trying to typeset a score that uses the notation shown in the attached > image to represent whole rests. > > As I see it there are two stages to achieving this in LilyPond: > – Creating the necessary glyph (I assume the simplest w

Re: [GLISS] facilitate changes of the (default-) drumStyleTable

2012-09-25 Thread Marc Hohl
Am 26.09.2012 02:25, schrieb Thomas Morley: Hi, sometimes I heard users complaining about the difficulty of changing the appearance of customized percussion staves, The NR "Custom percussion staves" states: "If you do not like any of the predefined lists you can define your own list at the top

Re: Set up indent-tabs-mode in lexer.ll and parser.yy (issue 6551050)

2012-09-25 Thread janek . lilypond
On 2012/09/26 06:32:15, dak wrote: will do. thanks, and LGTM http://codereview.appspot.com/6551050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix vertical position of Kievan dots (issue 6570047)

2012-09-25 Thread janek . lilypond
LGTM http://codereview.appspot.com/6570047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Set up indent-tabs-mode in lexer.ll and parser.yy (issue 6551050)

2012-09-25 Thread dak
Reviewers: joeneeman, janek, Message: On 2012/09/26 05:24:37, janek wrote: Do i understand correctly that this is something for Emacs' sake? If so, please add this information to the commit message, so that non-emacs people like me will immediately know what's it about. Oops. Sorry for the

Re: Web: Add Elysium to Easier Editing section (issue 6546059)

2012-09-25 Thread graham
LGTM http://codereview.appspot.com/6546059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Web: Add Elysium to Easier Editing section (issue 6546059)

2012-09-25 Thread janek . lilypond
lgtm http://codereview.appspot.com/6546059/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Get along with use of grob-property instead of grob-property-path in overrides (issue 6544060)

2012-09-25 Thread janek . lilypond
Do i understand correctly that grob-property-path is just a list of properties, like '('thickness 'gap 'color)? If so, i find the name misleading. Anyway, i don't feel competent to give an "LGTM" to a Scheme patch i don't understand - but i had certainly not noticed anything wrong. http://code

Re: PATCH: Countdown to 20120925

2012-09-25 Thread Janek Warchoł
Reviews done - thanks for waiting! Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: note-collision: retain upper voice dot when merging dots (issue 6550056)

2012-09-25 Thread janek . lilypond
lgtm :) http://codereview.appspot.com/6550056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: spacing-spanner: rods for non-adjacent paper-columns; issue 1700 (issue 6489107)

2012-09-25 Thread janek . lilypond
lgtm, i think. http://codereview.appspot.com/6489107/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: parser.yy: remove STRING_IDENTIFIER token (issue 6542057)

2012-09-25 Thread janek . lilypond
David wrote: ...and where the semantics indeed require a plain string, an error is generated explicitly in the action instead of leaving it to the parser to complain about bad grammar. I'm not sure i understand. Does this mean that in some situations there will be errors that were not present

Re: Set up indent-tabs-mode in lexer.ll and parser.yy (issue 6551050)

2012-09-25 Thread janek . lilypond
Do i understand correctly that this is something for Emacs' sake? If so, please add this information to the commit message, so that non-emacs people like me will immediately know what's it about. thanks, Janek http://codereview.appspot.com/6551050/ __

PATCH: Countdown to 20120927

2012-09-25 Thread Colin Campbell
For 22:00 MDT Thursday Sept 27 (04:00 UTC 20120928) Defect: Issue 2856 : Patch: Get along with use of grob-property instead of grob-property-path in overrides - R 6544060 Documentation:

Re: PATCH: Countdown to 20120925

2012-09-25 Thread Colin Campbell
On 12-09-25 02:36 PM, Janek Warchoł wrote: Hi, On Mon, Sep 24, 2012 at 4:44 AM, Colin Campbell wrote: For 21:00 MDT Tuesday September 25 Enhancement: Issue 2717: Implement \single, \omit and \hide - R 6495135 Issue 2853: Patch: Set up indent-tabs-mode in lexer.ll and parser.yy - R 6

[GLISS] facilitate changes of the (default-) drumStyleTable

2012-09-25 Thread Thomas Morley
Hi, sometimes I heard users complaining about the difficulty of changing the appearance of customized percussion staves, The NR "Custom percussion staves" states: "If you do not like any of the predefined lists you can define your own list at the top of your file." and demonstrates the use of \se

note-collision: retain upper voice dot when merging dots (issue 6550056)

2012-09-25 Thread joeneeman
lgtm http://codereview.appspot.com/6550056/diff/1/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/6550056/diff/1/lily/note-collision.cc#newcode251 lily/note-collision.cc:251: dot_wipe_head = head_down; Comment, please? (eg. it would make a nice addition

Re: parser.yy: remove STRING_IDENTIFIER token (issue 6542057)

2012-09-25 Thread joeneeman
lgtm http://codereview.appspot.com/6542057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Set up indent-tabs-mode in lexer.ll and parser.yy (issue 6551050)

2012-09-25 Thread joeneeman
lgtm http://codereview.appspot.com/6551050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: PATCH: Countdown to 20120925

2012-09-25 Thread David Kastrup
David Kastrup writes: >>> Issue 2853: Patch: Set up indent-tabs-mode in lexer.ll and parser.yy - R >>> 6551050 >>> Issue 2854: Patch: parser.yy: remove STRING_IDENTIFIER token - R 6542057 > > Those two are stopping me from submitting further work to the parser. > The first one is a nuisan

Re: Doc: Improve documentation of \glissando. (issue 6529043)

2012-09-25 Thread benko . pal
http://codereview.appspot.com/6529043/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/6529043/diff/1/Documentation/notation/expressive.itely#newcode1059 Documentation/notation/expressive.itely:1059: @lilypond[verb

Re: PATCH: Countdown to 20120925

2012-09-25 Thread David Kastrup
Janek Warchoł writes: > Hi, > > On Mon, Sep 24, 2012 at 4:44 AM, Colin Campbell wrote: >> For 21:00 MDT Tuesday September 25 >> >> Enhancement: >> Issue 2717: Implement \single, \omit and \hide - R 6495135 This one had been resubmitted and consequently is back to Patch-review. The change is

Re: Feature request

2012-09-25 Thread David Kastrup
Jean-Charles Malahieude writes: > Le 24/09/2012 22:18, Janek Warchoł disait : >> On Monday, September 24, 2012, David Kastrup wrote: >>> We get about 1 request per month of the kind in >>> http://lists.gnu.org/archive/html/lilypond-user/2012-09/msg00600.html> >>> "I can't get the automated beams

Re: Doc: Improve documentation of \glissando. (issue 6529043)

2012-09-25 Thread tdanielsmusic
One more question (sorry, I'm not familiar with this notation, and I'd like to be sure it's right.) Trevor http://codereview.appspot.com/6529043/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/6529043/diff/1/Do

Re: PATCH: Countdown to 20120925

2012-09-25 Thread Janek Warchoł
Hi, On Mon, Sep 24, 2012 at 4:44 AM, Colin Campbell wrote: > For 21:00 MDT Tuesday September 25 > > Enhancement: > Issue 2717: Implement \single, \omit and \hide - R 6495135 > Issue 2853: Patch: Set up indent-tabs-mode in lexer.ll and parser.yy - R > 6551050 > Issue 2854: Patch: parse

Re: [GLISS] basics

2012-09-25 Thread Joseph Rushton Wakeling
On 24/09/12 14:07, Janek Warchoł wrote: I suggest to ask more for complaints than for ideas: what users find confusing, inconvenient and difficult to express in Lily syntax. I think this will be more valuable information than proposals "let's have a syntax like this". Actually, rather than "wh

Re: [talk] easy tuplets

2012-09-25 Thread David Kastrup
Ian Hulin writes: > Advantages: > 1. Quicker note entry for triplet quaver and crotchet groups. > 2. It is considerably less opaque and cryptic-looking than the other > alternative to \times 2/3 { ... } > c8*2/3 c c . > > Drawbacks: The main drawback I see is that the specification is "in lowest

Re: Feature request

2012-09-25 Thread Jean-Charles Malahieude
Le 25/09/2012 19:11, Ian Hulin disait : On 25/09/12 18:02, Jean-Charles Malahieude wrote: Why not "mimic" the difference between phrasing slur and slur: \beaming 4/4 { c16\[[ c c c] c[ c c c]\] c8[ c] c[ c] } Je suis désolé, mais \[ \] are already spoken for as delimiters for early-music me

Re: Feature request

2012-09-25 Thread Ian Hulin
On 25/09/12 18:02, Jean-Charles Malahieude wrote: > > Why not "mimic" the difference between phrasing slur and slur: > > \beaming 4/4 { c16\[[ c c c] c[ c c c]\] c8[ c] c[ c] } > Je suis désolé, mais \[ \] are already spoken for as delimiters for early-music melismata. Cheers, Ian _

Re: Fixes position of mensural c clef (issue 6503091)

2012-09-25 Thread lemzwerg
If you do mf '\mode:=proof; input parmesan20' gftodvi parmesan20.2602gf and view the resulting parmesan20.dvi with xdvi, go to your glyph, then press `10 s' to set the shrink factor to 10. This makes the image small enough that you can see even the part of the glyph which is below the lower

Re: [talk] easy tuplets

2012-09-25 Thread Ian Hulin
On 23/09/12 22:45, Graham Percival wrote: > This is an informal chat idea, following David's latest suggestion > that such emails could go on -devel instead of requiring a separate > mailing list. I fully expect this not to work. > But let's give it a go anyway. I have a few concerns, but these

Re: Feature request

2012-09-25 Thread Jean-Charles Malahieude
Le 24/09/2012 22:18, Janek Warchoł disait : On Monday, September 24, 2012, David Kastrup wrote: We get about 1 request per month of the kind in http://lists.gnu.org/archive/html/lilypond-user/2012-09/msg00600.html> "I can't get the automated beams to look like the manual beams in measure 1". Ca

Re: Doc: Improve documentation of \glissando. (issue 6529043)

2012-09-25 Thread benko . pal
http://codereview.appspot.com/6529043/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/6529043/diff/1/Documentation/notation/expressive.itely#newcode1074 Documentation/notation/expressive.itely:1074: @lilypond[verb

Re: [talk] easy tuplets

2012-09-25 Thread James
On 25 September 2012 16:49, Joseph Rushton Wakeling wrote: > On 25/09/12 06:48, Keith OHara wrote: >> >> Try it out. Enter some Debussy using 12th-notes, 9th notes, etc. >> > > > If nested tuplets are your intended testing

Re: [talk] easy tuplets

2012-09-25 Thread Joseph Rushton Wakeling
On 25/09/12 06:48, Keith OHara wrote: Try it out. Enter some Debussy using 12th-notes, 9th notes, etc. If nested tuplets are your intended testing ground, try engraving Ferneyhough. All else is playground stuff. :-)

Re: Doc: Improve documentation of \glissando. (issue 6529043)

2012-09-25 Thread benko . pal
http://codereview.appspot.com/6529043/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/6529043/diff/1/Documentation/notation/expressive.itely#newcode1074 Documentation/notation/expressive.itely:1074: @lilypond[verb

Re: [talk] easy tuplets

2012-09-25 Thread Joseph Rushton Wakeling
On 24/09/12 18:27, David Kastrup wrote: I don't like it since it does not match musical concepts. You would not talk about "12th notes" to other musicians. That's not entirely true. Contemporary composers (I think Ferneyhough started it, others have continued it) have used time signatures li

Fix vertical position of Kievan dots (issue 6570047)

2012-09-25 Thread aleksandr . andreev
Reviewers: , Message: Please review. Description: Fix vertical position of Kievan dots Dots in Kievan notation should be placed at the same Y_AXIS position as the note, even if they occur on a line. Issue 2857. Please review this at http://codereview.appspot.com/6570047/ Affected files: M

Re: Doc: Improve documentation of \glissando. (issue 6529043)

2012-09-25 Thread tdanielsmusic
I'm reworking these examples ready for insertion in the NR, but I'd like to see responses to my comment below first. Trevor http://codereview.appspot.com/6529043/diff/1/Documentation/notation/expressive.itely File Documentation/notation/expressive.itely (right): http://codereview.appspot.com/

Re: Fixes position of mensural c clef (issue 6503091)

2012-09-25 Thread PhilEHolmes
On 2012/09/25 14:04:03, lemzwerg wrote: LGTM, except one small issue. http://codereview.appspot.com/6503091/diff/20001/mf/parmesan-clefs.mf File mf/parmesan-clefs.mf (right): http://codereview.appspot.com/6503091/diff/20001/mf/parmesan-clefs.mf#newcode816 mf/parmesan-clefs.mf:816: 2.2 redu

Re: Fixes position of mensural c clef (issue 6503091)

2012-09-25 Thread lemzwerg
LGTM, except one small issue. http://codereview.appspot.com/6503091/diff/20001/mf/parmesan-clefs.mf File mf/parmesan-clefs.mf (right): http://codereview.appspot.com/6503091/diff/20001/mf/parmesan-clefs.mf#newcode816 mf/parmesan-clefs.mf:816: 2.2 reduced_il#); The bbox is still too small. I sug

Re: Fixes position of mensural c clef (issue 6503091)

2012-09-25 Thread PhilEHolmes
Please review http://codereview.appspot.com/6503091/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Issue 2758. ly_module_lookup caused deprecation warnings with Guile V2.06. (issue 6458159)

2012-09-25 Thread ianhulin44
Closing Rietveld issue now that Tracker Issue 2758 has been verified. Ian http://codereview.appspot.com/6458159/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel