Re: Properly implement fromproperty markup handing in the pdftitle header field (issue 6447052)

2012-08-05 Thread dak
On 2012/08/05 23:26:46, reinhold_kainhofer.com wrote: On 2012-08-06 00:44, mailto:d...@gnu.org wrote: > > http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm > File scm/markup.scm (right): > > http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm#newcode109 > scm/markup.scm:

Re: Properly implement fromproperty markup handing in the pdftitle header field (issue 6447052)

2012-08-05 Thread Reinhold Kainhofer
On 2012-08-06 00:44, d...@gnu.org wrote: http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm File scm/markup.scm (right): http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm#newcode109 scm/markup.scm:109: (define (markup-cons->string-cons c props) "props" seems like a tota

Re: PATCHES: Brain surgery on the build system, first stage

2012-08-05 Thread John Mandereau
Hi Han-Wen, Thanks for these comments, I'll submit another patch as soon as I get back to my faster laptop to retest changes extensively. Le samedi 04 août 2012 à 12:00 -0300, Han-Wen Nienhuys a écrit : > * is there a need for vc-clean at all? People can just git clone the > repo when they want to

Re: Properly implement fromproperty markup handing in the pdftitle header field (issue 6447052)

2012-08-05 Thread dak
http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm File scm/markup.scm (right): http://codereview.appspot.com/6447052/diff/4001/scm/markup.scm#newcode109 scm/markup.scm:109: (define (markup-cons->string-cons c props) "props" seems like a total misnomer: that is usually used for a lis

Patchy report from grenouille

2012-08-05 Thread grenouille
08:55:13 (UTC) Begin LilyPond compile, previous commit at ac0e95c8112250bcaddf0bce57ba2980767a2f43 08:55:18 Merged staging, now at:c28baa15608b96e15ae3971ac2a70cc65282c110 08:55:23Success:./autogen.sh --noconfigure 08:56:29Success:../co

Patchy report from grenouille

2012-08-05 Thread grenouille
16:55:18 (UTC) Begin LilyPond compile, previous commit at ac0e95c8112250bcaddf0bce57ba2980767a2f43 16:55:18 *** FAILED STEP *** merge from staging Command '['git', 'branch', 'test-master-lock', 'origin/master']' returned non-zero exit status 128 fatal: A branch named 'test-m

Re: A series of gitdiff patches from offline development

2012-08-05 Thread Phil Holmes
- Original Message - From: "ArnoldTheresius" To: Sent: Friday, July 13, 2012 9:08 AM Subject: A series of gitdiff patches from offline development 2) patch_diff_f.txt: Moved the end hook check of the VoltaBracket from volta-bracket.cc to volta-engraver.cc. The linebreaking check is s