Re: Doc: mention empty chords; avoid using zero-duration spacers in examples (issue 6197068)

ok. http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/keyboards.itely File Documentation/notation/keyboards.itely (right): http://codereview.appspot.com/6197068/diff/24001/Documentation/notation/keyboards.itely#newcode210 Documentation/notation/keyboards.itely:210: e''2\p\

PATCH: Countdown to 20120614

For 20:00 MDT Thursday June 14 Critical: Issue 2587 : Ugly slur in TabStaff if font is changed - R 6303065 Defect: Issue 582 : sl

giving out git push ability

Who thinks they should have git push ability? I usually tell people not to ask unless prompted, so now I'm prompting. General rule of thumb is that you should have a bunch of patches accepted, and generally be a trustworthy character. Or something like that. - Graham __

Re: Sets TabVoice Stem height to ##f (issue 6303065)

On 2012/06/12 13:47:34, MikeSol wrote: On 2012/06/12 13:43:09, dak wrote: > If a type is named "Interval", it needs to be employed as an Interval, not as > something totally different that relies on implementation details. > > Otherwise type abstraction makes code _less_ maintainable rather

Re: Sets TabVoice Stem height to ##f (issue 6303065)

On 2012/06/12 13:43:09, dak wrote: Here is a code example from beam.cc: Interval weights (1 - multiplier, multiplier); if (feather_dir != LEFT) weights.swap (); This is _hogwash_. weights is not an _interval_ here, but a pair of numbers. Swapping the bounds of a

Re: Sets TabVoice Stem height to ##f (issue 6303065)

Here is a code example from beam.cc: Interval weights (1 - multiplier, multiplier); if (feather_dir != LEFT) weights.swap (); This is _hogwash_. weights is not an _interval_ here, but a pair of numbers. Swapping the bounds of an interval does not even make _sense_. Where

Re: Sets TabVoice Stem height to ##f (issue 6303065)

On 2012/06/12 13:22:10, dak wrote: On 2012/06/12 12:54:40, MikeSol wrote: > On 2012/06/12 12:49:45, dak wrote: > > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc > > File lily/grob.cc (right): > > > > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 > > li

Re: Sets TabVoice Stem height to ##f (issue 6303065)

On 2012/06/12 12:54:40, MikeSol wrote: On 2012/06/12 12:49:45, dak wrote: > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc > File lily/grob.cc (right): > > http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 > lily/grob.cc:472: real_ext[d] += offset; > On 201

Re: Sets TabVoice Stem height to ##f (issue 6303065)

On 2012/06/12 12:49:45, dak wrote: http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 lily/grob.cc:472: real_ext[d] += offset; On 2012/06/12 12:32:37, dak wrote: > I don't understand

Re: Sets TabVoice Stem height to ##f (issue 6303065)

http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 lily/grob.cc:472: real_ext[d] += offset; On 2012/06/12 12:32:37, dak wrote: I don't understand this. The only way to get a nan from

Re: Sets TabVoice Stem height to ##f (issue 6303065)

On 2012/06/12 12:32:37, dak wrote: http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 lily/grob.cc:472: real_ext[d] += offset; I don't understand this. The only way to get a nan fro

Re: Sets TabVoice Stem height to ##f (issue 6303065)

http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc File lily/grob.cc (right): http://codereview.appspot.com/6303065/diff/10003/lily/grob.cc#newcode472 lily/grob.cc:472: real_ext[d] += offset; I don't understand this. The only way to get a nan from adding an offset to infinity is by a

Re: Deletes logfiles in build dir with make clean (issue 6300079)

I'm not certain cleaning the build tree should include log files cleaning, when a simple "find -name '*.log' |xargs rm -f" does the job. However, if this is a very popular request, then you may want to read a few comments. http://codereview.appspot.com/6300079/diff/1/GNUmakefile.in File GNUmake