Re: Deletes logfiles in build dir with make clean (issue 6300079)

2012-06-11 Thread graham
LGTM http://codereview.appspot.com/6300079/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [Lilypond-auto] Issue 2580 in lilypond: Apparent mistake in output-lib.scm - fine barglyph-alist

2012-06-11 Thread Marc Hohl
Am 11.06.2012 13:14, schrieb lilyp...@googlecode.com: Updates: Status: Fixed Labels: -Patch-push Fixed_2_15_41 Comment #7 on issue 2580 by philehol...@gmail.com: Apparent mistake in output-lib.scm - fine barglyph-alist http://code.google.com/p/lilypond/issues/detail?id=2580 Pushed as c2832e02

Re: Sets TabVoice Stem height to ##f (issue 6303065)

2012-06-11 Thread k-ohara5a5a
LGTM if you re-read the comment before you push. http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc File lily/stem.cc (right): http://codereview.appspot.com/6303065/diff/9001/lily/stem.cc#newcode707 lily/stem.cc:707: return an empty interval when there is no beam. The comment doesn't

avoid slur-tie collision? (issue #582)

2012-06-11 Thread Werner LEMBERG
Naive question: We have a lot of code to avoid collisions between various grobs. What about slurs and ties? Look at issue #582 for samples. Werner ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lily

Re: Fix for beaming in Kievan notation (issue 6305080)

2012-06-11 Thread aleksandr . andreev
On 2012/06/11 00:49:42, Keith wrote: looks good to me. The question I have now is how to affect the position of the beam. It needs to attach toward the bottom of the "stem" and not at center of the staff. http://codereview.appspot.com/6305080/ ___ l

Deletes logfiles in build dir with make clean (issue 6300079)

2012-06-11 Thread PhilEHolmes
Reviewers: Julien Rioux, Graham Percival, Message: Please review. Description: Fixes issue 2415 by deleting all the logfiles created during make, make doc or make test. The deletion is non-selective - running make clean, make doc clean or make test clean will delete all the logfiles created in

Patchy email

2012-06-11 Thread lilypond-auto
12:09:01 (UTC) Begin LilyPond compile, previous commit at f169a3bc634eea92d3d87d18ce243bcea0216ba6 12:13:39 *** FAILED STEP *** merge from staging Command 'git branch test-master-lock origin/master' returned non-zero exit status 128 fatal: A branch named 'test-master-loc

Re: Sets TabVoice Stem height to ##f (issue 6303065)

2012-06-11 Thread mtsolo
On 2012/06/11 07:48:34, dak wrote: On 2012/06/11 07:24:33, MikeSol wrote: > On 2012/06/11 07:10:48, dak wrote: > > > Personally, I consider it an accident waiting to happen if downing the stencil > > is not enough to suppress its consideration. > > > > _Iff_ there is a situation where it is rea

Re: Auto-merging translations and master

2012-06-11 Thread John Mandereau
Il giorno mar, 05/06/2012 alle 10.42 -0300, Han-Wen Nienhuys ha scritto: > it would be best if "make dist" were rewritten to take git's idea of > the tree, and then add any necessary generated files (eg. configure, > README) to that. If we go this route, we should have a fallback for making dist o

Re: Sets TabVoice Stem height to ##f (issue 6303065)

2012-06-11 Thread dak
On 2012/06/11 07:24:33, MikeSol wrote: On 2012/06/11 07:10:48, dak wrote: > Personally, I consider it an accident waiting to happen if downing the stencil > is not enough to suppress its consideration. > > _Iff_ there is a situation where it is really required to have a non-zero > height,

Re: Sets TabVoice Stem height to ##f (issue 6303065)

2012-06-11 Thread mtsolo
On 2012/06/11 07:10:48, dak wrote: On 2012/06/11 05:34:23, MikeSol wrote: > This shows a case where stem height cannot be determined by stem stencil > presence. The first version of the patch works under the assumption that > information about height cannot be gleaned from the stencil and

Re: Sets TabVoice Stem height to ##f (issue 6303065)

2012-06-11 Thread dak
On 2012/06/11 05:34:23, MikeSol wrote: This shows a case where stem height cannot be determined by stem stencil presence. The first version of the patch works under the assumption that information about height cannot be gleaned from the stencil and must be made explicit through overrides.