Re: Problem running makelsr.py

2012-04-15 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "James" ; "Phil Holmes" Cc: "Devel" Sent: Sunday, April 15, 2012 10:24 PM Subject: Re: Problem running makelsr.py On Sun, Apr 15, 2012 at 10:18:41PM +0100, James wrote: james@jameslilydev2:~/lilypond-git$ ./scripts/auxiliar/makelsr.p

PATCH: Countdown to 20120417

2012-04-15 Thread Colin Campbell
For 20:00 MDT Tuesday April 17 Critical Issue 2468 : augmentation dot of a moved rest is placed on a line - R6035053 Documentation: Issue 2478

Read error from 'delta' in Git for staging

2012-04-15 Thread James
Hello, I've noticed an problem on my git when I tried to checkout staging and then git pull -r. --snip-- james@jameslilydev2:~/lilypond-git$ git status # On branch master nothing to commit (working directory clean) james@jameslilydev2:~/lilypond-git$ git checkout staging error: failed to read obj

Re: Problem running makelsr.py

2012-04-15 Thread James
Graham, On 15 April 2012 22:24, Graham Percival wrote: > On Sun, Apr 15, 2012 at 10:18:41PM +0100, James wrote: >> james@jameslilydev2:~/lilypond-git$ ./scripts/auxiliar/makelsr.py >> Traceback (most recent call last): >>   File "./scripts/auxiliar/makelsr.py", line 56, in >>     TAGS = os.listd

Re: Problem running makelsr.py

2012-04-15 Thread Graham Percival
On Sun, Apr 15, 2012 at 10:18:41PM +0100, James wrote: > james@jameslilydev2:~/lilypond-git$ ./scripts/auxiliar/makelsr.py > Traceback (most recent call last): > File "./scripts/auxiliar/makelsr.py", line 56, in > TAGS = os.listdir (in_dir) > OSError: [Errno 2] No such file or directory: ''

Problem running makelsr.py

2012-04-15 Thread James
Hello, While trying to run makelsr.py at the top level of the tree I get this error. --snip-- james@jameslilydev2:~/lilypond-git$ ./scripts/auxiliar/makelsr.py Traceback (most recent call last): File "./scripts/auxiliar/makelsr.py", line 56, in TAGS = os.listdir (in_dir) OSError: [Errno 2

Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)

2012-04-15 Thread k-ohara5a5a
On 2012/04/15 16:45:54, Keith wrote: An improvement would be to round-to-larger Done, along with other cleanup following the similar function rest_collision_callback() http://codereview.appspot.com/6035053/ ___ lilypond-devel mailing list lilypond-

Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)

2012-04-15 Thread k-ohara5a5a
Reviewers: Graham Percival, dak, Message: On 2012/04/15 15:32:10, dak wrote: if max/min trigger, rint is applied to some rest_max_pos. It would > appear that it should rather apply only to the calculated mean. I want the final output to be an integral number of staff spaces, and rest_max_pos

Doc: CG - Update of Quick Start section (issue 6031053)

2012-04-15 Thread graham
LGTM; a few minor nitpicks. http://codereview.appspot.com/6031053/diff/1/Documentation/contributor/quick-start.itexi File Documentation/contributor/quick-start.itexi (left): http://codereview.appspot.com/6031053/diff/1/Documentation/contributor/quick-start.itexi#oldcode17 Documentation/contribu

Re: for_UP_and_DOWN

2012-04-15 Thread Graham Percival
On Sun, Apr 15, 2012 at 05:37:14PM +0200, David Kastrup wrote: > Graham Percival writes: > > I like that solution, but I'm iffy about relying on compiler > > support for elements of languages that are less than 10 years old. > > I was not suggesting we use it. I just pointed out that in future f

Re: for_UP_and_DOWN

2012-04-15 Thread David Kastrup
Graham Percival writes: > On Sun, Apr 15, 2012 at 05:16:07PM +0200, David Kastrup wrote: >> Actually, with option -std=c++0x GCC would accept >> >> for (Direction d : { UP, DOWN }) >> { >>... >> } >> >> and that would be readable enough without having to revert to macros. > > I like that so

Re: beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)

2012-04-15 Thread dak
On 2012/04/15 15:20:13, Graham Percival wrote: wow, looks very nice and simple. I vote for pushing immediately, but please wait for at least one other such vote (or a countdown). if max/min trigger, rint is applied to some rest_max_pos. It would appear that it should rather apply only to th

Re: for_UP_and_DOWN

2012-04-15 Thread Graham Percival
On Sun, Apr 15, 2012 at 05:16:07PM +0200, David Kastrup wrote: > Actually, with option -std=c++0x GCC would accept > > for (Direction d : { UP, DOWN }) > { >... > } > > and that would be readable enough without having to revert to macros. I like that solution, but I'm iffy about relying on c

beam.cc:pure-rest-collision-callback Place on staff lines; issue 2468 (issue 6035053)

2012-04-15 Thread graham
wow, looks very nice and simple. I vote for pushing immediately, but please wait for at least one other such vote (or a countdown). http://codereview.appspot.com/6035053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mai

Re: for_UP_and_DOWN

2012-04-15 Thread David Kastrup
Łukasz Czerwiński writes: > On 15 April 2012 16:49, David Kastrup wrote: > > Łukasz Czerwiński writes: > > I'd like to write code, that will make Lilypond better or easier > to be > > used > > > Not necessarily the same as "the C++ way". > > > Right :) No iter

Re: Web: Add more 'Concerts' to introduction.itexi (issue 6007048)

2012-04-15 Thread janek . lilypond
one typo http://codereview.appspot.com/6007048/diff/1/Documentation/web/introduction.itexi File Documentation/web/introduction.itexi (right): http://codereview.appspot.com/6007048/diff/1/Documentation/web/introduction.itexi#newcode509 Documentation/web/introduction.itexi:509: musical director.

Re: for_UP_and_DOWN

2012-04-15 Thread Graham Percival
On Sun, Apr 15, 2012 at 04:49:11PM +0200, David Kastrup wrote: > Łukasz Czerwiński writes: > > > The final suggestion depends on suggestions from all of you. If you > > find a better idea for (UP_and_DOWN(d)), I'll do so. If you find > > easier: for_UP_and_DOWN, it could be this. > > I find for_

Re: for_UP_and_DOWN

2012-04-15 Thread Łukasz Czerwiński
On 15 April 2012 16:49, David Kastrup wrote: > Łukasz Czerwiński writes: > > I'd like to write code, that will make Lilypond better or easier to be > > used > > Not necessarily the same as "the C++ way". > Right :) No iterators needed here :) > > and it's not my goal to fulfill my ambitions

Re: for_UP_and_DOWN

2012-04-15 Thread David Kastrup
Łukasz Czerwiński writes: > The final suggestion depends on suggestions from all of you. If you > find a better idea for (UP_and_DOWN(d)), I'll do so. If you find > easier: for_UP_and_DOWN, it could be this. I find for_UP_and_DOWN somewhat more consistent, but syntax-aware editors (and indenters

Re: for_UP_and_DOWN

2012-04-15 Thread Łukasz Czerwiński
On 14 April 2012 18:06, David Kastrup wrote: > > Is this supposed to declare d itself or not? Yes, it will declare d as a variable visible only in for loop (I'm using a new way of handling variables declared in for() clause - those variables will no longer be visible outside the for() loop). O

Re: Corrected comments and a function check_meshing_chords divided in two. (issue 5975054)

2012-04-15 Thread Łukasz Czerwiński
On 14 April 2012 21:12, wrote: > Splitting the function in two doesn't make it any easier for me to > understand, but I had figured it out before. > > On 2012/03/21 18:56:08, Milimetr88 wrote: > >> What I was taught at the university is to write short >> and simple functions that do only one thin

Re: Corrected comments and a function check_meshing_chords divided in two. (issue 5975054)

2012-04-15 Thread milimetr88
http://codereview.appspot.com/5975054/diff/1/lily/staff-symbol-referencer.cc File lily/staff-symbol-referencer.cc (right): http://codereview.appspot.com/5975054/diff/1/lily/staff-symbol-referencer.cc#newcode126 lily/staff-symbol-referencer.cc:126: * Returns vertical position of a symbol relative

Re: hideNotes in tablature

2012-04-15 Thread Phil Holmes
- Original Message - From: "Federico Bruni" To: "James" Cc: "Devel" ; Sent: Sunday, April 15, 2012 2:13 PM Subject: Re: hideNotes in tablature Il 15/04/2012 12:06, Federico Bruni ha scritto: Yes, issue 1459 is fixed. How can I change the label to fixed in the tracker? I guess I c

Re: hideNotes in tablature

2012-04-15 Thread Federico Bruni
Il 15/04/2012 12:06, Federico Bruni ha scritto: Yes, issue 1459 is fixed. How can I change the label to fixed in the tracker? I guess I can't: "Only project owners and committers can edit issue metadata. These users see additional fields when entering a new issue or adding a comment. The dro

Re: issues 2266 and 1721

2012-04-15 Thread Phil Holmes
- Original Message - From: "Jean-Charles Malahieude" To: "Phil Holmes" Cc: "Lily Bugs" ; "lilypond-devel" Sent: Saturday, April 14, 2012 5:46 PM Subject: Re: issues 2266 and 1721 It might have something to do with the way both glossary and snippet are built: I just noticed, on fre

Re: hideNotes in tablature

2012-04-15 Thread Federico Bruni
Il 15/04/2012 11:00, James ha scritto: Federico, it seems you have the ability (and knowledge) to create a tracker yourself so I suggest that if issue 1459 is fixed you change the label to fixed - someone else will verify - and then create a new tracker for the enhancement - whatever it is. Else

Re: hideNotes in tablature

2012-04-15 Thread James
Hello, On 15 April 2012 07:13, Federico Bruni wrote: > Il 14/04/2012 21:09, James ha scritto: > >> Hello, >> >> On 14 April 2012 15:47, Marc Hohl  wrote: >>> >>> Am 14.04.2012 11:57, schrieb Federico Bruni: Hi, I started using version 2.13.56 and I realized that this bug