Re: Fw: GDP Docs compilation FAILED (2012.02.14-01:39)

2012-02-13 Thread David Kastrup
Reinhold Kainhofer writes: [...] It is not clear where this mail hails from, which commands were used to get this error under which circumstances. -- David Kastrup ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman

Fw: GDP Docs compilation FAILED (2012.02.14-01:39)

2012-02-13 Thread Reinhold Kainhofer
- Ursprüngliche Mitteilung - Von: LilyPond Development Gesendet : Di., 14. Feb. 2012 01:39:05 CET An: reinh...@fam.tuwien.ac.at Betreff: GDP Docs compilation FAILED (2012.02.14-01:39) > Preprocessing graphical objects... > Calculating line breaks... > Drawing systems... > Writing header

Re: regenarating png from svg files

2012-02-13 Thread Francisco Vila
2012/2/13 Graham Percival : > ... that said, I see those files in lilypond-extra/pictures/, so > maybe they _are_ needed.  Hmm, the only way to find out is to try > reading make/website.make, and/or doing a few experiments. I'm afraid I will not have time for this before Thursday. Sorry. Next week

Re: regenarating png from svg files

2012-02-13 Thread Graham Percival
On Mon, Feb 13, 2012 at 02:46:01PM -0500, Julien Rioux wrote: > On Mon, Feb 13, 2012 at 2:38 PM, Francisco Vila wrote: > > Images should be pushed along other changes, and also to our branch. > > Graham has to authorize something afterwards for those to be visible. > > Forwarding to him. Not any

Re: git repository for osx-lilypond

2012-02-13 Thread Christian Hitz
Am 13.02.2012 um 13:36 schrieb Graham Percival: > On Sun, Feb 12, 2012 at 09:39:59PM +0100, Christian Hitz wrote: >> >> Am 11.02.2012 um 19:57 schrieb Carl Sorensen: >> >>> Yes, and I'm aware of that two-line fix. It gives ppc support, but I >>> think it also gives a bad version of LilyPond wh

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread Jean-Charles Malahieude
Le 13/02/2012 14:56, julien.ri...@gmail.com disait : Looks good, I just have a few suggestions to avoid clashing log file names and I wonder how this part of GOP 9 might be implemented down the road: "All other logfiles will go in the @file{build/logfiles/} directory." http://codereview.appspot

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread Graham Percival
On Mon, Feb 13, 2012 at 12:47:22PM +0100, David Kastrup wrote: > Graham Percival writes: > > > My rule of thumb is that if I don't understand something easily, > > then at least 50% of future lilypond contributors won't understand > > it either. > > eval is ugly and a little-travelled corner, an

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread David Kastrup
Graham Percival writes: > On Mon, Feb 13, 2012 at 11:05:56AM +, d...@gnu.org wrote: >> >> scripts/build/run-and-check.sh:2: eval $1 > $2 2>&1 >> >> Actually, it is totally basic shell scripting here. > > Well, apparently you don't need "basic" shell scripting for 7 > years of full-time linu

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread julien . rioux
Looks good, I just have a few suggestions to avoid clashing log file names and I wonder how this part of GOP 9 might be implemented down the road: "All other logfiles will go in the @file{build/logfiles/} directory." http://codereview.appspot.com/5650064/diff/5003/Documentation/GNUmakefile File

Re: Gets vertical skylines from grob stencils (issue 5626052)

2012-02-13 Thread m...@apollinemike.com
On Feb 13, 2012, at 5:41 AM, Joe Neeman wrote: > > On Thu, Feb 9, 2012 at 9:50 AM, m...@apollinemike.com > wrote: > On Feb 7, 2012, at 6:47 PM, m...@apollinemike.com wrote: > >> >> I did some experiments with caching that are up on: >> dev/skylines-cached > > Hey all, > > Fresh branch up at

Re: git repository for osx-lilypond

2012-02-13 Thread Graham Percival
On Sun, Feb 12, 2012 at 09:39:59PM +0100, Christian Hitz wrote: > > Am 11.02.2012 um 19:57 schrieb Carl Sorensen: > > > Yes, and I'm aware of that two-line fix. It gives ppc support, but I > > think it also gives a bad version of LilyPond when the About menu item is > > checked. I may be wrong

Re: some comments and complaints on the code (issue 5651069)

2012-02-13 Thread Han-Wen Nienhuys
On Mon, Feb 13, 2012 at 9:52 AM, David Kastrup wrote: >> I disagree.  Reading code the first time is hard, that is true, but >> unless anything surprising is happening, it does not deserve a >> comment. The more you read code, the easier it becomes, and think of >> this as you learning how to rea

Re: some comments and complaints on the code (issue 5651069)

2012-02-13 Thread David Kastrup
Han-Wen Nienhuys writes: > On Sat, Feb 11, 2012 at 8:31 AM, wrote: > >> Well, the main point of the comment is not describing parameters, but >> the function itself.  Believe me or not, we spent 10 minutes figuring >> out _what the hell_ are apes doing here and whether there are any >> bananas

Re: Google Summer of Code - Ideas List, please discuss

2012-02-13 Thread Han-Wen Nienhuys
On Sun, Feb 12, 2012 at 9:03 AM, Janek Warchoł wrote: > Hi all, > > SUMMARY: in order to participate in Google Summer of Code ($$$), we > need an Ideas List. I think the most interesting is probably #1 (grace note synchronization) and #2 (musicxml). Of those, I recommend #2 over #1, since the g

Re: some comments and complaints on the code (issue 5651069)

2012-02-13 Thread Han-Wen Nienhuys
On Sat, Feb 11, 2012 at 10:27 AM, wrote: > Yes - someone who knows this code :] Possibly one day someone will try > to refactor this code, what will mean that he understands it well. > For me it's really hard to understand whats going on here. Me and Janek > recently spent a couple of hours tryi

Re: some comments and complaints on the code (issue 5651069)

2012-02-13 Thread Han-Wen Nienhuys
On Sat, Feb 11, 2012 at 8:31 AM, wrote: >> somebody proposed a change, it was resisted because the do{} > > flip(d)!=UP idiom >> >> seemed simple enough to be acceptable. > > > It took us a while to figure out what's going on with the do{} > flip(d)!=UP thing. > If it was up to me, i'd just writ

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread Graham Percival
On Mon, Feb 13, 2012 at 11:05:56AM +, d...@gnu.org wrote: > > scripts/build/run-and-check.sh:2: eval $1 > $2 2>&1 > > Actually, it is totally basic shell scripting here. Well, apparently you don't need "basic" shell scripting for 7 years of full-time linux use and 4 years of macosx use, and

Re: some comments and complaints on the code (issue 5651069)

2012-02-13 Thread hanwenn
http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc#newcode587 lily/note-collision.cc:587: for_UP_and_DOWN (d) On 2012/02/13 11:33:48, hanwenn wrote: after reading some of th

Re: some comments and complaints on the code (issue 5651069)

2012-02-13 Thread hanwenn
http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc File lily/note-collision.cc (right): http://codereview.appspot.com/5651069/diff/1/lily/note-collision.cc#newcode536 lily/note-collision.cc:536: s[LEFT]--; // why LEFT and RIGHT instead of UP and DOWN? sometimes i liked to think

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread PhilEHolmes
Comments added describing eval line. http://codereview.appspot.com/5650064/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread Phil Holmes
- Original Message - From: To: ; ; ; Cc: ; Sent: Monday, February 13, 2012 10:53 AM Subject: Re: Final redirection of texi output (issue 5650064) LGTM http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh File scripts/build/run-and-check.sh (right): http

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread dak
http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh File scripts/build/run-and-check.sh (right): http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh#newcode2 scripts/build/run-and-check.sh:2: eval $1 > $2 2>&1 On 2012/02/13 10:53:44, Graham P

Re: Update lilygit.tcl (Issue 2092) (issue 5504092)

2012-02-13 Thread graham
LGTM http://codereview.appspot.com/5504092/diff/20001/scripts/auxiliar/lily-git.tcl File scripts/auxiliar/lily-git.tcl (right): http://codereview.appspot.com/5504092/diff/20001/scripts/auxiliar/lily-git.tcl#newcode248 scripts/auxiliar/lily-git.tcl:248: git remote add -t $originHead \ This shoul

Re: Final redirection of texi output (issue 5650064)

2012-02-13 Thread graham
LGTM http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh File scripts/build/run-and-check.sh (right): http://codereview.appspot.com/5650064/diff/4001/scripts/build/run-and-check.sh#newcode2 scripts/build/run-and-check.sh:2: eval $1 > $2 2>&1 I know this has already be