Web: Added 'Ripple' to easier-editing section (issue 5507044)

2011-12-31 Thread graham
LGTM, please push directly to staging. http://codereview.appspot.com/5507044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Can GUB hang?

2011-12-31 Thread Graham Percival
On Sun, Jan 01, 2012 at 03:18:53AM +, Carl Sorensen wrote: > building package: darwin-ppc::lilypond > *** Stage: compile (lilypond, darwin-ppc) > > and now nothing seems to be happening. It's staying here forever, no disk > activity, no change in memory. Well, it might be that the build sy

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2011-12-31 Thread Carl . D . Sorensen
http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely#newcode1954 Documentation/notation/rhythms.itely:1954: The properties of a beam a

Re: Doc: NR added @knownissue for beam properties (issue 5504100)

2011-12-31 Thread k-ohara5a5a
LGTM http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely File Documentation/notation/rhythms.itely (right): http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.itely#newcode1903 Documentation/notation/rhythms.itely:1903: @code{@bs{}autoBeamO

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2011-12-31 Thread Carl . D . Sorensen
LGTM Carl http://codereview.appspot.com/5505090/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GUB help

2011-12-31 Thread Carl Sorensen
Colin Campbell shaw.ca> writes: > > I'm still learning how to control GUB, Carl, so the successful build on > 10.04 was simply bin/gub lilypond-installer and it produced a single .sh > in /uploads. Thanks. I just wanted to be able to duplicate your work. Right now, I have succeeded in finis

Re: lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2011-12-31 Thread k-ohara5a5a
Works nicely. Showing the input location will probably be very helpful. We probably want to remove the similar message from lily/misc.cc, because both message together are very noisy. I wish I could think of a way to check the input with a canned regular expression like

Doc: NR added @knownissue for beam properties (issue 5504100)

2011-12-31 Thread Carl . D . Sorensen
LGTM. I have some recommendations, but I won't hold up approval for them. Just for your consideration. Thanks for doing this! I was going to get to it, but I've been struggling with getting GUB going. Thanks, Carl http://codereview.appspot.com/5504100/diff/1/Documentation/notation/rhythms.

Re: GUB help

2011-12-31 Thread Colin Campbell
On 11-12-31 10:52 AM, Carl Sorensen wrote: Colin Campbell shaw.ca> writes: For additional data points: I've built an Ubuntu 10.04 VM and used GUB to build 2.15.24, which seems to work correctly, in that it produced an installer which in turn gave me a copy of lilypond that can compile .ly and

Re: Doc: Usage --include option layout consistency (issue 5504084)

2011-12-31 Thread pkx166h
Reviewers: Graham Percival, Message: Sat, 31 Dec 2011 23:03:17 + (23:03 +) commit 9605455437b9daaab6b32c110768b338d15a0451 Description: Doc: Usage --include option layout consistency Tracker 2135 Made description of arguments consistent with others, so also had to swap two pa

Re: Doc: Usage --include option layout consistency (issue 5504084)

2011-12-31 Thread graham
LGTM, please push directly to staging. http://codereview.appspot.com/5504084/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Patchy email

2011-12-31 Thread Graham Percival
On Sat, Dec 31, 2011 at 11:27:38AM +0100, David Kastrup wrote: > My guess is that two incantations of Patchy were at work here, and one > of them copied a tested staging to master while the other one was still > working with older material. There's only one version of Patchy doing the staging stuf

lexer.ll: Warn about non-UTF-8 characters (issue 5505090)

2011-12-31 Thread lemzwerg
LGTM. http://codereview.appspot.com/5505090/diff/1/lily/lexer.ll File lily/lexer.ll (right): http://codereview.appspot.com/5505090/diff/1/lily/lexer.ll#newcode1009 lily/lexer.ll:1009: case 0xc2: Wouldn't it be more effective to create an array of 128 bytes (for 0x80-0xFF) which maps `p[i]' to t

Re: GUB help

2011-12-31 Thread Carl Sorensen
Colin Campbell shaw.ca> writes: > For additional data points: I've built an Ubuntu 10.04 VM and used GUB > to build 2.15.24, which seems to work correctly, in that it produced an > installer which in turn gave me a copy of lilypond that can compile .ly > and which reports itself as version 2.1

Re: Patchy email

2011-12-31 Thread Francisco Vila
2011/12/31 Carl Sorensen : > OK, so the final answer is: > Francisco, everything is correct in your setup and your operation. > Patchy's email was generated in error. > There are no problems with master or staging. > Thanks, > Carl Pheew...! (again). Will Patxi and I be friends someday? I doubt it

RE: Patchy email

2011-12-31 Thread Carl Sorensen
OK, so the final answer is: Francisco, everything is correct in your setup and your operation. Patchy's email was generated in error. There are no problems with master or staging. Thanks, Carl ___ lilypond-devel mailing list lilypond-devel@gnu.org h

Sketch of not remaking html files (issue 5498093)

2011-12-31 Thread PhilEHolmes
Reviewers: percivall, Message: Please review Description: Should probably have associated this with http://code.google.com/p/lilypond/issues/detail?id=2028. It's an attempt to stop make doc recreating the whole of build/out-www/offline-root/ every time it's run, whether any of the files there h

Re: Removes ugly side bars from learning (issue 5498089)

2011-12-31 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; ; ; ; Sent: Saturday, December 31, 2011 1:40 AM Subject: Re: Removes ugly side bars from learning (issue 5498089) I'd be fine with distinguishing between "quick url box" and "lilypond material box". I'd like

Re: Encoding of LilyPond console output

2011-12-31 Thread David Kastrup
Wilbert Berendsen writes: > Everything boils down to the question in which encoding the 8bit > console output of LilyPond is presented. I was always assuming that > this was UTF-8, which worked correctly on Linux. I.e. both > filenameswith accented letters and translated messages (such as > Frenc

Encoding of LilyPond console output

2011-12-31 Thread Wilbert Berendsen
Hi all, When dealing with files and directories with accented letters (non-ASCII filenames) I came across a number of small issues, which I need to handle correctly in Frescobaldi, my LilyPond compagnion. Everything boils down to the question in which encoding the 8bit console output of LilyPond

Re: Doc: Usage added @knownissue for LaTeX (issue 5492075)

2011-12-31 Thread pkx166h
Reviewers: dak, Message: On 2011/12/20 10:07:55, dak wrote: http://codereview.appspot.com/5492075/diff/1/Documentation/usage/lilypond-book.itely File Documentation/usage/lilypond-book.itely (right): http://codereview.appspot.com/5492075/diff/1/Documentation/usage/lilypond-book.itely#newcode9

Re: Patchy email

2011-12-31 Thread Francisco Vila
2011/12/31 David Kastrup : > Carl Sorensen writes: >> Francisco merged translation with staging, and apparently also with >> master. (The commit message says merge with staging, but the commit is >> on master and is the parent of staging. >> >> I suspect that we have not yet worked out the right w

Re: Update lilygit.tcl (Issue 2092) (issue 5504092)

2011-12-31 Thread dak
The problem is not merges. The problem is unintentional merges. merges _from_ staging (or origin/staging) are usually a mistake. http://codereview.appspot.com/5504092/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailm

Re: Patchy email

2011-12-31 Thread David Kastrup
Carl Sorensen writes: > >> From: lilypond-devel-bounces+c_sorensen=byu@gnu.org [lilypond-devel- >> bounces+c_sorensen=byu@gnu.org] on behalf of >> lilypond.patchy.gra...@gmail.com >> [lilypond.patchy.gra...@gmail.com] >> Sent: Friday, December 30,

Re: Patchy email

2011-12-31 Thread David Kastrup
Francisco Vila writes: > 2011/12/31 Carl Sorensen : >> I suspect that we gave you commands that set it so your local staging >> branch is tracking origin/master, rather than origin/staging.  So *for >> you*, staging is the same branch as origin/master.  And I'm trying to >> figure out how to diag

Re: Patchy email

2011-12-31 Thread David Kastrup
Francisco Vila writes: > 2011/12/31 Carl Sorensen : >>> Begin LilyPond compile, commit: 2f25894efd8ad242b233d5a1d07afcfa087ebab2 >>> >>> *** FAILED STEP *** >>> >>>         merge from staging >>> >>>         maybe somebody pushed a commit directly to master? >> >> Francisco merged translation wit