Re: Fixes footnote automatic numbering. (issue 4877041)

Passes make and make check looks ok, I get something on page ../regression/page-turn-page-breaking.log and I'm attaching the graphviz.log output (as I don't know if it is significant). But nothing else pops up. See http://code.google.com/p/lilypond/issues/detail?id=1791#c5 (ignore the pdf I mist

Re: Fix a few lilypond-book bugs on windows (Issue 1815). (issue 5183042)

On Tue, Oct 4, 2011 at 3:22 PM, wrote: > > ... There are no hard links that I am aware of. > > http://msdn.microsoft.com/en-us/library/windows/desktop/aa365006(v=vs.85).aspx ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/ma

PATCH: Countdown to 20111006

For 22:00 MDT Thursday October 6th Issue 1952 : Patch: Sketch for broken beams with consistent slopes - R 4961041 Issue 1852 : manuals nee

Re: Fix a few lilypond-book bugs on windows (Issue 1815). (issue 5183042)

Reviewers: Reinhold, Message: Of course you know the code better, so please investigate. I did not understand why we keep two points to the same file, but if it is needed, support for windows will require copying the files. There are no hard links that I am aware of. http://codereview.appspot.c

Fix a few lilypond-book bugs on windows (Issue 1815). (issue 5183042)

http://codereview.appspot.com/5183042/diff/1/python/book_snippets.py File python/book_snippets.py (right): http://codereview.appspot.com/5183042/diff/1/python/book_snippets.py#newcode643 python/book_snippets.py:643: os.rename (src, dst) Doesn't this REMOVE the src? os.link creates a link at dst,

Re: Sketch for broken beams with consistent slopes (issue 4961041)

On Tue, Oct 4, 2011 at 10:30 AM, Mike Solomon wrote: > On Oct 4, 2011, at 3:26 PM, Han-Wen Nienhuys wrote: > >> You skipped the cosmetic patch that folds together the (SCM, SCM) >> callbacks into one big quanting callback. >> > > You and I have different definitions of cosmetics.  Living with a Fr

Re: Sketch for broken beams with consistent slopes (issue 4961041)

On Oct 4, 2011, at 3:26 PM, Han-Wen Nienhuys wrote: > You skipped the cosmetic patch that folds together the (SCM, SCM) > callbacks into one big quanting callback. > > I assume this is the real patch, > > + if (consistent_broken_slope_) > +{ > + Interval normalized_endpoints = robust_s

Re: New git cl :: rebase patches

Am Dienstag, 4. Oktober 2011, 16:21:50 schrieb m...@apollinemike.com: > On Oct 4, 2011, at 4:08 PM, Julien Rioux wrote: > > I guess most of us don't have any privilege to change this status on > > googlepage. Moreover, it seems to me that Mike's use-case was simply to > > store his patch somewhere

Re: New git cl :: rebase patches

On Oct 4, 2011, at 4:08 PM, Julien Rioux wrote: > On 04/10/2011 3:04 PM, Colin Campbell wrote: >> On 11-10-04 02:48 AM, m...@apollinemike.com wrote: >>> Hey all, >>> >>> I uploaded a couple patches to Rietveld this morning just to have >>> clean diffs with current master (my bazillion commits on

Re: New git cl :: rebase patches

On 04/10/2011 3:04 PM, Colin Campbell wrote: On 11-10-04 02:48 AM, m...@apollinemike.com wrote: Hey all, I uploaded a couple patches to Rietveld this morning just to have clean diffs with current master (my bazillion commits on my local branch won't apply to current master anymore). I then down

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

AFAIK, texi2* simply include the first file found in the include pathes. So if Documentation/ is given first, then Documentation/macros.itexi is used, if Documentation/de/ is given before Documentation/, then Documentation/de/macros.itexi is used... Thanks. If I tracked it right then Documen

Re: Sketch for broken beams with consistent slopes (issue 4961041)

On Oct 4, 2011, at 3:26 PM, Han-Wen Nienhuys wrote: > You skipped the cosmetic patch that folds together the (SCM, SCM) > callbacks into one big quanting callback. > You and I have different definitions of cosmetics. Living with a French woman, I am constantly told that I know nothing about co

Re: Sketch for broken beams with consistent slopes (issue 4961041)

You skipped the cosmetic patch that folds together the (SCM, SCM) callbacks into one big quanting callback. I assume this is the real patch, + if (consistent_broken_slope_) +{ + Interval normalized_endpoints = robust_scm2interval (beam_->get_property ("normalized-endpoints"), Interval (

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

http://codereview.appspot.com/5131045/diff/5001/stepmake/stepmake/texinfo-vars.make File stepmake/stepmake/texinfo-vars.make (right): http://codereview.appspot.com/5131045/diff/5001/stepmake/stepmake/texinfo-vars.make#newcode15 stepmake/stepmake/texinfo-vars.make:15: ) On 2011/10/04 13:04:44, Ju

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

Sure, when there are no more comments from reviewers I will proceed to modify the patch and add the comments into the makefiles themselves. Any more files need dependencies besides .tely, .texi and .itexi? http://codereview.appspot.com/5131045/diff/5001/stepmake/stepmake/texinfo-vars.make File

Re: New git cl :: rebase patches

On 11-10-04 02:48 AM, m...@apollinemike.com wrote: Hey all, I uploaded a couple patches to Rietveld this morning just to have clean diffs with current master (my bazillion commits on my local branch won't apply to current master anymore). I then download this diff and run the regtests. Howe

Re: git-cl upload mimetypes fixed (issue 1491)

On Sun, Oct 02, 2011 at 11:33:05PM +0100, Trevor Daniels wrote: > > $ git clone https://github.com/gperciva/git-cl.git > Initialized empty Git repository in c:/Users/Trevor/git-cl/.git/ > Cannot get remote repository information. > Perhaps git-update-server-info needs to be run there? I've added

Re: Glyphs for Kievan Notation (issue 4951062)

You can't solve the Kievan bar line problem without calculate every dot position. I made a pure MetaFont version of the Kievan bar line: fet_beginchar ("kievan end of piece (slash)", "barline.kievan"); % this draws the end of piece figure % this figure is placed at the end of the

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

tested and looks great. I'd like to re-iterate the request to move the rietveld comments into actual comments in the makefiles; they were extremely helpful for me in reading the patch, so I'd like them to be stored in git. http://codereview.appspot.com/5131045/diff/5001/stepmake/stepmake/texinf

Re: Sketch for broken beams with consistent slopes (issue 4961041)

On Oct 3, 2011, at 8:50 PM, Mike Solomon wrote: > On Oct 3, 2011, at 6:53 AM, hanw...@gmail.com wrote: > >> i know it's annoying, but could you separate out the cosmetics (adding _ >> ) to members from the rest of this change? The cosmetic changes make it >> difficult to see the essence of what

Re: Grob::vertical_less and DOWN/UP

"m...@apollinemike.com" writes: > I think that it'd be good to scrub this inconsistency from the code > base such that "lower on the page" always means "numerically lower" > (so the contrabass, for example, would be the 0th vertical axis group > in an elements list). Thoughts? In the input, sta

Re: New git cl :: rebase patches

On Tue, Oct 04, 2011 at 10:48:57AM +0200, m...@apollinemike.com wrote: > I think that the new git cl should ask the uploader > if she wants a patch to be labeled patch new instead of doing it > automatically so that James doesn't run regtests on patches that > could be buggy. What about using gi

New git cl :: rebase patches

Hey all, I uploaded a couple patches to Rietveld this morning just to have clean diffs with current master (my bazillion commits on my local branch won't apply to current master anymore). I then download this diff and run the regtests. However, with the new git cl, James sees patch_new and al

Re: Grob::vertical_less and DOWN/UP

> I think that it'd be good to scrub this inconsistency from the code > base such that "lower on the page" always means "numerically lower" > (so the contrabass, for example, would be the 0th vertical axis group > in an elements list). Thoughts? +1, assuming that it is orthogonal with the rest o