PATCH: Countdown to 22:00 MDT 20110916

2011-09-14 Thread Colin Campbell
A small batch to round out Programmers Day: Issue 1839 : Improves some parmesan noteheads. - R 4639065 Issue 1883 : change longas simila

Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-14 Thread David Kastrup
Reinhold Kainhofer writes: > Am Thursday, 15. September 2011, 02:33:59 schrieb David Kastrup: >> Reinhold Kainhofer writes: >> > We never even really have a tree to traverse. The elements are only >> > created by interpret-markup, which will already cause the infinite >> > loop. >> >> I don't g

Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-14 Thread Reinhold Kainhofer
Am Thursday, 15. September 2011, 02:33:59 schrieb David Kastrup: > Reinhold Kainhofer writes: > > We never even really have a tree to traverse. The elements are only > > created by interpret-markup, which will already cause the infinite > > loop. > > I don't get your point. Whether the tree is e

Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-14 Thread David Kastrup
Reinhold Kainhofer writes: > Am Thursday, 15. September 2011, 01:50:34 schrieb David Kastrup: >> reinhold.kainho...@gmail.com writes: >> > On 2011/09/13 18:53:55, hanwenn wrote: >> >> have you thought of fixing this generically instead? >> >> >> >> You could the hare/tortoise algorithm to detect

Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-14 Thread Reinhold Kainhofer
Am Thursday, 15. September 2011, 01:50:34 schrieb David Kastrup: > reinhold.kainho...@gmail.com writes: > > On 2011/09/13 18:53:55, hanwenn wrote: > >> have you thought of fixing this generically instead? > >> > >> You could the hare/tortoise algorithm to detect cycles in any markup, > >> and coul

Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-14 Thread David Kastrup
reinhold.kainho...@gmail.com writes: > On 2011/09/13 18:53:55, hanwenn wrote: >> have you thought of fixing this generically instead? > >> You could the hare/tortoise algorithm to detect cycles in any markup, >> and could run that on the entry point (not the recursive function) >> for evaluating m

Re: GOP-PROP 10: scheme indentation

2011-09-14 Thread Carl Sorensen
On 9/14/11 4:31 PM, "Graham Percival" wrote: > There's been no action on this for a few weeks. I'm starting to > wonder if we should abandon this proposal and try bringing it back > in a few months. Why? The only outstanding issue is that the else indentation is not the same as Emacs, but Neil

Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-14 Thread reinhold . kainhofer
On 2011/09/13 18:53:55, hanwenn wrote: have you thought of fixing this generically instead? You could the hare/tortoise algorithm to detect cycles in any markup, and could run that on the entry point (not the recursive function) for evaluating markups to stencils. Actually, I fail to see

GOP-PROP 11: git repositories (probable decision)

2011-09-14 Thread Graham Percival
I've made a few clarifications to the original proposal, but nothing substantial is changed. http://lilypond.org/~graham/gop/gop_11.html ** Proposal summary Our source code hosting is confused: some branches of lilypond savannah are confusing and should removed, while other parts of our source c

GOP-PROP 10: scheme indentation

2011-09-14 Thread Graham Percival
There's been no action on this for a few weeks. I'm starting to wonder if we should abandon this proposal and try bringing it back in a few months. http://lilypond.org/~graham/gop/gop_10.html ** Proposal summary Speaking academically, scheme code style is a “solved problem”. Let’s pick one of t

Re: Fix 380: Try to auto-detect cyclic references in header fields (issue 4951073)

2011-09-14 Thread reinhold . kainhofer
Reviewers: J_lowe, hanwenn, joeneeman, Message: On 2011/09/13 19:46:52, joeneeman wrote: http://codereview.appspot.com/4951073/diff/3001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): http://codereview.appspot.com/4951073/diff/3001/scm/define-markup-commands.scm#

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-09-14 Thread n . puttock
http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly File input/regression/staff-ledger-positions.ly (right): http://codereview.appspot.com/4974075/diff/8001/input/regression/staff-ledger-positions.ly#newcode4 input/regression/staff-ledger-positions.ly:4: by

Re: change longas similarly to how breves were changed (issue 4962072)

2011-09-14 Thread pkx166h
passes make and reg tests - there are three reg tests that show up but nothing significant. See http://code.google.com/p/lilypond/issues/detail?id=1883#c1 http://codereview.appspot.com/4962072/ ___ lilypond-devel mailing list lilypond-devel@gnu.org ht

Re: Add support for custom ledger positions, using two new staff-symbol properties (issue 4974075)

2011-09-14 Thread pkx166h
Passes make and reg tests http://codereview.appspot.com/4974075/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: adding doc strings for \...DashPattern and \harmonicBy... (1887) (issue 5019042)

2011-09-14 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/5019042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improves some parmesan noteheads. (issue 4639065)

2011-09-14 Thread benko . pal
hi Bertrand, What has been done for Petrucci/mensural/neomensural: * Stems centered around the attachment point. * Attachment point lowered. * Brevis/longa/maxima pointing downward. * Use the left-stemmed longa in ligatures. exactly what is this last one? p http://codereview.appspot.com/4639

Re: GOP-PROP 12: keep master in ready-to-release state

2011-09-14 Thread Graham Percival
On Wed, Sep 14, 2011 at 04:22:47AM +, Keith OHara wrote: > Graham Percival percival-music.ca> writes: > > > In addition, modifications which change a lot of output (such as > > fonts or spacing tweaks) could be “saved up” and applied in a > > special release which only contains those. > > Th

Re: Patch: adding doc strings for \...DashPattern and \harmonicBy...

2011-09-14 Thread Marc Hohl
Am 14.09.2011 20:42, schrieb Janek Warchoł: 2011/9/14 Marc Hohl: Hello list, while working on issue 1135 (which is closed now!) I found out that some functions still lack a proper doc string. Attached is a patch which adds the missing (_i ...) to four of them. Some functions concerning the str

Re: Fix 456: Also check for laissez-vibrer events attached to single heads inside a chord (issue 4969069)

2011-09-14 Thread n . puttock
LGTM. http://codereview.appspot.com/4969069/diff/2001/input/regression/laissez-vibrer-chords.ly File input/regression/laissez-vibrer-chords.ly (right): http://codereview.appspot.com/4969069/diff/2001/input/regression/laissez-vibrer-chords.ly#newcode1 input/regression/laissez-vibrer-chords.ly:1:

Re: Uses langdefs.py to create language list forcreate-weblinks-itexi.py (issue 4951047)

2011-09-14 Thread Graham Percival
On Wed, Sep 14, 2011 at 02:31:31PM +0100, Phil Holmes wrote: > In website.make we currently have: > > WEB_LANGS = cs de es fr hu it ja nl zh > > which we want to change to something like > > WEB_LANGS = $(shell $(PYTHON) $(top-src-dir)/python/langdefs.py) ah, thanks. I'd completely forgotten t

Re: Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047)

2011-09-14 Thread percival . music . ca
LGTM, go ahead and push. http://codereview.appspot.com/4951047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-14 Thread n . puttock
http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly File input/regression/kievan-notes.ly (right): http://codereview.appspot.com/4951062/diff/11001/input/regression/kievan-notes.ly#newcode11 input/regression/kievan-notes.ly:11: \override NoteHead #'stencil = #ly:tex

Re: Doc: adding doc strings for \...DashPattern and \harmonicBy... (1887) (issue 5019042)

2011-09-14 Thread percival . music . ca
LGTM http://codereview.appspot.com/5019042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improves some parmesan noteheads. (issue 4639065)

2011-09-14 Thread Benkő Pál
2011/9/14 Francisco Vila : >> have you seen the facsimiles in the message >> http://lists.gnu.org/archive/html/lilypond-devel/2010-12/msg00398.html >> ? > > The attached file in that message must be a joke! aargh, my bad. as I look at it now, it's actually a gzip-compressed tar archive, you can

Re: Patch: adding doc strings for \...DashPattern and \harmonicBy...

2011-09-14 Thread Janek Warchoł
2011/9/14 Marc Hohl : > Hello list, > > while working on issue 1135 (which is closed now!) I found out > that some functions still lack a proper doc string. > Attached is a patch which adds the missing (_i ...) to four of them. > > Some functions concerning the string tunings are still not document

Doc: adding doc strings for \...DashPattern and \harmonicBy... (1887) (issue 5019042)

2011-09-14 Thread janek . lilypond
Reviewers: , Message: By Marc Hohl http://code.google.com/p/lilypond/issues/detail?id=1887 Description: Doc: adding doc strings for \...DashPattern and \harmonicBy... Please review this at http://codereview.appspot.com/5019042/ Affected files: M ly/music-functions-init.ly M ly/property-ini

Patch: adding doc strings for \...DashPattern and \harmonicBy...

2011-09-14 Thread Marc Hohl
Hello list, while working on issue 1135 (which is closed now!) I found out that some functions still lack a proper doc string. Attached is a patch which adds the missing (_i ...) to four of them. Some functions concerning the string tunings are still not documented; IIUC, David Katrup has posted

Re: Improves some parmesan noteheads. (issue 4639065)

2011-09-14 Thread Francisco Vila
2011/9/14 Benkő Pál : > hi all, > > the patch is ok from my point of view.  a minor question: the only change > in mensural-ligatures.ly is the version bump - is that needed? > >>> Do you know what neomensural and mensural styles are inspired of? > > I believe it uses the shapes of noteheads found

Re: Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047)

2011-09-14 Thread PhilEHolmes
I hope the final version of the patch that removes language definitions from website.make and uses langdefs.py for all language definition. http://codereview.appspot.com/4951047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.

Re: Uses langdefs.py to create language list forcreate-weblinks-itexi.py (issue 4951047)

2011-09-14 Thread Phil Holmes
- Original Message - From: "Graham Percival" To: "Phil Holmes" Cc: ; ; Sent: Tuesday, September 13, 2011 7:03 PM Subject: Re: Uses langdefs.py to create language list forcreate-weblinks-itexi.py (issue 4951047) On Tue, Sep 13, 2011 at 04:42:16PM +0100, Phil Holmes wrote: The pr

Re: PATCH: 48-hour countdown to 20110914

2011-09-14 Thread Peekay Ex
Janek, 2011/9/14 Janek Warchoł : > 2011/9/13 Peekay Ex : >> >> 2011/9/13 Janek Warchoł : >> >>> 2011/9/13 Peekay Ex : On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell wrote: > countdown for 22:00 MDT Wednesday, September 14 > Issue 1873: Added glyphs for Kievan Notation - R 49510

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-14 Thread Werner LEMBERG
> what do you mean by "let's treat this as a temporary solution"? Do > you mean that: 1) it can be pushed in this state so that Aleksandr > can proceed on getting Kievan notation to work (by adding > KievanStaff, KievanVoice and so on), but when support for Kievan > notation is established, the m

Re: Glyphs for Kievan Notation (issue 4951062)

2011-09-14 Thread Janek Warchoł
Werner, 2011/9/9 : > I'm not really happy with the MF code: It looks like a direct > translation of PostScript points into MF points. This definitely works > but is quite clumsy. If you look at the design of other LilyPond > glyphs, you can see that all coordinates rely on meta-parameters which

Re: GOP-PROP 12: keep master in ready-to-release state

2011-09-14 Thread Reinhold Kainhofer
Am Wednesday, 14. September 2011, 11:26:11 schrieb Janek Warchoł: > 2011/9/14 Graham Percival : > >> >This could reduce the pain of git master getting broken from time > >> >to time – if everybody worked on separate branches, and those > >> >branches were only pulled to master when it compiled corr

Re: PATCH: 48-hour countdown to 20110914

2011-09-14 Thread Janek Warchoł
2011/9/13 Peekay Ex : > > 2011/9/13 Janek Warchoł : > >> 2011/9/13 Peekay Ex : >>> >>> On Tue, Sep 13, 2011 at 4:56 AM, Colin Campbell wrote: countdown for 22:00 MDT Wednesday, September 14 Issue 1873: Added glyphs for Kievan Notation - R 4951062 >>> >>> This has been set back to review

Re: GOP-PROP 12: keep master in ready-to-release state

2011-09-14 Thread Janek Warchoł
2011/9/14 Graham Percival : >> >This could reduce the pain of git master getting broken from time >> >to time – if everybody worked on separate branches, and those >> >branches were only pulled to master when it compiled correctly, >> >then master would never be broken! In theory, at least. >> >> I