On Aug 24, 2011, at 12:09 AM, Janek Warchoł wrote:
> 2011/8/16 Han-Wen Nienhuys :
>> #2) sounds neat, but maybe Janek (who has spent some time messing
>> around with flags) wants to weigh in.
>
> As i've said in a private mail to Mike, i don't have anything against doing
> so.
>
> Mike, i under
reinhold.kainho...@gmail.com writes:
> Reviewers: ,
>
> Message:
> This patch fixes a memleak: Some temporary skylines were never
> deleted...
> Please review
>
> Description:
> Fix memleak: temporary skyline objects for systems were never deleted
>
> Please review this at http://codereview.appspo
k...@aspodata.se (Karl Hammar) writes:
> Reinhold:
>> Am Tuesday, 23. August 2011, 22:30:24 schrieb David Kastrup:
> ...
>> > Is this used anywhere?
>> A git grep didn't show any usage, but maybe I'm missing something.
>
> Make does not complain about this patch (on my box).
> - static string re
Janek Warchoł writes:
> LGTM.
> (sorry that i don't have anything more constructive to say)
I am working on the code (in C++) right now. Since I'll be driving to
an accordionist meeting tomorrow lasting till Sunday and since I am away
work-related for the following three days, this will still t
Pushed as 5f81429c8f8263eef85b4f7881d243cb9722e971
Details of how to push will be in a seperate patch.
http://codereview.appspot.com/4898058/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reinhold:
> Am Tuesday, 23. August 2011, 22:30:24 schrieb David Kastrup:
...
> > Is this used anywhere?
> A git grep didn't show any usage, but maybe I'm missing something.
Make does not complain about this patch (on my box).
$ git diff |cat
diff --git a/flower/include/string-convert.hh b/flower/
This one is very nice!
I vote for deleting \fermataMarkup altogether.
Will it be also possible to deprecate MultiMeasureRestText? It's
confusing too.
Added a tracker issue:
http://code.google.com/p/lilypond/issues/detail?id=1833
thanks, Neil!
Janek
http://codereview.appspot.com/4672059/
_
2011/8/9 Janek Warchoł :
> 2011/8/7 Bertrand Bordage :
>>> I've done a very dirty test which showed that a properly set glyph
>>> bounding box solves this perfectly (see in the attachment how the
>>> bounding box should change).
>>> However, there is a problem. Currently bounding box is set by
>>>
http://codereview.appspot.com/4931043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
2011/8/16 Han-Wen Nienhuys :
> #2) sounds neat, but maybe Janek (who has spent some time messing
> around with flags) wants to weigh in.
As i've said in a private mail to Mike, i don't have anything against doing so.
Mike, i understand that your patch changes some beams. I'd like to
check what e
2011/8/19 Carl Sorensen :
> On 8/19/11 10:15 AM, "David Kastrup" wrote:
>>
>> Up to now, \once \revert is not really documented nor used. I have not
>> yet dug through the existing code in order to figure out what it does if
>> anything (most likely ignoring \once, but not sure).
>
> I would expe
Am Tuesday, 23. August 2011, 22:30:24 schrieb David Kastrup:
> This function in the flower library relies on memrev which is broken
> (off-by-one error).
hehe, nice catch. It should use
unsigned char *right = byte + length - 1;
shoudln't it?
> Is this used anywhere?
A git grep didn't show any
Once again i'm reviving an old thread, but since i was involved in
discussions with David before i disappeared, i'd like to give my
feedback on this.
2011/8/14 David Kastrup :
> there are the proposed semantics. At least for the
> latter, I would want to get some sort of feedback.
>
> The semanti
On Tue, Aug 23, 2011 at 09:32:50PM +0100, Phil Holmes wrote:
> - Original Message - From: "Phil Holmes"
>
> >- Original Message - From: "Graham Percival"
> >
> >To: "Phil Holmes"
>
> >>This is **not** the website. That's a copy of the "web" manual,
> >>but it's built with a comp
Reviewers: ,
Message:
This patch fixes a memleak: Some temporary skylines were never
deleted...
Please review
Description:
Fix memleak: temporary skyline objects for systems were never deleted
Please review this at http://codereview.appspot.com/4923048/
Affected files:
M lily/skyline.cc
In
- Original Message -
From: "Phil Holmes"
To: "Graham Percival"
Cc: ; ;
;
Sent: Tuesday, August 23, 2011 9:15 PM
Subject: Re: Adds a site search to website and improves doc
search(issue4894053)
- Original Message -
From: "Graham Percival"
To: "Phil Holmes"
This is *
This function in the flower library relies on memrev which is broken
(off-by-one error).
Is this used anywhere?
--
David Kastrup
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
- Original Message -
From: "Graham Percival"
To: "Phil Holmes"
Cc: "Janek Warchol" ;
; ;
;
Sent: Tuesday, August 23, 2011 7:04 PM
Subject: Re: Adds a site search to website and improves doc search
(issue4894053)
On Tue, Aug 23, 2011 at 03:32:40PM +0100, Phil Holmes wrote:
On 8/23/11 12:21 PM, "ianhuli...@gmail.com" wrote:
> LGTM
>
> Maybe we should have some GOP rules for C++ about this?
> "Only have multiple exit points from routines if you absolutely have to.
Multiple exit points is a standard idiom of the LilyPond code. Basically,
the idiom is "If this routi
On Tue, Aug 23, 2011 at 06:21:00PM +, ianhuli...@gmail.com wrote:
> Maybe we should have some GOP rules for C++ about this?
> "Only have multiple exit points from routines if you absolutely have to.
> Make sure any output parameters are declared and initialized at the top
> of a routine so that
LGTM
Maybe we should have some GOP rules for C++ about this?
"Only have multiple exit points from routines if you absolutely have to.
Make sure any output parameters are declared and initialized at the top
of a routine so that however a routine exits, they are left in a defined
state"
Ian
http:/
On Tue, Aug 23, 2011 at 11:38:10AM +, reinhold.kainho...@gmail.com wrote:
> On 2011/08/22 23:55:52, Graham Percival wrote:
> >On 2011/08/22 12:30:15, Reinhold wrote:
> >> Now, it's clear that lilypond produces .pdf files that are about
> 0.5-1 mm too
> >> wide. So we now have the proper way to
On Tue, Aug 23, 2011 at 03:32:40PM +0100, Phil Holmes wrote:
> - Original Message - From: "Graham Percival"
>
> >Partial instructions are buried in
> >http://code.google.com/p/lilypond/issues/detail?id=1663
> >It would be nice if those instructions could migrate to the CG.
>
> How about t
On Tue, Aug 23, 2011 at 11:14:06AM +, reinhold.kainho...@gmail.com wrote:
> Fix uninitialized variables when Source_file::get_counts returns early
> due to !contains (pos_str0)
LGTM
Cheers,
- Graham
___
lilypond-devel mailing list
lilypond-devel@gn
- Original Message -
From: "Reinhold Kainhofer"
To: "Colin Campbell"
Cc: "Phil Holmes" ;
Sent: Tuesday, August 23, 2011 2:59 PM
Subject: Re: Make doc is broken
Am Dienstag, 23. August 2011, 05:37:48 schrieb Colin Campbell:
HTH, and let me know, too, about any tracing I can do; I'm
- Original Message -
From: "Graham Percival"
To: "Janek Warchoł"
Cc: ; ;
;
Sent: Tuesday, August 23, 2011 12:47 AM
Subject: Re: Adds a site search to website and improves doc search
(issue4894053)
On Mon, Aug 22, 2011 at 11:06:04PM +0200, Janek Warchoł wrote:
Phil, could you co
Mike Solomon ufl.edu> writes:
> I maintain that the best solution is:
> \override Staff.Accidental #'layer = #-100
> \override Staff.LedgerLineSpanner #'layer = #-101
> \override Staff.Accidental #'whiteout = ##t
>
> Which is a trivial change to engravers-init.ly. I'll post a patch later
> to
Han-Wen Nienhuys writes:
> I think the whole approach of whiting is flawed: what if
To pull that to a meta-level: sometimes it makes sense to program
LilyPond to do that which is obvious.
However, almost always it is Much Better (TM) to use the benchmarking
approach: find how the great masters s
On Tue, Aug 23, 2011 at 11:05 AM, Mike Solomon wrote:
>>>
>>> Which is a trivial change to engravers-init.ly. I'll post a patch later
>>> today unless anyone sees a better alternative.
>>
>> this will generate square endings on the ledgers.
>
> True.
> Question - is there any way to take a glyph
On Aug 23, 2011, at 4:03 PM, Han-Wen Nienhuys wrote:
> On Tue, Aug 23, 2011 at 3:59 AM, Mike Solomon wrote:
>> \override Staff.Accidental #'layer = #-100
>> \override Staff.LedgerLineSpanner #'layer = #-101
>> \override Staff.Accidental #'whiteout = ##t
>>
>>
>> }
>>
>> Which is a trivial cha
>>> 2: Is there a way to get the result code and see if the command succeded?
>> Uh, have you even looked up "system" in the guile documentation?
> Yes I have ... but I typed my question a bit to fast ... the question
> should have been, why does '(if (not (system ...' not act, like I would
> expec
On Tue, Aug 23, 2011 at 3:59 AM, Mike Solomon wrote:
> \override Staff.Accidental #'layer = #-100
> \override Staff.LedgerLineSpanner #'layer = #-101
> \override Staff.Accidental #'whiteout = ##t
>
>
> }
>
> Which is a trivial change to engravers-init.ly. I'll post a patch later
> today unless
Am Dienstag, 23. August 2011, 05:37:48 schrieb Colin Campbell:
> HTH, and let me know, too, about any tracing I can do; I'm on 64-bit
> Ubuntu Natty
It looks like python in your installations doesn't try to load packages from
the input/regression/musicxml/ directory (here on my 32 bit Ubuntu natt
Hi David
I have two questions:
To (system "...")
1: There are several commands, wich can write the generated EPS to
stdout. Is there a possibility to catch that and integrate it without
creating a temporary file?
See the guile documentation, node "Pipes".
OK, thanks!
2: Is there a way to get t
LGTM.
Thanks!
Carl
http://codereview.appspot.com/4940047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Jan-Peter Voigt writes:
> Hello List,
>
> I am using the scheme system command (on linux) to generate barcodes
> to include in the PDF:
> I have two questions:
> To (system "...")
> 1: There are several commands, wich can write the generated EPS to
> stdout. Is there a possibility to catch that
On 2011/08/22 23:55:52, Graham Percival wrote:
On 2011/08/22 12:30:15, Reinhold wrote:
> Now, it's clear that lilypond produces .pdf files that are about
0.5-1 mm too
> wide. So we now have the proper way to fix #1816
What does "0.5-1mm" mean? Is it 0.5 for top/bottom, 1.0 for
left/right?
Hello List,
I am using the scheme system command (on linux) to generate barcodes to
include in the PDF:
--snip--
\version "2.14.2"
% use barcode command to produce temporary eps and include it
#(define-markup-command (barcode layout props type str size
nums)(string-or-symbol? string? number-p
Reviewers: ,
Message:
Please review to get rid of some uninitialized variables.
Description:
Fix uninitialized variables when Source_file::get_counts returns early
due to !contains (pos_str0)
Most code that called get_counts simply is like:
int line, chr, col, offset = 0;
source_file_->get_
- Original Message -
From: "Graham Percival"
To: "Janek Warchoł"
Cc: ; ;
;
Sent: Tuesday, August 23, 2011 12:47 AM
Subject: Re: Adds a site search to website and improves doc search
(issue4894053)
On Mon, Aug 22, 2011 at 11:06:04PM +0200, Janek Warchoł wrote:
Phil, could you co
- Original Message -
From: "Colin Campbell"
I've just hit what looks like the same problem, after deleting and
rebuilding lilypond-git:
HTH, and let me know, too, about any tracing I can do; I'm on 64-bit
Ubuntu Natty
Added as http://code.google.com/p/lilypond/issues/detail?id=18
2011/8/21 Graham Percival :
> On Fri, Aug 19, 2011 at 07:32:20AM +0200, Werner LEMBERG wrote:
>> Please be more specific what I'm missing. In particular, many
>> locations which I've fixed (at least in my opinion) were talking
>> about, say, `#t' and `#foo' at the same time, which I consider *very
LGTM
Cheers,
MS
http://codereview.appspot.com/4636081/diff/42001/lily/stem-tremolo.cc
File lily/stem-tremolo.cc (right):
http://codereview.appspot.com/4636081/diff/42001/lily/stem-tremolo.cc#newcode61
lily/stem-tremolo.cc:61: return scm_from_double ((Stem::duration_log
(stem) >= 3 && get_grob_
On Aug 23, 2011, at 6:55 AM, joenee...@gmail.com wrote:
>
> http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc
> File lily/bezier.cc (right):
>
> http://codereview.appspot.com/4860042/diff/1/lily/bezier.cc#newcode239
> lily/bezier.cc:239: return p.minmax (sol[LEFT][0], sol[RIGHT][0], d
On Aug 23, 2011, at 6:21 AM, hanw...@gmail.com wrote:
>
> http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc
> File flower/polynomial.cc (right):
>
> http://codereview.appspot.com/4860042/diff/8001/flower/polynomial.cc#newcode80
> flower/polynomial.cc:80: return ret_max ? sols.
On Aug 23, 2011, at 5:31 AM, Colin Campbell wrote:
> For Wednesday August 25th, 22:00
>
> Issue 1735: modifying default behaviour of tremolo slashes - R 4636081
> Issue 1628: Fingerings collide with slurs when used in <> - R 4876051: Fixes
> issue 1628.
> Issue 1328: Slurs collides with fermat
Hey all,
My patch did change output (it prevented duplicate ledger lines), although I
did not spot the result that Janek sees.
The old patch is also flawed, in that it only changes the ledger line directly
next to the accidental. The entire bounding box of the accidental should,
however, be t
47 matches
Mail list logo
