Re: where X-extent of noteheads is set?

2011-07-17 Thread Joe Neeman
2011/7/17 Janek Warchoł : > I've searched in note-head.cc, note-column.cc, note-heads-engraver.cc > but found nothing... I believe it defaults to ly:grob::stencil-width (probably in grob.cc). Cheers, Joe ___ lilypond-devel mailing list lilypond-devel@g

Re: Creates callback for stem-begin-position. (issue4752048)

2011-07-17 Thread hanwenn
LGTM There is some code that adjusts for the shape of the notehead as well (look for calls to Note_head::stem_attachment_coordinate). Can you have a look if you can work that into your code too? http://codereview.appspot.com/4752048/ ___ lilypond-deve

Re: changing shape of the G clef (issue4664070)

2011-07-17 Thread Han-Wen Nienhuys
2011/7/16 Janek Warchoł : >> This is exactly the thin edge of the \override glyph >> wedge I was worried about earlier :(  We already have >> too many overrides. > > I think we shouldn't delete it immediately.  We sometimes leave old > syntax for some time; let's keep old clef glyph until 2.18.  T

Re: Checks for grobs with circular parentage in the regtests. (issue4747045)

2011-07-17 Thread Han-Wen Nienhuys
On Sat, Jul 16, 2011 at 12:31 PM, m...@apollinemike.com wrote: > > I'm gonna pull this patch out of consideration - both you and Neil are right > about checking parents on an axis-by-axis basis.  My desire to do this comes > from an incomplete understanding of what "parent" means in LilyPond sp

RE: Adds glissando stems to Lilypond. (issue4661061)

2011-07-17 Thread James Lowe
Hello, From: lilypond-devel-bounces+james.lowe=datacore@gnu.org [lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of mts...@gmail.com [mts...@gmail.com] Sent: 17 July 2011 19:22 To: pkx1...@gmail.com; gra...@percival-music.ca; n.putt..

Re: Doc: NR Added new Node for Footnotes (issue4751045)

2011-07-17 Thread tdanielsmusic
http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1038 Documentation/notation/input.itely:1038: where the @code{\markup @{in

Re: Move \RemoveEmptyStaves to new file for context modifications (issue #1760) (issue4664076)

2011-07-17 Thread n . puttock
Pushed: cf2da187b5b99e963346e5944311bb77e2e52ff1 http://codereview.appspot.com/4664076/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: changing shape of the G clef (issue4664070)

2011-07-17 Thread n . puttock
http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc File lily/clef.cc (right): http://codereview.appspot.com/4664070/diff/8001/lily/clef.cc#newcode51 lily/clef.cc:51: str = str + "_" + clef_style; you can't add clef_style unless you know glyph == "clefs.G" http://codereview.appspot.com

Re: Doc: NR Added new Node for Footnotes (issue4751045)

2011-07-17 Thread mtsolo
http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1105 Documentation/notation/input.itely:1105: A way to make them not colli

Re: where X-extent of noteheads is set?

2011-07-17 Thread Neil Puttock
2011/7/17 Janek Warchoł : > I've searched in note-head.cc, note-column.cc, note-heads-engraver.cc > but found nothing... You don't need to know this (though if you're curious, any grob without a default is set to ly:grob::stencil-width; see the constructor in grob.cc). If you want to know the ext

Re: Doc: NR Added new Node for Footnotes (issue4751045)

2011-07-17 Thread n . puttock
http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely File Documentation/notation/input.itely (right): http://codereview.appspot.com/4751045/diff/8001/Documentation/notation/input.itely#newcode1024 Documentation/notation/input.itely:1024: for top-level @code{\markup}

Re: Adds glissando stems to Lilypond. (issue4661061)

2011-07-17 Thread mtsolo
I've paired this down to a minimal implementation that only contains: 1) Init file stuff for syntax (this could be made much better...) 2) Modifications to the glissando engraver to ID glissando stems. 3) A function that links them up to glissandi in stem.hh 4) The triggering of this function via

Re: Doc: NR Added new Node for Footnotes (issue4751045)

2011-07-17 Thread percival . music . ca
LGTM. Maybe wait a day for Trevor to comment, then push. http://codereview.appspot.com/4751045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds redirect-lilypond-output option to lilypond-book(issue4664060)

2011-07-17 Thread Graham Percival
On Sun, Jul 17, 2011 at 03:59:37PM +0100, Phil Holmes wrote: > - Original Message - From: > >During a recent sudo make install I got this error. I'm not sure > >if it has to do with recent pushes in the python code, but I > >figured I'd pass it along: > > Mike - is this only with make in

Re: git-cl is down

2011-07-17 Thread Jan Warchoł
2011/7/17 Carl Sorensen : > On 7/16/11 5:37 PM, "Graham Percival" wrote: > >> On Sat, Jul 16, 2011 at 05:13:29PM -0600, Carl Sorensen wrote: >>> >>> IMO, we should be aiming at one commit per Rietveld issue, rather than a >>> series of commits per Rietveld issue. >> >> That's beside the point, at

Re: Adds redirect-lilypond-output option to lilypond-book(issue4664060)

2011-07-17 Thread m...@apollinemike.com
On Jul 17, 2011, at 4:59 PM, Phil Holmes wrote: > - Original Message - From: > To: ; ; > ; > Sent: Sunday, July 17, 2011 3:43 PM > Subject: Re: Adds redirect-lilypond-output option to > lilypond-book(issue4664060) > > >> Hey all, >> >> During a recent sudo make install I got this er

Re: Adds redirect-lilypond-output option to lilypond-book(issue4664060)

2011-07-17 Thread Phil Holmes
- Original Message - From: "Phil Holmes" To: ; ; ; ; Sent: Sunday, July 17, 2011 3:59 PM Subject: Re: Adds redirect-lilypond-output option to lilypond-book(issue4664060) - Original Message - From: To: ; ; ; Sent: Sunday, July 17, 2011 3:43 PM Subject: Re: Adds redirec

where X-extent of noteheads is set?

2011-07-17 Thread Janek Warchoł
I've searched in note-head.cc, note-column.cc, note-heads-engraver.cc but found nothing... If i knew this i could probably fix http://code.google.com/p/lilypond/issues/detail?id=1546 Thanks in advance, Janek ___ lilypond-devel mailing list lilypond-devel

Re: Adds redirect-lilypond-output option to lilypond-book(issue4664060)

2011-07-17 Thread Phil Holmes
- Original Message - From: To: ; ; ; Sent: Sunday, July 17, 2011 3:43 PM Subject: Re: Adds redirect-lilypond-output option to lilypond-book(issue4664060) Hey all, During a recent sudo make install I got this error. I'm not sure if it has to do with recent pushes in the python c

Re: Adds redirect-lilypond-output option to lilypond-book (issue4664060)

2011-07-17 Thread m...@apollinemike.com
Hey all, During a recent sudo make install I got this error. I'm not sure if it has to do with recent pushes in the python code, but I figured I'd pass it along: Compiling /Users/mikesolomon/devel/lilypond/Documentation/out/notation/notation.texi... /Users/mikesolomon/devel/lilypond/Documentat

Re: print transposed guitar chords on piano sheets (issue4626094)

2011-07-17 Thread Carl . D . Sorensen
On 2011/07/17 10:35:20, Janek Warchol wrote: Hi all, as acting Frog Meister i'm worried that nothing happens here :( Wol, how can i help you? Neil, Carl: do i understand correctly that Wol could've done this using a more elegant solution, but nevertheless his patch doesn't brake anything and w

Re: print transposed guitar chords on piano sheets (issue4626094)

2011-07-17 Thread Janek Warchoł
Hi all, as acting Frog Meister i'm worried that nothing happens here :( Wol, how can i help you? Neil, Carl: do i understand correctly that Wol could've done this using a more elegant solution, but nevertheless his patch doesn't brake anything and works correctly (i don't remember any problems whe

Re: change in treble clef - do you accept?

2011-07-17 Thread Jan Warchoł
2011/7/17 Reinhold Kainhofer : > On So., 17. Jul. 2011 09:41:02 CEST, Jan Warchoł > wrote: > >> 2011/7/17 David Kastrup : >> > Reinhold Kainhofer writes: >> > > There is no particular reason I used a scaled regular clef, IIRC. We >> > > might just as well use a scaled change clef... Feel free to

font: change breve vertical lines (issue4748044)

2011-07-17 Thread lemniskata . bernoullego
Reviewers: , Message: Hi, breve glyphs in Feta font need modification. What is bad now: breves lying between the stafflines form a hard-to-recognize clump, partly because the corners (marked in orange here: http://lilypond.googlecode.com/issues/attachment?aid=1767000&name=breve+dimensions.p

Re: change in treble clef - do you accept?

2011-07-17 Thread Reinhold Kainhofer
On So., 17. Jul. 2011 09:41:02 CEST, Jan Warchoł wrote: > 2011/7/17 David Kastrup : > > Reinhold Kainhofer writes: > > > There is no particular reason I used a scaled regular clef, IIRC. We > > > might just as well use a scaled change clef... Feel free to change > > > that. > > > > What clef t

Re: GOP-PROP 5: build system output (update)

2011-07-17 Thread Phil Holmes
- Original Message - From: "Graham Percival" >>I think there should be an option to turn it all back on if you want >>- a sort of inverse of QUIET_BUILD. We should also get rid of the >>QUIET_BUILD variable completely. > >Agreed. Maybe using the V=1 thing that Jan was talking about?

Re: change in treble clef - do you accept?

2011-07-17 Thread Jan Warchoł
2011/7/17 David Kastrup : > Reinhold Kainhofer writes: > >> On Sa., 16. Jul. 2011 21:05:37 CEST, Janek Warchoł >> wrote: >> >>> 2011/7/16 Han-Wen Nienhuys : >>> > 2011/7/15 Janek Warchoł : >>> > > Surprisingly, CueClef currently uses regular clef glyph scaled down >>> > > 1.5874 times (font-size

Re: git-cl is down

2011-07-17 Thread Graham Percival
On Sat, Jul 16, 2011 at 07:35:50PM -0600, Carl Sorensen wrote: > Now Bertrand's repository doesn't have one commit on this branch, he has > three or four commits on his branch. And the first two or three are not > right -- they haven't passed code review. oh, I see. I personally always just modi

Re: modifying default behaviour of tremolo slashes (issue4636081)

2011-07-17 Thread lemniskata . bernoullego
Finally - new patch set uploaded. Now it's possible to easily switch between different tremolo behaviours. 'Style' property is no longer used to choose between rectangular and beam-like slashes - this is now done using 'shape' property. 'Style' property now influences both 'shape' and 'slope' of t

Re: change in treble clef - do you accept?

2011-07-17 Thread David Kastrup
Reinhold Kainhofer writes: > On Sa., 16. Jul. 2011 21:05:37 CEST, Janek Warchoł > wrote: > >> 2011/7/16 Han-Wen Nienhuys : >> > 2011/7/15 Janek Warchoł : >> > > Surprisingly, CueClef currently uses regular clef glyph scaled down >> > > 1.5874 times (font-size -4), not a scaled down change clef.