Re: PATCH: 48-hour countdown

2011-07-11 Thread Jan Warchoł
2011/7/12 Colin Campbell : > 21:00 MST Wednesday July 13 > > Reitveld Issue 4664060: Adds redirect-lilypond-output option to > lilypond-book > > Issue 1736: clarify description of minimal examples - Reitveld Issue 4636082 > > Issue 1739: doc: correcting note about rerunning regtests - Reitveld Issu

PATCH: 48-hour countdown

2011-07-11 Thread Colin Campbell
21:00 MST Wednesday July 13 Reitveld Issue 4664060 : Adds redirect-lilypond-output option to lilypond-book Issue 1736 : clarify description of minimal examples - Reitveld Issue 4636082

Re: Fix 1581: Only NoteEvents can cause a tie. Ignore all other events that create note heads (issue4686047)

2011-07-11 Thread pkx166h
Pass Make and reg tests - James http://codereview.appspot.com/4686047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Fix 1390: slashedGrace function (graces with slashed stems but no slur, e.g. when grace is tied) (issue4670056)

2011-07-11 Thread pkx166h
passes make and reg tests http://codereview.appspot.com/4670056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1676: Properly count the notes in a chord tremolo (ignore all non-note events) (issue4685049)

2011-07-11 Thread pkx166h
Passes Make and Reg tests. James http://codereview.appspot.com/4685049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Janek Warchoł
2011/7/11 Neil Puttock : > Thanks, pushed to master. Thanks, issue closed. cheers, Janek ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Neil Puttock
2011/7/11 Janek Warchoł : > Sorry, i didn't notice. > Attached is a nicely described patch. Thanks, pushed to master. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Janek Warchoł
2011/7/11 Neil Puttock : > 2011/7/11 Janek Warchoł : >> 2011/7/11 Graham Breed : >>> Is that me?  I'm supposed to do something?  Here's a patch >> >> Perfect! >> >> Mike: please push this. > > Please don't push without adding a commit message. Sorry, i didn't notice. Attached is a nicely described

Re: Does type checking for all context property sets. (issue4654090)

2011-07-11 Thread n . puttock
http://codereview.appspot.com/4654090/diff/16002/lily/context.cc File lily/context.cc (right): http://codereview.appspot.com/4654090/diff/16002/lily/context.cc#newcode496 lily/context.cc:496: bool type_check_ok; ? assert (type_check_ok); http://codereview.appspot.com/4654090/

Re: Fix 1676: Properly count the notes in a chord tremolo (ignore all non-note events) (issue4685049)

2011-07-11 Thread n . puttock
http://codereview.appspot.com/4685049/diff/5001/scm/music-functions.scm File scm/music-functions.scm (right): http://codereview.appspot.com/4685049/diff/5001/scm/music-functions.scm#newcode249 scm/music-functions.scm:249: (define (note-count music-elements) remove http://codereview.appspot.com/

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Neil Puttock
2011/7/11 Janek Warchoł : > 2011/7/11 Graham Breed : >> Is that me?  I'm supposed to do something?  Here's a patch > > Perfect! > > Mike: please push this. Please don't push without adding a commit message. Thanks, Neil ___ lilypond-devel mailing list

is there a command to update all local branches at once?

2011-07-11 Thread Janek Warchoł
I'd like to pull in all local branches in one command, is this possible? I've searched CG but it doesn't seem to mention it, also official git manual on pull (http://www.kernel.org/pub/software/scm/git/docs/git-pull.html) says "git-pull - Fetch from and merge with another repository or a local bran

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Janek Warchoł
2011/7/11 Graham Breed : > Is that me?  I'm supposed to do something?  Here's a patch Perfect! Mike: please push this. Colin: sorry for overlooking that the countdown was over. We definately need an integrated patch/issue tracker! cheers, Janek From 54d259942dd3a7d0c5461ca71b111796be2f59ec Mon

[PATCH] Fix 1563: System start bars should interpret collapse-height in multiples of staff-space

2011-07-11 Thread Reinhold Kainhofer
Please review: http://codereview.appspot.com/4693043 Cheers, Reinhold -- -- Reinhold Kainhofer, reinh...@kainhofer.com, http://reinhold.kainhofer.com/ * Financial & Actuarial Math., Vienna Univ. of Technology, Austria * http://www.

Re: changing shape of the G clef (issue4664070)

2011-07-11 Thread lemniskata . bernoullego
New patch set uploaded - the suggested clef is a bit higher now. Images can be found in tracker issue: http://code.google.com/p/lilypond/issues/detail?id=1752 http://codereview.appspot.com/4664070/ ___ lilypond-devel mailing list lilypond-devel@gnu.or

Re: an example of minimal example (issue4636082)

2011-07-11 Thread percival . music . ca
LGTM http://codereview.appspot.com/4636082/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: correcting note about rerunning regtests (issue4675048)

2011-07-11 Thread percival . music . ca
LGTM http://codereview.appspot.com/4675048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1676: Properly count the notes in a chord tremolo (ignore all non-note events) (issue4685049)

2011-07-11 Thread reinhold . kainhofer
Reviewers: Neil Puttock, J_lowe, Message: On 2011/07/10 23:03:21, J_lowe wrote: This passes a make but fails a reg test check New patch uploaded that uses Neil's suggestions about extract-named-music. That function also correctly works with repeated chords, so the crash also goes away with the

Re: Does type checking for all context property sets. (issue4654090)

2011-07-11 Thread mtsolo
On 2011/07/10 21:56:11, Neil Puttock wrote: Hah, that's a bit too much. :) A more descriptive name than `ok' will do (e.g., type_check_ok) Cheers, Neil type_check_ok ok - added in a new patchset. Cheers, MS http://codereview.appspot.com/4654090/ __

Re: Small pitch bends correct and tested. (issue4654063)

2011-07-11 Thread Graham Breed
lemniskata.bernoull...@gmail.com wrote: > Graham, > > I'm worried that i don't hear anything from you since 2 > weeks! Do you experience any problems with fixing code > style issues pointed to by Neil? Is that me? I'm supposed to do something? Here's a patch Graham >From 2d6bc54fa0

Re: Flag functions instead of defining glyphs directly (issue4625067)

2011-07-11 Thread lemniskata . bernoullego
This was just pushed by Mike. I close the issue. thanks, Janek http://codereview.appspot.com/4625067/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Converting ly to musicxml

2011-07-11 Thread cab
Le 10/07/2011 23:27, Jan Warchoł a écrit : > 2011/7/10 cab : >> Converting from midi to ly is possible, but ly to musicxml has never >> been done... So my plan is to program it myself >> I think I would do it in python as musicxml2ly is also written in python. >> >> If I manage to do it , will it b