Add feta-flags to build system (issue4662055)

2011-06-24 Thread Carl . D . Sorensen
Reviewers: Janek Warchol, Message: Here is a revision of Janek's patch to separate feta-flags from feta-noteheads. I believe that it works properly; I rebuilt the fonts and the flags look fine. To test, you will need to do rm mf/out/* && make before testing a lilypond file. Description: Add

Re: Dynamic + text aligned: BEST solution?

2011-06-24 Thread Graham Percival
On Sat, Jun 25, 2011 at 12:44:30AM +0200, Valentin Villenave wrote: > On Thu, Jun 23, 2011 at 1:53 PM, Graham Percival > wrote: > > Please stop capitalizing "patch".  If you're referring to issue > > 1264, the patch broke the build, and in any case it's postponed > > until GLISS. > > Er, no it di

Re: Dynamic + text aligned: BEST solution?

2011-06-24 Thread Valentin Villenave
On Thu, Jun 23, 2011 at 1:53 PM, Graham Percival wrote: > Please stop capitalizing "patch".  If you're referring to issue > 1264, the patch broke the build, and in any case it's postponed > until GLISS. Er, no it didn't. (TBH, I do remember Neil noticing a very minor, unrelated error though.) The

Re: \breakDynamicSpan breaks with \break ("bounds of spanner are invalid")

2011-06-24 Thread Reinhold Kainhofer
Am Freitag, 24. Juni 2011, 22:06:04 schrieb Reinhold Kainhofer: > I'm currently trying to understand what exactly is the cause of bugs #1259 > and #1433: > http://code.google.com/p/lilypond/issues/detail?id=1259 > http://code.google.com/p/lilypond/issues/detail?id=1433 [...] > It actually indicates

Re: \breakDynamicSpan breaks with \break ("bounds of spanner are invalid")

2011-06-24 Thread Reinhold Kainhofer
I'm currently trying to understand what exactly is the cause of bugs #1259 and #1433: http://code.google.com/p/lilypond/issues/detail?id=1259 http://code.google.com/p/lilypond/issues/detail?id=1433 Actually, both are symptoms of the same problem: Both set early_end_ in the dynamic-align-engraver

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Graham Percival
On Fri, Jun 24, 2011 at 07:49:02PM +0200, Matthias Kilian wrote: > [slightly offtopic tab size rant ;-)] > > On Fri, Jun 24, 2011 at 04:44:21PM +0100, Graham Percival wrote: > > In the old/bad style that emacs produced, one tab was used to > > represent 8 spaces. Yes, it was doubly confusing. >

Re: Tuning fixes

2011-06-24 Thread Graham Percival
On Fri, Jun 24, 2011 at 06:17:07PM +0100, Graham Breed wrote: > I've found and patched two problems with the pitch bend > tuning code: Thanks, Janek will upload these to rietveld. However, for patch 1 he will first remove the change to configure.in; we now require at least fontforge 20100501. Ch

Re: Implements multiple-line non-cross-staff glissandi (issue4527086)

2011-06-24 Thread pkx166h
no problems in reg tests. http://codereview.appspot.com/4527086/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Tuning fixes

2011-06-24 Thread Graham Breed
I've found and patched two problems with the pitch bend tuning code: 1) The pitch isn't always rounded to the nearest equally tempered value, so the result looks strange in a sequencer, and artifacts caused by the pitch bends are more severe. 2) The tuning is rounded to cents before the pitch ben

Re: Adds ly:engraver-property to engraver-scheme (issue1878048)

2011-06-24 Thread pkx166h
Passes reg tests http://codereview.appspot.com/1878048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Matthias Kilian
[slightly offtopic tab size rant ;-)] On Fri, Jun 24, 2011 at 04:44:21PM +0100, Graham Percival wrote: > In the old/bad style that emacs produced, one tab was used to > represent 8 spaces. Yes, it was doubly confusing. Well, no. People and/or editors who used one tab per indentation level (and p

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Graham Percival
On Fri, Jun 24, 2011 at 01:38:21PM +, Benjamin Peterson wrote: > oco.net> writes: > > > The bad news is, you replaced tabs by 4 columns when we needed 8 column. > > The good news is, so far as I can see, there were no un-wanted changes > > (no cases were we needed a literal tab). > > But th

RE: Fix for issue 1706. (issue4662047)

2011-06-24 Thread James Lowe
Oops From: lilypond-devel-bounces+james.lowe=datacore@gnu.org [lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of pkx1...@gmail.com [pkx1...@gmail.com] Sent: 24 June 2011 16:51 To: mts...@gmail.com; carl.d.soren...@gmail.com; hanw...@

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Reinhold Kainhofer
Am Freitag, 24. Juni 2011, 15:38:21 schrieb Benjamin Peterson: > oco.net> writes: > > The bad news is, you replaced tabs by 4 columns when we needed 8 column. > > The good news is, so far as I can see, there were no un-wanted changes > > (no cases were we needed a literal tab). > > But the GOP s

Re: Adds ly:engraver-property to engraver-scheme (issue1878048)

2011-06-24 Thread percival . music . ca
thanks, added as http://code.google.com/p/lilypond/issues/detail?id=1708 http://codereview.appspot.com/1878048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix for issue 1706. (issue4662047)

2011-06-24 Thread percival . music . ca
On 2011/06/24 15:51:14, J_lowe wrote: Mike I ran a reg test against this new beam code and I get significant differences on test-output-distance.ly Umm... http://lilypond.org/doc/v2.15/Documentation/contributor/regtest-comparison ... maybe we should change the background of @warning{} boxes

Re: Fix for issue 1706. (issue4662047)

2011-06-24 Thread pkx166h
On 2011/06/24 06:22:48, MikeSol wrote: On 2011/06/23 17:48:23, hanwenn wrote: > * Test missing. > * Should print programming_error if dir == CENTER. > * I'd use linear_combination on dir instead, so it is symmetric in up/down. > Done, done, and done. Cheers, MS Mike I ran a reg test aga

Re: Adds ly:engraver-property to engraver-scheme (issue1878048)

2011-06-24 Thread Han-Wen Nienhuys
On Fri, Jun 24, 2011 at 11:40 AM, wrote: > Reviewers: , > > Message: > I found this 10-month old patch of mine laying around.  It still seems > relevant, so I'm sending it to the list.  Lemme know what y'all think. What would this be used for? Normally in Scheme you'd have a context with alread

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread Benjamin Peterson
oco.net> writes: > > The bad news is, you replaced tabs by 4 columns when we needed 8 column. > The good news is, so far as I can see, there were no un-wanted changes > (no cases were we needed a literal tab). But the GOP says "use 4 spaces per indentation level"! > > http://codereview.appsp

Re: Patch meister

2011-06-24 Thread Graham Percival
On Thu, Jun 23, 2011 at 09:31:45PM -0600, Colin Campbell wrote: > I could take it on, Graham. In some ways it's just a bit further > and more formal than the "screening" I've been trying to do. ok, great! I was just discussing the "needs work" aspect with James because he has an incredibly power

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-06-24 Thread m...@apollinemike.com
Sorry - this patch is obsolete. The new one is at: http://codereview.appspot.com/4527086 Sorry for not having removed the old one, and yes, please add the new one to the countdown (it has gone through a round of commentary). Cheers, MS On Jun 24, 2011, at 4:28 PM, percival.music...@gmail.com

Re: Allows glissandi to span multiple lines. (issue4564042)

2011-06-24 Thread percival . music . ca
On 2011/05/30 07:38:19, mike_apollinemike.com wrote: I'm flying to Ireland today & will attempt to crunch this during the flight. This was almost a month ago. Are you sailing to Ireland instead of flying? ;) What's the status of this patch? If you think that draft 2 is correct, then I'll ad

Adds ly:engraver-property to engraver-scheme (issue1878048)

2011-06-24 Thread mtsolo
Reviewers: , Message: I found this 10-month old patch of mine laying around. It still seems relevant, so I'm sending it to the list. Lemme know what y'all think. Description: Adds ly:engraver-property to engraver-scheme Adds ly:engraver-property to engraver-scheme Get rid of whitespace err

Re: question about mod dates in my git tree for resetted files

2011-06-24 Thread Graham Percival
On Fri, Jun 24, 2011 at 01:57:13AM +, James Lowe wrote: > Usually when I make some patches and post on Rietveld, I make a > .patch file, save it somewhere safe and then 'reset' my tree > (abort in Lilygit.tcl). This means I can work on other stuff > without having to do complicated stuff (for m

Re: New breve rest with ledger lines (issue4650052)

2011-06-24 Thread bordage . bertrand
Yes, sorry for that. Just for information, ancient fonts are stored in the parmesan-* files. For the ancient fonts, we really need to think about a less hard-coded solution. http://codereview.appspot.com/4650052/ ___ lilypond-devel mailing list lilypon

Re: Replace Tab with 8 Spaces for .py files (issue4627062)

2011-06-24 Thread pkx166h
Thanks Keith and Carl. Pushed as 20596e17d6f8026f7199c9ae0e5f03517631a66c Closing this issue http://codereview.appspot.com/4627062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel