Re: Add ties from Completion_note_heads_engraver to a TieColumn. (issue4592060)

2011-06-18 Thread n . puttock
Pushed: 91ff7544dcefe4fc273559047c72991d207ab5ba http://codereview.appspot.com/4592060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix breathing sign Y-offset when using line-positions. (issue4620051)

2011-06-18 Thread n . puttock
Pushed: c1a48137f98086b46a91cf5b741c0b744409904b http://codereview.appspot.com/4620051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Property setting in lyrics: allow markup, not just bare strings (issue4571080)

2011-06-18 Thread Neil Puttock
On 16 June 2011 17:28, wrote: > I won't bother with an issue tracker item for this; I think it's > simple+clear enough that it can be pushed without a full "patch > countdown". Thanks, pushed: eb307731804e61efcb62a13ebbf13da5bb050f3f Cheers, Neil __

Re: multi-measure-rest.cc breaks build with log2

2011-06-18 Thread Neil Puttock
On 18 June 2011 20:33, Graham Percival wrote: > Looks fine, please push. Pushed: 295ad53e7b4e3e2b2a0a612f46b184f79c3cc7ce Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: multi-measure-rest.cc breaks build with log2

2011-06-18 Thread Graham Percival
On Sat, Jun 18, 2011 at 06:49:51PM +0100, Neil Puttock wrote: > The attached patch works for me: passes regtest checks and produces > both FreeBSD builds. Looks fine, please push. Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: multi-measure-rest.cc breaks build with log2

2011-06-18 Thread Neil Puttock
On 18 June 2011 14:42, Graham Percival wrote: > Either use a different function, or include the right header. > > /main/src/gub/target/freebsd-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/multi-measure-rest.cc: > In function 'int measure_duration_log(Grob*)': > /main/src/gub/

Added missing semi-colon to fret .ly file (issue4632049)

2011-06-18 Thread Carl . D . Sorensen
LGTM. Please push. Carl http://codereview.appspot.com/4632049/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: Added \cueClef command (issue4601060)

2011-06-18 Thread pkx166h
On 2011/06/18 14:30:39, Graham Percival wrote: LGTM, please push. d25fbff2e29563ae3e2bd8f3a6d7269fd1164393 Closed issue and updated tracker issue. http://codereview.appspot.com/4601060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https:

Re: Doc: Added \cueClef command (issue4601060)

2011-06-18 Thread percival . music . ca
LGTM, please push. http://codereview.appspot.com/4601060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Current state of automatic footnotes. (issue4580041)

2011-06-18 Thread bordage . bertrand
Hi Mike! There is a problem with your patch, I can not compile until the end, even after "git clean -fxd." This crashes when building internals.texi And there is still the same spacing issues with "number_raise" and notes higher than 9... Thanks, Bertrand http://codereview.appspot.com/4580041/d

multi-measure-rest.cc breaks build with log2

2011-06-18 Thread Graham Percival
Either use a different function, or include the right header. /main/src/gub/target/freebsd-64/src/lilypond-git.sv.gnu.org--lilypond.git-release-unstable/lily/multi-measure-rest.cc: In function 'int measure_duration_log(Grob*)': /main/src/gub/target/freebsd-64/src/lilypond-git.sv.gnu.org--lilypond.

RE: GOP-PROP 2: mentors and Frogs

2011-06-18 Thread James Lowe
Hello, From: lilypond-devel-bounces+james.lowe=datacore@gnu.org [lilypond-devel-bounces+james.lowe=datacore@gnu.org] on behalf of Graham Percival [gra...@percival-music.ca] Sent: 18 June 2011 00:48 To: Carl Sorensen Cc: lilypond-devel@gnu.org Subje

PATCH: one-character typo in predefined-guitar-fretboards.ly

2011-06-18 Thread James Lowe
http://codereview.appspot.com/4632049 This is for tracker http://code.google.com/p/lilypond/issues/detail?id=1665 I know I could push this, but as I don't really do fret stuff, I'd like someone else to check it :) Thanks James ___ lilypond-devel mail

Re: Doc: Added \cueClef command (issue4601060)

2011-06-18 Thread pkx166h
Reviewers: Graham Percival, Message: Draft 2. Thanks James http://codereview.appspot.com/4601060/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4601060/diff/1/Documentation/notation/staff.itely#newcode1221 Documentatio