Re: Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-04 Thread k-ohara5a5a
On 2011/06/04 17:32:15, joeneeman wrote: > When compressing, unstretchable springs never get put on the > active list, since their blocking_force is 0. It seems, though, that unstretchable but compressible springs should be on the active list when compressing. They are. They have blocking

Re: Emit not-quite-cross-staff beams in the right context. (issue4564041)

2011-06-04 Thread joeneeman
On 2011/06/01 05:59:21, Keith wrote: On 2011/05/31 08:19:42, joeneeman wrote: > the Beam's Y-parent will be the VerticalAxisGroup of the bottom staff > and Beam::calc_cross_staff will return false. Old patch didn't; but new patch does. LGTM Thanks, pushed. Also removed the 3 lines suggest

Re: Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-04 Thread joeneeman
http://codereview.appspot.com/4517136/diff/1001/lily/simple-spacer.cc File lily/simple-spacer.cc (right): http://codereview.appspot.com/4517136/diff/1001/lily/simple-spacer.cc#newcode230 lily/simple-spacer.cc:230: for (++i; i < sorted_springs.size (); i++) On 2011/06/04 10:48:09, Keith wrote: O

Re: Adds longas, maximas and non-standard tweaks to MultiMeasureRest (issue4536068)

2011-06-04 Thread n . puttock
LGTM. http://codereview.appspot.com/4536068/diff/17008/input/regression/multi-measure-rest-standard.ly File input/regression/multi-measure-rest-standard.ly (right): http://codereview.appspot.com/4536068/diff/17008/input/regression/multi-measure-rest-standard.ly#newcode20 input/regression/multi-

Re: event listener and engraver properties

2011-06-04 Thread Neil Puttock
On 3 June 2011 20:04, Graham Percival wrote: > Hmm.  So if I wanted to write this information to a line, I'd have > to use some stateful variable to store the latest value of the > (Override), then use that info whenever I saw a (text-span-event) > ?  That seems like a step backwards for maintabi

Re: Allows accidental placements to be individualized. (issue4526094)

2011-06-04 Thread n . puttock
On 2011/06/04 12:50:55, MikeSol wrote: This, in combination with my stem-attachment patch, allows for the small notes above harmonics that give the sounding pitch to be typset well. I think you should consider making the sounding pitch a separate constellation of grobs, similar to a pitched

Allows accidental placements to be individualized. (issue4526094)

2011-06-04 Thread mtsolo
Reviewers: , Message: Hey all, This, in combination with my stem-attachment patch, allows for the small notes above harmonics that give the sounding pitch to be typset well. Please review! Cheers, MS Description: A note-column can have individualized accidental placements, which help with har

Re: Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-04 Thread k-ohara5a5a
Reviewers: joeneeman, http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc File lily/align-interface.cc (left): http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc#oldcode230 lily/align-interface.cc:230: dy = max (dy, Page_layout_problem::get_fixed_spacing

Vertical spacing, distinguish stretchability/compressibility (issue4517136)

2011-06-04 Thread joeneeman
http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc File lily/align-interface.cc (left): http://codereview.appspot.com/4517136/diff/1001/lily/align-interface.cc#oldcode230 lily/align-interface.cc:230: dy = max (dy, Page_layout_problem::get_fixed_spacing (elems[j-1], elems[j],