Re: Pure properties

2011-05-24 Thread m...@apollinemike.com
That does help - thank you! ~Mike On May 25, 2011, at 5:28 AM, Benjamin Peterson wrote: > mike apollinemike.com apollinemike.com> writes: > >> >> Hey all, >> >> I think I've asked this question before, but I can't find the response - >> sorry > if I'm repeating myself! >> >> Could someone

Re: MIDI: intelligently combine overlapping notes. (issue4520050)

2011-05-24 Thread k-ohara5a5a
I have been successfully testing this patch for and want to push it within a couple of days. Now is a good time to review (even though Michael Duggan wrote the core of this patch seven years ago) because it gets us thinking about how to di

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-24 Thread k-ohara5a5a
Reviewers: Trevor Daniels, joeneeman, Message: Thanks for comments. I'll wait one more day before I push. Description: Loose-lines honor padding between systems When placing a loose line (e.g. Lyrics) at the top or bottom of a system, include as a constraint the padding to the neighboring syste

Re: Pure properties

2011-05-24 Thread Benjamin Peterson
mike apollinemike.com apollinemike.com> writes: > > Hey all, > > I think I've asked this question before, but I can't find the response - sorry if I'm repeating myself! > > Could someone please send me a paragraph-long response about what pure properties are and how/when/why > they're used?

Re: Pure properties

2011-05-24 Thread m...@apollinemike.com
On May 24, 2011, at 11:08 AM, Joe Neeman wrote: > A pure callback is one that has no side-effects. In define-grobs.scm, you > will find a list of pure callbacks, along with an associative list that > allows you to substitute a non-pure callback for a pure one. > > Pure callbacks are important f

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread pkx166h
Thanks everyone Pushed c7edeb3d1c298262efc6c077a3f6d2d62e072a96 http://codereview.appspot.com/4518053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread Graham Percival
On Tue, May 24, 2011 at 10:52:56AM +0100, Trevor Daniels wrote: > percival.music...@gmail.com wrote Tuesday, May 24, 2011 10:14 AM > >On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: > > > >>I think it is worth adding Music classes to the > >>Internal Reference section. This lists all the > >

Re: Loose-lines honor padding between systems (issue4553060)

2011-05-24 Thread joeneeman
lgtm http://codereview.appspot.com/4553060/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Loose-lines honor padding between systems (issue4553060)

2011-05-24 Thread tdanielsmusic
Looks ok to me, although I haven't tested it. Need Joe's LGTM to push. http://codereview.appspot.com/4553060/diff/7001/input/regression/page-spacing-nonstaff-lines-between-2.ly File input/regression/page-spacing-nonstaff-lines-between-2.ly (right): http://codereview.appspot.com/4553060/diff/700

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread Trevor Daniels
percival.music...@gmail.com wrote Tuesday, May 24, 2011 10:14 AM On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: I think it is worth adding Music classes to the Internal Reference section. This lists all the event classes linearly. That would be a separate issue, of course. Sorry,

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread percival . music . ca
On 2011/05/24 08:34:42, t.daniels_treda.co.uk wrote: I think it is worth adding Music classes to the Internal Reference section. This lists all the event classes linearly. That would be a separate issue, of course. You could add at the end of the See Also section: Installed Files: @file{

Re: Pure properties

2011-05-24 Thread Joe Neeman
A pure callback is one that has no side-effects. In define-grobs.scm, you will find a list of pure callbacks, along with an associative list that allows you to substitute a non-pure callback for a pure one. Pure callbacks are important for spacing and page-breaking, particularly pure Y-extent and

Re: Doc: NR 1.6.3 - edit eg.s in quoting other voices (issue4518053)

2011-05-24 Thread Trevor Daniels
wrote Monday, May 23, 2011 9:37 PM I've made a change to the example. I wasn't sure which file I could @ref to as it wasn't really obvious (to me) to see which default values quoteDuring used - the text says 'etc.' and it may use them all by default. So if you think we could @ref a ly file l

Pure properties

2011-05-24 Thread m...@apollinemike.com
Hey all, I think I've asked this question before, but I can't find the response - sorry if I'm repeating myself! Could someone please send me a paragraph-long response about what pure properties are and how/when/why they're used? The more sequential, the better (i.e. pure properties are defin