Re: Gets rid of unnecessary logic in beam.cc. (issue4449065)

On Thu, Apr 28, 2011 at 12:37 PM, wrote: > Reviewers: , > > Message: > If I understand it correctly, Han-Wen's original collision code in > beam.cc was treating intervals as if is_empty checked if they were > uninitialized or invalid in some way, whereas in fact, is_empty gets rid > of anything w

Re: Doc: Adjusted CG Policy on @lilypond[] variables (issue4445070)

A few more nitpicks; otherwise looks fine. [I'm not convinced adding colons before @examples is a good thing, especially when the sentence runs on after the example, but for now that is the policy.] http://codereview.appspot.com/4445070/diff/4001/Documentation/contributor/doc-work.itexi File Do

Re: Gets rid of unnecessary logic in beam.cc. (issue4449065)

On Apr 28, 2011, at 11:37, mts...@gmail.com wrote: > Reviewers: , > > Message: > If I understand it correctly, Han-Wen's original collision code in > beam.cc was treating intervals as if is_empty checked if they were > uninitialized or invalid in some way, whereas in fact, is_empty gets rid > of

Gets rid of unnecessary logic in beam.cc. (issue4449065)

Reviewers: , Message: If I understand it correctly, Han-Wen's original collision code in beam.cc was treating intervals as if is_empty checked if they were uninitialized or invalid in some way, whereas in fact, is_empty gets rid of anything where left is greater than right. However, the LEFT and

Re: Fix "make doc" error: Character set messup in pdf-scheme.cc (issue4449061)

http://codereview.appspot.com/4449061/diff/4001/lily/pdf-scheme.cc File lily/pdf-scheme.cc (right): http://codereview.appspot.com/4449061/diff/4001/lily/pdf-scheme.cc#newcode30 lily/pdf-scheme.cc:30: "Encode the given string to either Latin1 (which is a subset of " move space to start of next st

Re: Allows glissandi between chords (issue4442082)

On Apr 28, 2011, at 9:47 AM, n.putt...@gmail.com wrote: > > http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly > File input/regression/glissando-chord.ly (right): > > http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly#newcode4 > i

Re: branching isn't working

On Thu, Apr 28, 2011 at 02:45:07PM +0100, Graham Percival wrote: > We can't just change VERSION in git master, because that's used to > generate the website, oh wait, I just remembered that we have a separate MINOR_VERSION from VERSION_DEVEL. ha, a badly designed almost-duplicate of information m

Re: Allows glissandi between chords (issue4442082)

http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly File input/regression/glissando-chord.ly (right): http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly#newcode4 input/regression/glissando-chord.ly:4: texidoc = "LilyPond typesets g

branching isn't working

So Mike just pushed 09f09c054a7c985424925605c237c78b9adb4047 with a regtest with a version number of 2.15.0. That was because I told him to change the previous number fo 2.13.61, since the commit wasn't going to be part of 2.13.61. This broke the regtest compiling, because master still uses a VER

Re: PATCHES: 48-hour notice for rest collisions and faulty warnings in articulate

On Thu, Apr 28, 2011 at 07:32:18AM -0600, Carl Sorensen wrote: > On 4/28/11 5:52 AM, "Graham Percival" wrote: > > > Sat, 13:00. > > > > > > Allows glissandi between chords > > http://codereview.appspot.com/4442083/ Umm, this is a mess. That URL should be http://codereview.appspot.com/4442082/

Re: Allows glissandi between chords (issue4442082)

On 28 April 2011 14:13, m...@apollinemike.com wrote: > Thanks.  Pushed as 09f09c054a7c985424925605c237c78b9adb4047. > > We have our first 2.15.0 regtest.  w00t! Mike, you can't do this. There's no 2.15 branch yet, which means the version string will break compilation (since it's in advance of ma

Re: PATCHES: 48-hour notice for rest collisions and faulty warnings in articulate

On 4/28/11 5:52 AM, "Graham Percival" wrote: > Sat, 13:00. > > > Allows glissandi between chords > http://codereview.appspot.com/4442083/ Please include http://codereview.appspot.com/066/ at the same time as this patch. Thanks, Carl ___ lilyp

Re: Doc: Adjusted CG Policy on @lilypond[] variables (issue4445070)

LGTM. I still want to see the examples of quote, but if those change anything, then you can always modify the CG later. Maybe wait a few hours for Trevor to comment again, then go ahead and push. http://codereview.appspot.com/4445070/ ___ lilypond-de

Re: Allows glissandi between chords (issue4442082)

On Apr 28, 2011, at 8:22 AM, percival.music...@gmail.com wrote: > Looks mostly good, but I second Carl's suggestions. > > > http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly > File input/regression/glissando-chord.ly (right): > > http://codereview.appspot.com/4

Re: Doc: Adjusted CG Policy on @lilypond[] variables (issue4445070)

Reviewers: Graham Percival, Trevor Daniels, http://codereview.appspot.com/4445070/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): http://codereview.appspot.com/4445070/diff/1/Documentation/contributor/doc-work.itexi#newcode314 Documentation

Re: Allows glissandi between chords (issue4442082)

On 4/28/11 6:35 AM, "Carl Sorensen" wrote: > On 4/27/11 5:00 PM, "mts...@gmail.com" wrote: > >> On 2011/04/26 17:11:02, c_sorensen_byu.edu wrote: >>> On 4/26/11 11:00 AM, "m...@apollinemike.com" >> wrote: >> On Apr 26, 2011, at 7:55 AM, mailto:m...@apolli

Re: Allows glissandi between chords (issue4442082)

Looks mostly good, but I second Carl's suggestions. http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly File input/regression/glissando-chord.ly (right): http://codereview.appspot.com/4442082/diff/3001/input/regression/glissando-chord.ly#newcode1 input/regression

Re: rest-collision.cc: adjust all rests in column. Issues 1618 and 1547 (issue4442083)

LTGM, and regtests are fine. http://codereview.appspot.com/4442083/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix "make doc" error: Character set messup in pdf-scheme.cc (issue4449061)

LTGM, please push now. http://codereview.appspot.com/4449061/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

PATCHES: 48-hour notice for rest collisions and faulty warnings in articulate

Sat, 13:00. Allows glissandi between chords http://codereview.appspot.com/4442083/ Articulate patch for barcheck warnings http://codereview.appspot.com/4435069/ Cheers, - Graham ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu

Re: Doc: Adjusted CG Policy on @lilypond[] variables (issue4445070)

http://codereview.appspot.com/4445070/diff/1/Documentation/contributor/doc-work.itexi File Documentation/contributor/doc-work.itexi (right): http://codereview.appspot.com/4445070/diff/1/Documentation/contributor/doc-work.itexi#newcode323 Documentation/contributor/doc-work.itexi:323: and/or singl